Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <98eced9a-8ae5-b1b5-8765-4fce18a96fa4@quicinc.com>
Date:   Tue, 7 Nov 2023 14:01:40 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] arm64: dts: qcom: qdu1000: correct LLCC reg entries
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231107080417.16700-1-krzysztof.kozlowski@linaro.org>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20231107080417.16700-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/7/2023 1:34 PM, Krzysztof Kozlowski wrote:
> According to bindings and Linux driver there is no
> "multi_channel_register" address space for LLCC.  The first "reg" entry
> is supposed to be llcc0_base since commit 43aa006e074c ("dt-bindings:
> arm: msm: Fix register regions used for LLCC banks"):
> 
>    qdu1000-idp.dtb: system-cache-controller@19200000: reg: [[0, 421527552, 0, 14155776], [0, 438304768, 0, 524288], [0, 572293416, 0, 4]] is too long
>    qdu1000-idp.dtb: system-cache-controller@19200000: reg-names:0: 'llcc0_base' was expected
>    qdu1000-idp.dtb: system-cache-controller@19200000: reg-names: ['llcc_base', 'llcc_broadcast_base', 'multi_channel_register'] is too long
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/qdu1000.dtsi | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> index 1c0e5d271e91..618a101eb53a 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> @@ -1446,11 +1446,9 @@ gem_noc: interconnect@19100000 {
>   		system-cache-controller@19200000 {
>   			compatible = "qcom,qdu1000-llcc";
>   			reg = <0 0x19200000 0 0xd80000>,
> -			      <0 0x1a200000 0 0x80000>,
> -			      <0 0x221c8128 0 0x4>;
> -			reg-names = "llcc_base",
> -				    "llcc_broadcast_base",
> -				    "multi_channel_register";
> +			      <0 0x1a200000 0 0x80000>;
> +			reg-names = "llcc0_base",
> +				    "llcc_broadcast_base";


Thanks for fixing this.
This indeed needed to be fixed, looks like it got missed after
moving to below sec-qfprom of reading multichannel.

https://lore.kernel.org/lkml/20230801064025.17381-2-quic_kbajaj@quicinc.com/

Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

>   			interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
>   			multi-ch-bit-off = <24 2>;
>   		};