Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Zhiguo Jiang <justinjiang@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Zhiguo Jiang <justinjiang@vivo.com>
Subject: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue
Date:   Wed, 29 Nov 2023 21:01:26 +0800
Message-ID: <20231129130126.2130-1-justinjiang@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fq9IPqsy7Gsmpjp4z7baQtUHspAplg3LAYIBt1d02S7Cew5/vZOe3mNyMdX6?=
 =?us-ascii?Q?c+lw8mx6KqXuUH5lC18GMrzgYuI6VIWOOlfG/QcfOEzZBYe6tp6vNgTo7MyC?=
 =?us-ascii?Q?YwGxXR5ar/RASQw9sXaOehTEYS48bKXWJzoOTH0yEZDKh43Pn3bdqWk3fqfJ?=
 =?us-ascii?Q?W9qzKtCCNBA/Z2wPihMKLiqsyA3GDXL0wWGjzpwTz+jhiLL93S0MYeAsXYmf?=
 =?us-ascii?Q?5j0zEluTy4BC2WgeleApQfl1BnVhP0muh8/fcnh2fmmj/+U+zm5+R5Kk7NIi?=
 =?us-ascii?Q?65HtgH3l1UUJkMSJKS7jsgJRC13Na6mplvBGS81SFdt9Id6QvCkPw/hONrPH?=
 =?us-ascii?Q?ainGva0P89DjA7mG6qARResJtrpkYVcR5y4yB2o976sw+DrQoALBcwRFtxvo?=
 =?us-ascii?Q?2B3mtRzlkJDDCy5P8wh+hfh6ERwThVY7XdAjviXjwFAN6D9foNGpNFXG2EnZ?=
 =?us-ascii?Q?eN3sP57nGjdolA0PKnUKhyvbQSJMbiMqrRQCPUsIzlQzpvdF/zvjntV1yXy5?=
 =?us-ascii?Q?W0x96WtiZlS9WDagNNI/xyFuTQsqdEOhEoQ+V4tSBH65JiK0o8Xav4KlnTQU?=
 =?us-ascii?Q?zIRVT+lND3Cxx1MKVTKtN7QA7EwN35I3F4+0zUZ/e1eBvBFar9yhGwYZQ0Nu?=
 =?us-ascii?Q?hXYQpHxbLFhcfSwWF972xQW89MFNsuQnJfoFQxhcR0SsZFjp8FUqo5PvmVWV?=
 =?us-ascii?Q?btT45Ql+CZSq00sXodItTn9H/2/K6TpSeHmCBsSuUnHzrpb2gvQBSU4PzzLG?=
 =?us-ascii?Q?5GynP4mMGSjaUMOvhMY7r59kHU3kThbljOLuM/C/X2nvgG3zpzcW1M17lhGH?=
 =?us-ascii?Q?ydCdoXvMM4FMaET4i6gZ6RAQUPYOdQ9NOPpGejWWyTuS6MUBQACNiHB7D8oN?=
 =?us-ascii?Q?R3wLQVpxjNJxhFdfBYH/LX0dqS74G6jibEWSXNwo34n43lmAkbg1Td5HD6Im?=
 =?us-ascii?Q?aa82w8DavavusnoollDF7SrtIMPvVQ9O/A7ERlcDRppVTyW76b4qZIWDwEi+?=
 =?us-ascii?Q?Db3F4cq3Y/297jvZPo0i7vDhgp0oN7CmjwpK8oZn5i5Rpu4djTOoSyAzEQ07?=
 =?us-ascii?Q?05qv3Pdf0Ft6reyQim0ubQ2AbFmRVEEzcbjwXzDC3HGp7/sBWNvDr8ExurGY?=
 =?us-ascii?Q?D6A0x5PwdHDzw+LpngLTWGEJf7l4eSMfKdyco+QpLIaIYBfU6hcE/Fi6XKr7?=
 =?us-ascii?Q?DLSZVpYMyhoUI18TzQDCAEaByu273CN4HfFgCZgA7LApb/cPxmBke/Sizbph?=
 =?us-ascii?Q?EDQ1KuRcQSRHpS+9uJiR+EqoPf3ZzXQrZaB3fyGWTHWSXdhe8p2tP83QTUYL?=
 =?us-ascii?Q?zCOWkJntBLWyCj2WNWVrJ8AWUO8ODrglKfWZ4SFaO24MqDXdiktG/AB2QGID?=
 =?us-ascii?Q?pu30NUQvMudYi2PTrWgWOeneu8umFM8r+T9HmMsEp2XVv3t1gR6uOpS6+b4U?=
 =?us-ascii?Q?3x0FYcebGArwKNUPq6kLdxNu/jkG9360ztwYFDADtVdDxt/+1v0GL/CWY1vM?=
 =?us-ascii?Q?QhbFwvqAX1cu6tU6aGtz7Gk8QgkzpMbyH9llyskUy5X9x1UZxYT6An2Pz6uO?=
 =?us-ascii?Q?DRpVd6WME+XgN13cqKNQcI1xo7r30JGy00SxDFxq?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cff08565-5a1e-4c42-584d-08dbf0db50b8
X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 13:01:34.7044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CKNs+wwByg0UKvMcDYEzE6sKq23/QOTu2mCVBA6jKRfShKJ7sTWfIhawpWdStMW/fNW2a5e9GnBACh5WR9I4QA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6850
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 29 Nov 2023 05:01:51 -0800 (PST)

It is needed to ensure sc->nr.unqueued_dirty > 0, which can avoid to
set PGDAT_DIRTY flag when sc->nr.unqueued_dirty and sc->nr.file_taken
are both zero at the same time.

It can't be guaranteed for the PGDAT_WRITEBACK flag that only pages
marked for immediate reclaim are on evictable LRUs in other following
shrink processes of the same kswapd shrink recycling. So when both a
small amount of pages marked for immediate reclaim and a large amount
of pages marked for non-immediate reclaim are on evictable LRUs at the
same time, if it's only determined that there is at least a page marked
for immediate reclaim on evictable LRUs, kswapd shrink is throttled to
sleep, which will increase kswapd process consumption.

It can be fixed to throttle kswapd shrink when sc->nr.immediate is equal
to sc->nr.file_taken.

Signed-off-by: Zhiguo Jiang <justinjiang@vivo.com>
---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 mode change 100644 => 100755 mm/vmscan.c

diff --git a/mm/vmscan.c b/mm/vmscan.c
index d8c3338fee0f..5723672bbdc2
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -5915,17 +5915,17 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
 			set_bit(PGDAT_WRITEBACK, &pgdat->flags);
 
 		/* Allow kswapd to start writing pages during reclaim.*/
-		if (sc->nr.unqueued_dirty == sc->nr.file_taken)
+		if (sc->nr.unqueued_dirty && sc->nr.unqueued_dirty == sc->nr.file_taken)
 			set_bit(PGDAT_DIRTY, &pgdat->flags);
 
 		/*
-		 * If kswapd scans pages marked for immediate
+		 * If kswapd scans massive pages marked for immediate
 		 * reclaim and under writeback (nr_immediate), it
 		 * implies that pages are cycling through the LRU
 		 * faster than they are written so forcibly stall
 		 * until some pages complete writeback.
 		 */
-		if (sc->nr.immediate)
+		if (sc->nr.immediate && sc->nr.immediate == sc->nr.file_taken)
 			reclaim_throttle(pgdat, VMSCAN_THROTTLE_WRITEBACK);
 	}
 
-- 
2.39.0