Message-ID: <3C29FA05.6C1BED5A@sltnet.lk>
Date: Wed, 26 Dec 2001 10:25:41 -0600
From: Alvin of Diaspar <ioshadi@sltnet.lk>
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] A slightly smarter dmi_scan.c
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

> > > APM can also be compiled as a module.
> >
> > Right. Thanks. I blatantly ignored that APM can be built as modules ;(
> > The fixed patch is here.
  
> I think I prefer it without all the ifdefs being in the code like that. It is
> cleaner to read before the change. I agree the messages being printed might
> be confusing in some cases but I don't like the cure.

	I agree. The code in dmi_scan.c runs very elegantly now, and changing
that flow, although might be more efficient by something like 0.001%,
isn't worth the touble.
	Sorry about adding to the ambient background radiation :)

	- ioj

~~~~
    Ask not of race, but ask of conduct: 
    From the stick is born the sacred fire:
    The wise ascetic, though lowly born,
    Is noble in his modest self-control.
                - Gotama Buddha
.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/