Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   Justin Lai <justinlai0215@realtek.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v10 09/13] net:ethernet:realtek:rtase: Implement pci_driver suspend and resume function
Thread-Topic: [PATCH net-next v10 09/13] net:ethernet:realtek:rtase: Implement
 pci_driver suspend and resume function
Thread-Index: AQHaDaOV4m3XpMTIGEaYaPZneRFztLBqD3yAgBDta/A=
Date:   Wed, 15 Nov 2023 06:22:43 +0000
Message-ID: <cb31aabbf5104992b299682f5ba0e064@realtek.com>
References: <20231102154505.940783-1-justinlai0215@realtek.com>
 <20231102154505.940783-10-justinlai0215@realtek.com>
 <0af3a54f-09da-4a8b-b385-c6968334ace4@lunn.ch>
In-Reply-To: <0af3a54f-09da-4a8b-b385-c6968334ace4@lunn.ch>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Sunday, November 5, 2023 3:52 AM
> To: Justin Lai <justinlai0215@realtek.com>
> Cc: kuba@kernel.org; davem@davemloft.net; edumazet@google.com;
> pabeni@redhat.com; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
> Ping-Ke Shih <pkshih@realtek.com>; Larry Chiu <larry.chiu@realtek.com>
> Subject: Re: [PATCH net-next v10 09/13] net:ethernet:realtek:rtase: Implement
> pci_driver suspend and resume function
> 
> 
> External mail.
> 
> 
> 
> > +static int rtase_resume(struct pci_dev *pdev) {
> > +     struct net_device *dev = pci_get_drvdata(pdev);
> > +     struct rtase_private *tp = netdev_priv(dev);
> > +     int ret;
> > +
> > +     pci_set_power_state(pdev, PCI_D0);
> > +     pci_restore_state(pdev);
> > +     pci_enable_wake(pdev, PCI_D0, 0);
> > +
> > +     /* restore last modified mac address */
> > +     rtase_rar_set(tp, dev->dev_addr);
> > +
> > +     if (!netif_running(dev))
> > +             goto out;
> > +
> > +     rtase_wait_for_quiescence(dev);
> > +     netif_device_attach(dev);
> > +
> > +     rtase_tx_clear(tp);
> > +     rtase_rx_clear(tp);
> > +
> > +     ret = rtase_init_ring(dev);
> > +     if (ret)
> > +             netdev_alert(dev, "unable to init ring\n");
> 
> If you fail to init the ring, is it safe to keep going?
> 
>         Andrew


Thanks for your reply, I will add error handling of rtase_init_ring()