Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <236866a2-41b0-2ad0-db77-4c377367c80e@kernel.org>
Date:   Wed, 15 Nov 2023 14:28:57 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists
Content-Language: en-US
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
References: <20231114212414.3498074-1-jaegeuk@kernel.org>
 <4a0e1c6f-12c4-f3dd-bb26-4bf0aee6be4b@kernel.org>
 <ZVQwz5ubx9LojzEf@google.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <ZVQwz5ubx9LojzEf@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/11/15 10:45, Jaegeuk Kim wrote:
> On 11/15, Chao Yu wrote:
>> On 2023/11/15 5:24, Jaegeuk Kim wrote:
>>> When recovering zoned UFS, sometimes we add the same zone to discard multiple
>>> times. Simple workaround is to bypass adding it.
>>
>> What about skipping f2fs_bug_on() just for zoned UFS case? so that the check
>> condition can still be used for non-zoned UFS case.
> 
> Hmm, I've never seen this bug_on before, but even this really happens, it does

I've never seen it was been triggered as well.

> not make sense to move forward to create duplicate commands resulting in a loop.

Agreed.

It looks those codes were copied from extent_cache code base, do we need to fix
all cases to avoid loop?

> 
> So, the question is, do we really need to check this? Have we hit this before?
Not sure, just be worry about that flaw of newly developed feature can make
code run into that branch.

Thanks,

> 
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>>> ---
>>>    fs/f2fs/segment.c | 3 ++-
>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>>> index 727d016318f9..f4ffd64b44b2 100644
>>> --- a/fs/f2fs/segment.c
>>> +++ b/fs/f2fs/segment.c
>>> @@ -1380,7 +1380,8 @@ static void __insert_discard_cmd(struct f2fs_sb_info *sbi,
>>>    			p = &(*p)->rb_right;
>>>    			leftmost = false;
>>>    		} else {
>>> -			f2fs_bug_on(sbi, 1);
>>> +			/* Let's skip to add, if exists */
>>> +			return;
>>>    		}
>>>    	}