Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <f373645c-1e89-df76-e545-21bf0ba9ee8f@starfivetech.com>
Date:   Wed, 15 Nov 2023 15:52:42 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 1/1] clocksource/timer-risc: Add riscv_clock_shutdown
 callback
To:     Anup Patel <apatel@ventanamicro.com>
CC:     <daniel.lezcano@linaro.org>, <tglx@linutronix.de>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <leyfoon.tan@starfivetech.com>,
        <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
References: <20231115061811.10041-1-joshua.yeong@starfivetech.com>
 <CAK9=C2VXxNjKOq1XqQ9t6iVELdj2fFi85K77xNCOfdf3WRdy8w@mail.gmail.com>
Content-Language: en-US
From:   Joshua Yeong <joshua.yeong@starfivetech.com>
In-Reply-To: <CAK9=C2VXxNjKOq1XqQ9t6iVELdj2fFi85K77xNCOfdf3WRdy8w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Anup,

On 15-Nov-23 3:00 PM, Anup Patel wrote:
> On Wed, Nov 15, 2023 at 11:49 AM Joshua Yeong
> <joshua.yeong@starfivetech.com> wrote:
>> Add clocksource detach/shutdown callback to disable RISC-V timer interrupt when
>> switching out riscv timer as clock source
>>
>> Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com>
>> ---
>>   drivers/clocksource/timer-riscv.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c
>> index da3071b387eb..588a05459b6a 100644
>> --- a/drivers/clocksource/timer-riscv.c
>> +++ b/drivers/clocksource/timer-riscv.c
>> @@ -50,12 +50,19 @@ static int riscv_clock_next_event(unsigned long delta,
>>          return 0;
>>   }
>>
>> +static int riscv_clock_shutdown(struct clock_event_device *evt)
>> +{
>> +       sbi_set_timer(-1);
> Use riscv_clock_event_stop() here.
You mean replacing riscv_clock_shutdown as riscv_clock_event_stop?
>
>> +       return 0;
>> +}
>> +
>>   static unsigned int riscv_clock_event_irq;
>>   static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) = {
>>          .name                   = "riscv_timer_clockevent",
>>          .features               = CLOCK_EVT_FEAT_ONESHOT,
>>          .rating                 = 100,
>>          .set_next_event         = riscv_clock_next_event,
>> +       .set_state_shutdown     = riscv_clock_shutdown,
>>   };
>>
>>   /*
>> --
>> 2.25.1
>>
> Regards,
> Anup