Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2458344rdb; Wed, 15 Nov 2023 00:58:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1DfcEJfxcSJk77UfAZJcowBBPXpsXpy1izuVsLfz3JqApJy5+MWvFUeufu7AtmnlHYN3z X-Received: by 2002:a05:6830:1211:b0:6d6:567a:dd18 with SMTP id r17-20020a056830121100b006d6567add18mr4552572otp.34.1700038730469; Wed, 15 Nov 2023 00:58:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700038730; cv=none; d=google.com; s=arc-20160816; b=tB8FGPx6g2bzv+2G8hcfYzCV6VfL7SCj+0p1U4d+jSCNjRgP0D+fVJGcRtR+Ad8htD TfgCRf2zaFXnq4VZANEelpVAUtkAtgtKJ3yUimei6duA+IecP/5uYC2FO+cvkl0eK7Wt NHGlnIZCiNxsrMJGeMBesBnoukiW9tMLupc3Vy8JAebWHdmZYcgTjjDEI8j1YQA+/xWl jlpISb+pnsBkYp9UeEckcXrSW253+gRzNlwnCDImmkT4bl/rAshVN72A/QuvgF/g3Xyq ZUTey9Yg9fkm75adR97OWRWoQYyL2aM3OBIPZ9hUyIHNwK/QqCyzGGYt7hnSwyeR9O9f ADdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+bqu8OGVwGY3wk4Yv2qfPZ01iivqJQ9CIcetwVB6X/U=; fh=5IwvBwNrEqpzXnKXZrq1U7ok4iXcek4kgL0F4TOPP1k=; b=pX0bfKJ23i4426PHxAu9TMg399ji6wi+hmbxJYkECmjsUPB3okN0oOFc9OzGV2yeoA EA2PKdn6+wW+f55CPE/bMPd8PU914wnjcXdGWCYZVnA506K122P8tURs/WqwWIFvVpVb sdXGKVIu+w5+XZqoU34fS73xfoVGv7EmQx8yM7bhLa0WrS+NuZQNuGfiiyNmFnbhUdGu UWjdIrH3WIDmdjeGr7LQ9BKNzHqdZCr/jkXI9GiMlW3dzf/vZGmFn/9CohP7wysWTYql HWnjmcEUp0eWzuRQv5EXt2biwMSnuO6qdAkVjYmEdvUyLMP23GoEDMObRNX1ap0Fxn4z cofA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u5-20020a656705000000b005ab05858e70si9961656pgf.782.2023.11.15.00.58.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 00:58:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 45E058028B6E; Wed, 15 Nov 2023 00:58:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343548AbjKOI6k (ORCPT + 99 others); Wed, 15 Nov 2023 03:58:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234651AbjKOI6j (ORCPT ); Wed, 15 Nov 2023 03:58:39 -0500 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id C9E1F114; Wed, 15 Nov 2023 00:58:34 -0800 (PST) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id B57E860230185; Wed, 15 Nov 2023 16:58:22 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: s.nawrocki@samsung.com, mchehab@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com Cc: Su Hui , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] media: platform: exynos4-is: return callee's error code rather than -ENXIO Date: Wed, 15 Nov 2023 16:57:54 +0800 Message-Id: <20231115085753.1027348-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 15 Nov 2023 00:58:48 -0800 (PST) Clang static analyzer complains that value stored to 'ret' is never read. Return the callee's error code to fix this. Signed-off-by: Su Hui --- drivers/media/platform/samsung/exynos4-is/fimc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-core.c b/drivers/media/platform/samsung/exynos4-is/fimc-core.c index 97908778e1c8..0be687b01ce5 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-core.c +++ b/drivers/media/platform/samsung/exynos4-is/fimc-core.c @@ -814,7 +814,7 @@ static int fimc_clk_get(struct fimc_dev *fimc) fimc_clk_put(fimc); dev_err(&fimc->pdev->dev, "failed to get clock: %s\n", fimc_clocks[i]); - return -ENXIO; + return ret; } #ifdef CONFIG_PM -- 2.30.2