Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <202311071303.JJMAOjy4-lkp@intel.com> <CACRpkdb4d9pfstqDTZoBSqOSS4d4vLOUCnS6AKcMjLZ8TTQ2Wg@mail.gmail.com>
 <20231115093742.GA32655@ediswmail.ad.cirrus.com>
In-Reply-To: <20231115093742.GA32655@ediswmail.ad.cirrus.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 15 Nov 2023 10:57:29 +0100
Message-ID: <CACRpkdYHJcx8gDsa5P2eLBh6iaVQzZY+-4eMJPKtnQTq3uR6oQ@mail.gmail.com>
Subject: Re: drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting
 "LOCHNAGAR1_" and "(" does not give a valid preprocessing token
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     kernel test robot <lkp@intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 15, 2023 at 10:37=E2=80=AFAM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
> On Tue, Nov 14, 2023 at 02:40:38PM +0100, Linus Walleij wrote:
> > On Tue, Nov 7, 2023 at 6:19=E2=80=AFAM kernel test robot <lkp@intel.com=
> wrote:
> >
> > > >> drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "=
LOCHNAGAR1_" and "(" does not give a valid preprocessing token
> > >       52 |         .name =3D NAME, .type =3D LN_PTYPE_GPIO, .reg =3D =
LOCHNAGAR##REV##_##REG, \
> > >          |                                                     ^~~~~~=
~~~
> > >    drivers/pinctrl/cirrus/pinctrl-lochnagar.c:67:9: note: in expansio=
n of macro 'LN_PIN_GPIO'
> > >       67 |         LN_PIN_GPIO(1, ID, NAME, REG, SHIFT, INVERT)
> > >          |         ^~~~~~~~~~~
> >
> > I looked a bit at this, can this be due to the fact that the macros use=
 defines
> > from include/dt-bindings/...* and that MIPS does not use these includes
> > somehow, such as not using the same dtc compiler?
> >
> > Rob, do you know the story of how MIPS interoperates with <dt-bindings/=
*>?
> >
>
> Is that what is going on here? I though this was the long standing
> problem that MIPS has some global define for RST so the macro that
> string pastes that in, no longer pastes in the letters RST but some
> value instead.

That sounds plausible :D

> It has somewhat been on my radar to fix at some point, but I have
> in general been a little unsure how to proceed. RST feels like
> a mega over generic macro name to be exporting, so in some ways
> feels like fixing that would be nice. On the other side, renaming
> the register on the Lochnagar side would be very easy, although it
> would mean the register naming no longer matches all the hardware
> documentation which would be kinda lame.

If MIPS breaks things like this because of weird defines I would say
it is actually fair to just quirk it in Kconfig with a comment:

  # MIPS occupy very generic defines
  depends on !MIPS

Yours,
Linus Walleij