Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2484166rdb; Wed, 15 Nov 2023 01:57:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEX0Ax8MZJ/wlblBw1XWQZFULRMpdBV/G3cpME69GrZalt7sHz1TSfU7HW6UJ2pGreO2tM X-Received: by 2002:a17:903:41cf:b0:1cc:2f70:4865 with SMTP id u15-20020a17090341cf00b001cc2f704865mr6002914ple.26.1700042267596; Wed, 15 Nov 2023 01:57:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700042267; cv=none; d=google.com; s=arc-20160816; b=hRkLd/hFgUrqrrIPC2TQPp1JbjLfufsHcZqPCmWti4OpcOoIQtNqte02Pye4KYpJ0+ /A5udJtWwSnnEmcWvBrSzcgbfp7w6DVpVJ6p3Yd/MVbJqV3F3Etmld8950AsW/iw+f4n 3ANTHyUbQrgcauHyeo+E4hilmLiNinrwqG9w8dARw3ILuXdNH9YZObrVJq03ow7KXfYx tAW/bS6irYyRLLa4nIvmpFZ+8MSb3Mn60nZ701tUEoN51ebK4s1af2xcIFaS3CZ+SqQe 8lE65O19UXY/ZiO1qmLiFoxHDeJ3pLPH14RzdTb8LYi2XAXm4fgG/BDO1QqrtPao8A17 5udg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=gxy7nTYceeIMGjEVGQxX/YT9AqCUKCeE9lgm8uccCT4=; fh=Dko0HRjz8amTXdUSRvSdgIp9jONktZnPO85S6pXUlFc=; b=LYa5OuynGAS4T9lchwSbGW7P1x//1J3oy3Zu3jGptDGwFWaol/0xQDMSLQQGLOBz0j k4zReVtpr37S0Ew08UXqkasmv9JbT4wyO+e45njcoxBsRwl23pxggi+A0IiiTSOQXWCc r8HU7L3y1NVqbrZtzj0lt/O4DYTHR9/H0DbQwzC5aca3dCXEW3u0E/SysoOeXoahNs+A 7o5t/VYGGDjlHYVhKlR1PA38XOqybEvYfuiVvDmbuomBbY4a9iHz6FJ9Ln24hDSPuEQs 8fztkfpsCexcAM7T3zFuKPHjXUUMwuiAXRWSQbG0C/wlGXSOLWevb4BTXScAusUMwrdW 7LSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GpBNnTh6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id v2-20020a1709029a0200b001cc16aa4983si9420838plp.194.2023.11.15.01.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 01:57:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GpBNnTh6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 308F9813EAA7; Wed, 15 Nov 2023 01:57:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234832AbjKOJ5p (ORCPT + 99 others); Wed, 15 Nov 2023 04:57:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234675AbjKOJ5o (ORCPT ); Wed, 15 Nov 2023 04:57:44 -0500 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF7C7C2 for ; Wed, 15 Nov 2023 01:57:40 -0800 (PST) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-da41acaea52so6750196276.3 for ; Wed, 15 Nov 2023 01:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700042260; x=1700647060; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gxy7nTYceeIMGjEVGQxX/YT9AqCUKCeE9lgm8uccCT4=; b=GpBNnTh67xn3DZXYOiGI3j2GwFNXk+1CZo4IQtku6U2v6Cef27OUTRQd1yOdJcE59n chrNlNf8V5qhpECroLq07tZ86J4yTZzMLd4/9DYDcUnJ1V3gUP7szw5HyecJCgO9qXFc YDi4j+/s3hwCUhUS5vFQERuReSlxZ/sa0eOHsfVLtRjh2Btb6jqE5UioEhNAMRb+1a2d 3Tu8uBl+MtnTO69ZLt4LTmBkwwX23qlTeSAyvMVdxIoul3oHJwD6vl0rk5dbKSa3AY2S pn7nGheqm8Rl0JzpNxdsReH+LC9fM7eyzkz6tA6LT9fQ/b4zRb4EQosvzq4Cqj5O+iVG Ilaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700042260; x=1700647060; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxy7nTYceeIMGjEVGQxX/YT9AqCUKCeE9lgm8uccCT4=; b=Wici80TeboVk+abkI4zg5egvIVAV3cVwHYpIJEp/8oP+L27SEuHy6ju6bi2Mtx2EY0 mnV0GYpLDy0Qw6fE7VlaodEfQ2ubhpiv+YvWFEoI+t43r5l5miCsUN9eNNp/7wVBKU4z fI9sNzgLjOXLV5FzwC0GRPP/I1J61l4SrQj1iBPmIcNdf4vzXYHhy7BJjDVSg1Oxedyg AL83JdwXwkW6fbyKhalNLwu69RZH/AN8UkAI7a2Up61tlYS0sGaCyTe8UbLaW4JQc0Of jPr16LUqaVKVAR0dQvN10HSySxFDFKWksRHKwSHzgz54RvC4/oa2i6rix5y23/CjZZsF nVgg== X-Gm-Message-State: AOJu0YxnM8KmKtehNxO1e9ktrc9qHcbhAt/Q4ENkTXknaX7q0PzQ0dPs GLexNdQx/+W2RMAjk4i35zEOBa/sH1lV3MH7oM3PGeU1lO6oHtJ4 X-Received: by 2002:a25:b199:0:b0:d9b:417:139c with SMTP id h25-20020a25b199000000b00d9b0417139cmr11369274ybj.60.1700042259999; Wed, 15 Nov 2023 01:57:39 -0800 (PST) MIME-Version: 1.0 References: <202311071303.JJMAOjy4-lkp@intel.com> <20231115093742.GA32655@ediswmail.ad.cirrus.com> In-Reply-To: <20231115093742.GA32655@ediswmail.ad.cirrus.com> From: Linus Walleij Date: Wed, 15 Nov 2023 10:57:29 +0100 Message-ID: Subject: Re: drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "LOCHNAGAR1_" and "(" does not give a valid preprocessing token To: Charles Keepax Cc: kernel test robot , Rob Herring , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 01:57:46 -0800 (PST) On Wed, Nov 15, 2023 at 10:37=E2=80=AFAM Charles Keepax wrote: > On Tue, Nov 14, 2023 at 02:40:38PM +0100, Linus Walleij wrote: > > On Tue, Nov 7, 2023 at 6:19=E2=80=AFAM kernel test robot wrote: > > > > > >> drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "= LOCHNAGAR1_" and "(" does not give a valid preprocessing token > > > 52 | .name =3D NAME, .type =3D LN_PTYPE_GPIO, .reg =3D = LOCHNAGAR##REV##_##REG, \ > > > | ^~~~~~= ~~~ > > > drivers/pinctrl/cirrus/pinctrl-lochnagar.c:67:9: note: in expansio= n of macro 'LN_PIN_GPIO' > > > 67 | LN_PIN_GPIO(1, ID, NAME, REG, SHIFT, INVERT) > > > | ^~~~~~~~~~~ > > > > I looked a bit at this, can this be due to the fact that the macros use= defines > > from include/dt-bindings/...* and that MIPS does not use these includes > > somehow, such as not using the same dtc compiler? > > > > Rob, do you know the story of how MIPS interoperates with ? > > > > Is that what is going on here? I though this was the long standing > problem that MIPS has some global define for RST so the macro that > string pastes that in, no longer pastes in the letters RST but some > value instead. That sounds plausible :D > It has somewhat been on my radar to fix at some point, but I have > in general been a little unsure how to proceed. RST feels like > a mega over generic macro name to be exporting, so in some ways > feels like fixing that would be nice. On the other side, renaming > the register on the Lochnagar side would be very easy, although it > would mean the register naming no longer matches all the hardware > documentation which would be kinda lame. If MIPS breaks things like this because of weird defines I would say it is actually fair to just quirk it in Kconfig with a comment: # MIPS occupy very generic defines depends on !MIPS Yours, Linus Walleij