Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2497069rdb; Wed, 15 Nov 2023 02:26:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnF1djQ0mptEndnGZKGki3MaqEb+zsOBhCtpZWy1PZA5TK1JfTyGCI1fgnZE8eyUg9Qzs+ X-Received: by 2002:a05:6a00:10c8:b0:690:fe13:1d28 with SMTP id d8-20020a056a0010c800b00690fe131d28mr14841344pfu.33.1700043964531; Wed, 15 Nov 2023 02:26:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700043964; cv=none; d=google.com; s=arc-20160816; b=xWGJUCIakAPRoCehtIF+dpBpY1vuNK8maNkEvabVPOwGsMa6Jl1DzsscfZItsdSYQR IGvppfpzNO9r9L6P8jHainsBKuzAiLejxMRJdV1M98kL50enzknHy1uzMzjq/G4kxMOm FYa2ib/CuTA+xKxPiIy6xgve3NbpTyH9fzIdnS5IexPCHFlcBg4c9mQ+q3unPPprDFRF k1yV2zlmWg62dC6ahuSIY7Xqu6c0kys4ifwVHVfheVMvAeqB+7IIhFfrTe65ySkeAOzM S9o5TwGcNXyKwBbBGO+IR8MuzWfyVi2Kcj5WEGA1R1GYzCXD1YNvUUf1UGX/fGqgCnt+ YSOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WU5nZyJTrXQvRiyk3lOymBc4LYlI1sgiF28uWIkTirM=; fh=8jSUINxFowMrXfbaffmsR4MCVX8tlue9CJ5KTWZfgGo=; b=K7OPMYibvpKLpwk8w5wZusI2erv8SWsnByhOeMIiyDpPCy/HS4CEmS/xEV4mnWjPDs p9G+0SJ/oCW6LG9/1ZpuBwGkqeHYbxAutaZGmVge01iDkZ3Bvc3LQ5UgjXfX2PVhfPwQ l2U2rkvPpoytkp+e/Xtm/dtZnlqKM3Jv9Giz/w0JYLmDCvcwCCb0Wz88wLwgqshJ/qPO kRXqjfQlOs1ogae9fHJ5JPfQOl/dNGrOzhSctOEnduJg2TdQOzveW5iRqIZN7lMwpnjb gbF1ujlJDQUiYbI8N8HOvr6mX9rKVMuFTVR0ratJQeGMT2KCVEcIW7QazAzkA55UIo67 HzpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=fcJoEjzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id d5-20020a633605000000b005c1b2d279f3si3936302pga.342.2023.11.15.02.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 02:26:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=fcJoEjzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 0B75E8020A31; Wed, 15 Nov 2023 02:26:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234116AbjKOKZx (ORCPT + 99 others); Wed, 15 Nov 2023 05:25:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234098AbjKOKZv (ORCPT ); Wed, 15 Nov 2023 05:25:51 -0500 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D6C12A for ; Wed, 15 Nov 2023 02:25:47 -0800 (PST) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3AF8RKgq026572; Wed, 15 Nov 2023 04:25:39 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s= PODMain02222019; bh=WU5nZyJTrXQvRiyk3lOymBc4LYlI1sgiF28uWIkTirM=; b= fcJoEjzLBcQMRe4moUkamR7m0tXtlYT0/Wil5LaBXNxAfIYnJFDSjRw/O0EerTxt 0W3t9sIobZh/L8mujHuIZ5wSD0uoPOFA14kILnjnflOTtjbDGJgVhkz5TrVQWk7z Eb50s4oNtdIbdPHeZryazf2J7pq4glW7g8ooOlI0aNEQndzo1MSCTpVLraaOzgtO XqwBM/UOZ6E6IYjsbnHWrIO+EE89VGhpBhdoou6JMfqUbbEgoIW8fj/bbJLcGmY8 zplycEsQWLJSHVEEgI1aiemSy76fZKLlMphtxpilno5QeU+S6IfBW4e+4KtRlTGr x51Phbq/UPhg5T++YZ4GeA== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3ua6wpch3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 04:25:39 -0600 (CST) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 15 Nov 2023 10:25:37 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.39 via Frontend Transport; Wed, 15 Nov 2023 10:25:37 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 7851915A1; Wed, 15 Nov 2023 10:25:37 +0000 (UTC) Date: Wed, 15 Nov 2023 10:25:37 +0000 From: Charles Keepax To: Linus Walleij CC: kernel test robot , Rob Herring , , Subject: Re: drivers/pinctrl/cirrus/pinctrl-lochnagar.c:52:53: error: pasting "LOCHNAGAR1_" and "(" does not give a valid preprocessing token Message-ID: <20231115102537.GB32655@ediswmail.ad.cirrus.com> References: <202311071303.JJMAOjy4-lkp@intel.com> <20231115093742.GA32655@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: rOqXo6meEJM6lTSU5Tw9mjRheaugKhQM X-Proofpoint-ORIG-GUID: rOqXo6meEJM6lTSU5Tw9mjRheaugKhQM X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 02:26:00 -0800 (PST) On Wed, Nov 15, 2023 at 10:57:29AM +0100, Linus Walleij wrote: > On Wed, Nov 15, 2023 at 10:37 AM Charles Keepax > wrote: > > On Tue, Nov 14, 2023 at 02:40:38PM +0100, Linus Walleij wrote: > > > On Tue, Nov 7, 2023 at 6:19 AM kernel test robot wrote: > > It has somewhat been on my radar to fix at some point, but I have > > in general been a little unsure how to proceed. RST feels like > > a mega over generic macro name to be exporting, so in some ways > > feels like fixing that would be nice. On the other side, renaming > > the register on the Lochnagar side would be very easy, although it > > would mean the register naming no longer matches all the hardware > > documentation which would be kinda lame. > > If MIPS breaks things like this because of weird defines I would say > it is actually fair to just quirk it in Kconfig with a comment: > > # MIPS occupy very generic defines > depends on !MIPS > Hm... hadn't considered that. The driver is pretty unlikely to be needed on MIPS anytime soon, so might be a reasonable work around for now. Would you like me to fire in a patch, or you want to? Thanks, Charles