Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <4184a40b-2b1a-4692-bd9b-b7639768a86b@quicinc.com>
Date:   Wed, 15 Nov 2023 18:31:41 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] pinctrl: avoid reload of p state in list iteration
To:     Linus Walleij <linus.walleij@linaro.org>
CC:     <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@quicinc.com>, <stable@vger.kernel.org>
References: <20231115010906.35357-1-quic_aiquny@quicinc.com>
 <CACRpkdbmw=goFFiSYOC4_ybiHiiBJJqmVv2Gh=v5nuTnQ1Z1Gg@mail.gmail.com>
From:   "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
In-Reply-To: <CACRpkdbmw=goFFiSYOC4_ybiHiiBJJqmVv2Gh=v5nuTnQ1Z1Gg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/15/2023 5:58 PM, Linus Walleij wrote:
> Hi Maria,
> 
> On Wed, Nov 15, 2023 at 2:13 AM Maria Yu <quic_aiquny@quicinc.com> wrote:
> 
>> When in the list_for_each_entry iteration, reload of p->state->settings
>> with a local setting from old_state will makes the list iteration in a
>> infinite loop.
>> The typical issue happened, it will frequently have printk message like:
>>    "not freeing pin xx (xxx) as part of deactivating group xxx - it is
>> already used for some other setting".
>> This is a compiler-dependent problem, one instance was got using Clang
>> version 10.0 plus arm64 architecture.
>>
>> Signed-off-by: Maria Yu <quic_aiquny@quicinc.com>
>> Cc: stable@vger.kernel.org
> 
> Thanks, very much to the point.
> 
> Can you please send a v3 and add the info Andy requested too,
> and I will apply it!
> 
> Yours,
> Linus Walleij
Thx Linus Walleij for your quick response.

here it is:
[https://lore.kernel.org/lkml/20231115102824.23727-1-quic_aiquny@quicinc.com/]

-- 
Thx and BRs,
Aiqun(Maria) Yu