Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2506737rdb; Wed, 15 Nov 2023 02:48:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0DbmtOw24zXARKroeEuXHaYUD6qNeIxACUqxAF6Z09kOz7aMZgikSR4OoQVo03OR1O1we X-Received: by 2002:a05:6a20:3d15:b0:187:6d0a:c315 with SMTP id y21-20020a056a203d1500b001876d0ac315mr1073320pzi.23.1700045305611; Wed, 15 Nov 2023 02:48:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700045305; cv=none; d=google.com; s=arc-20160816; b=KgNp3GYBOxIStN+/qpLkPxf5rncLEkOju/rAv1FuoMGKUt41FUxlZZF2cU0oLsH9ou Y9ozmMMV4cWJMw9+oGSulglWSKXaneoaLYj0zYWPmzlb+D6NG2b2JYlXVJhxUaO+8aSH FoyQPVtiapoQAboHvvapB82C3P/tZXfTOrRJYTyXJ/RJd8B5Hkj8nDUIsj7YK5cc1Olv OfqU1nGv+mxGEuuiDbnZL2ydzIhWdCHihpIsM+PS9sGU53GWWeQtv48RvXGQD+X4gHVk d2hdaZ4n+C6A/HflAsu/ly/BrobQM02W9/gztYmqXB8wXNbMW0O3FfpeX0uFmMZJXVMl ZhCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sY+7WKoyMMy/V4oZ7M1gjiU0erpOSU8OhEEVrkBYQUU=; fh=Bv23+ttCug3rT/y/Z3tqN8zMCg7MVePwKyNaHa8qq6I=; b=QgakqX9gDSfNCDEzvh4Zt8NEvgUZeQPERkTNVrCsOlcE4f9azQKESkZnExa/j+6+Wp UK+dWUb3kQBH5yCvloYbhb9zcqRBSsbO2GhqVuCER9xhQe710rBt1hlxYa43/Ry78Wvs rzchgOgN8Ydn6wzCRD4fdg6Q/aFCWDColTMDcvL44cMKTzL16M9X/zpYgRiMAcE00+PP ugtmg2CFyJbR+WelLk+DqqSx3WUybnK2E+3Ovcpb0bPo30dKSxwU/hJTv/GbFNSXXd5J e9Ool0SXr+dQ4CaR9oFxKBtqHe0HxKH1SclBXigDce4hN4/fSfDhY08rQHTSTDVrMBK3 h+AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C6rlyFwF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bj6-20020a056a02018600b005c14fc66ccasi9338931pgb.370.2023.11.15.02.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 02:48:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=C6rlyFwF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B5152801DC45; Wed, 15 Nov 2023 02:48:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234902AbjKOKsP (ORCPT + 99 others); Wed, 15 Nov 2023 05:48:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234098AbjKOKsO (ORCPT ); Wed, 15 Nov 2023 05:48:14 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E0010F for ; Wed, 15 Nov 2023 02:48:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700045290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sY+7WKoyMMy/V4oZ7M1gjiU0erpOSU8OhEEVrkBYQUU=; b=C6rlyFwFnZCmCX21Ng1jeAp4+4woAUIp70bFJ5GyxTrWPZap27rv+iNIm6fhK7FO00rUp0 josm2tSnTOX99GBVWcXb8Rbh/VfhTPTK6Pb9SOWTQ4VHGtKQ1P2Ktj5H5EsoxuWOSItbhh PPBwEoS1/Jv6hY2LkMmsRM3Jlk97Hm8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-a2i6MBMUOI-iZjeE1juWsg-1; Wed, 15 Nov 2023 05:48:06 -0500 X-MC-Unique: a2i6MBMUOI-iZjeE1juWsg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B4C7229ABA09; Wed, 15 Nov 2023 10:48:05 +0000 (UTC) Received: from virt-mtcollins-01.lab.eng.rdu2.redhat.com (virt-mtcollins-01.lab.eng.rdu2.redhat.com [10.8.1.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4637F40C6EB9; Wed, 15 Nov 2023 10:48:05 +0000 (UTC) From: Shaoqin Huang To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Shaoqin Huang , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] KVM: arm64: selftests: Clean up the GIC[D,R]_BASE_GPA Date: Wed, 15 Nov 2023 05:47:57 -0500 Message-Id: <20231115104757.15710-1-shahuang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 02:48:23 -0800 (PST) The GIC[D,R]_BASE_GPA has been defined in multiple files with the same value, define it in one place to make the code clean. Signed-off-by: Shaoqin Huang --- tools/testing/selftests/kvm/aarch64/arch_timer.c | 3 --- tools/testing/selftests/kvm/aarch64/vgic_irq.c | 3 --- tools/testing/selftests/kvm/dirty_log_perf_test.c | 3 --- tools/testing/selftests/kvm/include/aarch64/vgic.h | 3 +++ 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/kvm/aarch64/arch_timer.c b/tools/testing/selftests/kvm/aarch64/arch_timer.c index 274b8465b42a..818854007bfd 100644 --- a/tools/testing/selftests/kvm/aarch64/arch_timer.c +++ b/tools/testing/selftests/kvm/aarch64/arch_timer.c @@ -59,9 +59,6 @@ static struct test_args test_args = { #define msecs_to_usecs(msec) ((msec) * 1000LL) -#define GICD_BASE_GPA 0x8000000ULL -#define GICR_BASE_GPA 0x80A0000ULL - enum guest_stage { GUEST_STAGE_VTIMER_CVAL = 1, GUEST_STAGE_VTIMER_TVAL, diff --git a/tools/testing/selftests/kvm/aarch64/vgic_irq.c b/tools/testing/selftests/kvm/aarch64/vgic_irq.c index 2e64b4856e38..a48aff110fb6 100644 --- a/tools/testing/selftests/kvm/aarch64/vgic_irq.c +++ b/tools/testing/selftests/kvm/aarch64/vgic_irq.c @@ -19,9 +19,6 @@ #include "gic_v3.h" #include "vgic.h" -#define GICD_BASE_GPA 0x08000000ULL -#define GICR_BASE_GPA 0x080A0000ULL - /* * Stores the user specified args; it's passed to the guest and to every test * function. diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c index d374dbcf9a53..4971e8f77a0a 100644 --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c @@ -22,9 +22,6 @@ #ifdef __aarch64__ #include "aarch64/vgic.h" -#define GICD_BASE_GPA 0x8000000ULL -#define GICR_BASE_GPA 0x80A0000ULL - static int gic_fd; static void arch_setup_vm(struct kvm_vm *vm, unsigned int nr_vcpus) diff --git a/tools/testing/selftests/kvm/include/aarch64/vgic.h b/tools/testing/selftests/kvm/include/aarch64/vgic.h index 0ac6f05c63f9..9dbb342fd808 100644 --- a/tools/testing/selftests/kvm/include/aarch64/vgic.h +++ b/tools/testing/selftests/kvm/include/aarch64/vgic.h @@ -33,4 +33,7 @@ void kvm_irq_write_isactiver(int gic_fd, uint32_t intid, struct kvm_vcpu *vcpu); #define KVM_IRQCHIP_NUM_PINS (1020 - 32) +#define GICD_BASE_GPA 0x08000000ULL +#define GICR_BASE_GPA 0x080A0000ULL + #endif // SELFTEST_KVM_VGIC_H -- 2.40.1