Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <70f12e96-0fcc-4954-8507-27cf5e15a3b2@redhat.com>
Date:   Wed, 15 Nov 2023 13:33:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go
Content-Language: en-US, nl
To:     Brenton Simpson <brentons+appsforartists@google.com>
Cc:     Allen Ballway <ballway@chromium.org>,
        Patrick Thompson <ptf@google.com>,
        Jared Baldridge <jrb@expunge.us>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-kernel@vger.kernel.org,
        Brenton Simpson <appsforartists@google.com>
References: <20231114233859.274189-1-appsforartists@google.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20231114233859.274189-1-appsforartists@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Brenton,

On 11/15/23 00:38, Brenton Simpson wrote:
> The Legion Go has a 2560x1600 portrait screen, with the native "up" facing the right controller (90° CW from the rest of the device).
> 
> Signed-off-by: Brenton Simpson <appsforartists@google.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

But I cannot merge it because your "From:" which is <brentons+appsforartists@google.com> and the email address which you have used for your Signed-off-by: <appsforartists@google.com> do not match.

And I have no idea which one of those 2 addresses actually works / is yours. I suspect the From: is the right one though ?

Also you have forgotten to Cc: dri-devel@lists.freedesktop.org so this patch is not available in the drm patchwork instance.

Can you please send a v2 fixing both issues ?

Regards,

Hans


> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d5c1529..3d92f66 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
>  		},
>  		.driver_data = (void *)&lcd1200x1920_rightside_up,
> +	}, {	/* Lenovo Legion Go 8APU1 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,
>  	}, {	/* Lenovo Yoga Book X90F / X90L */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),