Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 15 Nov 2023 15:49:05 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jan Dabros <jsd@semihalf.com>,
        Andi Shyti <andi.shyti@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v3 01/25] i2c: designware: Delete adapter before
 disabling in i2c_dw_pci_remove()
Message-ID: <ZVTMUWn3UT99sRaU@smile.fi.intel.com>
References: <20231110182304.3894319-1-andriy.shevchenko@linux.intel.com>
 <20231110182304.3894319-2-andriy.shevchenko@linux.intel.com>
 <fa91c90d-c0d6-49d1-a7e5-732aac0c7ed5@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fa91c90d-c0d6-49d1-a7e5-732aac0c7ed5@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Nov 15, 2023 at 11:45:10AM +0200, Jarkko Nikula wrote:
> On 11/10/23 20:11, Andy Shevchenko wrote:
> > Make i2c_dw_pci_remove() to be aligned with dw_i2c_plat_remove() on
> > the sequence of the ceasing I?C operations.
> > 
> > Fixes: 18dbdda89f5c ("i2c-designware: Add runtime power management support")
> 
> I think this is wrong. Commit 18dbdda89f5c is 12 years ago so is this patch
> really fixing a real bug that was hiding all these years?

Why not? But let me check more careful the ordering between two and probe.

-- 
With Best Regards,
Andy Shevchenko