Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
To:     Justin Stitt <justinstitt@google.com>
Cc:     Adam Radford <aradford@gmail.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: 3w-sas: replace deprecated strncpy with strscpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1il632k51.fsf@ca-mkp.ca.oracle.com>
References: <20231023-strncpy-drivers-scsi-3w-sas-c-v1-1-4c40a1e99dfc@google.com>
Date:   Wed, 15 Nov 2023 08:58:43 -0500
In-Reply-To: <20231023-strncpy-drivers-scsi-3w-sas-c-v1-1-4c40a1e99dfc@google.com>
        (Justin Stitt's message of "Mon, 23 Oct 2023 19:50:57 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aM6fSGXdhiNCw2+Tv65QpV7LHjA7+/s2zlGETyl01NHSfgncPDnpD7eQb0Pn?=
 =?us-ascii?Q?ji63REg+3JD5Lir3Ph34AGIG9sjkly4gJIeY3udoN3eccUHbmVHRjm13kLEX?=
 =?us-ascii?Q?A3G8f6SvHz9alGwfCYM8xw4C5pQwjt8ympP51hydw0tEwyPce8nsCidQwdVs?=
 =?us-ascii?Q?g6OTvK20cHpBz6CQ7eEj2aLICF8rirLtp66OtB2k+CLesLYDsYHMcfbfp23r?=
 =?us-ascii?Q?ApKHHN5brVE+TALL2zrgDWnKd3GitASlY/aTYEKN8Z2JyuG1eqx70CDpuPt3?=
 =?us-ascii?Q?EoQA+LfMMRvwqTL0B9W2yIdmkUnwaCjfg7q2BtRudGjyHTAL2bdGimdL7XJC?=
 =?us-ascii?Q?1VQeUowxo04BUzjhtLx+bHiX/SSIJSVKK2NuzxEymA41zUUpMM5gKRcTjvER?=
 =?us-ascii?Q?T0ncNzog+uJDEHs5LAs6iLIXZ6LG7D7jPNpYYkQu4JZF2X6mLz5C+HwNNBtE?=
 =?us-ascii?Q?EufVkL4YlbXrMOA/vz4Sav3CjBmcrWIKd6eKRkcbCBgtzjacb1edvVMWnOHH?=
 =?us-ascii?Q?JJXCpBkMc2rJ6F6gzZK+d25xCzkbwT0mzdMeOEYKWCic6J/Hv0Jzb10kjmUW?=
 =?us-ascii?Q?NOdTL5BRkB3NRejJl6h/LC8kpOf1Nw+C9vSzt8ROPmDN+gGpLM+ldFkd3Ym8?=
 =?us-ascii?Q?LTPUSjENoNWnY71LdHHbW6yOlpwXVeG+VB5quYJHj6eq+OOrKHtNGHBwMhmR?=
 =?us-ascii?Q?rRQFV2Sg+hVQnmYcm7CZHKXQA8SfJAgO9WmlG3N5py6y5TRrUKFlTtGHtmNZ?=
 =?us-ascii?Q?GTEdgDXp3LargS8xlXTIagHTqgeWktt+6ulaNWwmHVsqFmmfMuCO8DLWMjXm?=
 =?us-ascii?Q?cjsK0Ny+urPQyVHsRzP8FSJ1wRUodUG70wALtjG8fgBpx3n619QJRJuJ9LzJ?=
 =?us-ascii?Q?viBFmvo3Ug7sjDo2wBTaXca0sMsgPB26ml8L/O/vmgmLImB2d+jH3Fn7NlnI?=
 =?us-ascii?Q?R2OrdTrO70/5zF6mm8oRz3H3fM4lNEGtgr3I6xVZYPah6XqAPuUSjg2xIK61?=
 =?us-ascii?Q?IsDMyxeWyTVR5rheAe9wZ/LSeq5Mg4+BngSWN0IWn0QEEPn0w6PI29iGO8/v?=
 =?us-ascii?Q?T/ZHexXFKnodzepaDhw4PnOSi4+SWUpW33jt8mO+uL25e20PI7Wd0pSpxUZ/?=
 =?us-ascii?Q?6oxHeeKoVUU3tBU6f/mbQm8Y8fyySaDDoF8EgxVtapJKjEwtll09rEp/A2xg?=
 =?us-ascii?Q?2sZ9L2it2LwuTkDhykR/uqMKokd86lFyvFRFUhq0fkA1L8mqSwUqiv7oklKf?=
 =?us-ascii?Q?nE8qXxK9PAJ37ldRq1/0J3P4viNmC/8xuMd5PdJOqgX0ar4tx36OduImptHF?=
 =?us-ascii?Q?LaP5sYm4DjAvW4y7ARhiKuRy5t9T3jf+IK1rHH7CPZahJAe3sk3biL7kLbaB?=
 =?us-ascii?Q?ejI0br9cmvbae5IcwZqnSRNYblqRvdMcysQmyw2pqs4pkrZ0iMOJoLzaG8HD?=
 =?us-ascii?Q?W8teD6o+DT3e+rcDrkI3CxVtuki6TvYryYdka2B+2fpiutjw5o+Tx0eYVOqc?=
 =?us-ascii?Q?wcpBMg7KFbYUGpugiLOocQVFlFSPJ0gdShqYIFIku6fCWGjgkS38noKvJksV?=
 =?us-ascii?Q?VGm4sfLaHUsNDYs1HIn+jdcM1K4UUHvtXjLDC/+RToBYlr81TXOijMVGjV1q?=
 =?us-ascii?Q?6g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ie9Cni/xLbtDHl1BstFp1ylIIIwILscJoYeY1HDRaUjE4SOVUgYLjWIG4iHNPmWrcIoYGf1EOuwKAmWdxVUCZm85wEpkSDuamNyK9Dz/dW62jqELLj4JjKbvrxmv9AyyhujZwmpRjHxLiP+k/zd8uKIkGkWAOY8PJXgNv9zELh7pcNCiLnnvAJv4i5BOVtH0yuKfZSy7+61oHF1ERgSeX+IzSpLn4b2/+iRCK8ZFTHbc9bcYIf1Eov8pUdDNpfdappCsiccyIagIApHNdQKCdRvAurLfjW3/P6Ia6C9FyHtJPyWUOrZdxcbmmGu7+f3CQjfDc/JfdQ95x/1L7hnS2+C8MICwKF2cA/s23plyl14y/HRubv2CIlur2ISA2xj5+uFp2ylP0DQoXUT/vtB6GhczM8M03kQGvzHwRKP2Odr08jmA2F3GH9eTQXHBLNNGqeijHjYjRAkI6lzIUR9erZzezn1KIXNOmtNWAkYM/UJzXkiFtUKJ6KUuy27t2amIRetELi28NHs/bb3NGxS6tXlqfXOam6PNyoZ/Dvnskenb9LKTGSm2PML/mMdotryB8T+jf2bvsX6U3Q+gVh/aZCUuktzZyVcvP1hTr6YiRBr6Wqdv0o+NF8n8wzMTr5vfMU+LUE/ovQkVERZgYbC2KHN2FRWlLXr3scuVbZrRvoH9YE4FIQyRNXggNYU1QcjMQev6/hJ/DDO64X3SNWBrdwLbCcGgdNIreVDszy7jb3WLDN5ZOHVMGARBE0xV3Je7/g1n3pQ+iCZo4+obPZYqh2k1sNQBTqQbRp7BAquk1N18NhxM6Al+QFzmsa2HS91AKvn4ZUtWIf9tD9cZfeeiuqR4VZIgntpM61RlFm6xP7I=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd2b2b0-110d-40db-c8d1-08dbe5e2fba4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 13:58:45.1537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zkf24Bj4FdXFV95pzlZfbVVvmprJRsVEYwn8jTzqs1u0pqp1Hz8PGjlniU7GzLXBi/OmAjOzbrgPd3grfxN+vd12bYG2OXnl29v7GQJbjtk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6480
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-15_13,2023-11-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0
 mlxlogscore=773 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311150108
X-Proofpoint-GUID: SXV5KO12XEmP90VKCxyY1EM8LOse5Wa8
X-Proofpoint-ORIG-GUID: SXV5KO12XEmP90VKCxyY1EM8LOse5Wa8
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 15 Nov 2023 05:59:11 -0800 (PST)


Justin,

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering