Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
To:     Justin Stitt <justinstitt@google.com>
Cc:     Saurav Kashyap <skashyap@marvell.com>,
        Javed Hasan <jhasan@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: bnx2fc: replace deprecated strncpy with strscpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1cywb2k0h.fsf@ca-mkp.ca.oracle.com>
References: <20231023-strncpy-drivers-scsi-bnx2fc-bnx2fc_fcoe-c-v1-1-a3736943cde2@google.com>
Date:   Wed, 15 Nov 2023 09:01:30 -0500
In-Reply-To: <20231023-strncpy-drivers-scsi-bnx2fc-bnx2fc_fcoe-c-v1-1-a3736943cde2@google.com>
        (Justin Stitt's message of "Mon, 23 Oct 2023 20:12:22 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?95VM8szlKBvdk0PhbuoqHcpWou3s7lY4OVew2QzBBDDWAW1082Nc952ZbhdW?=
 =?us-ascii?Q?aHp8LxJ6v8F4oRKsZl7sY5ECEvLTqX6nWqvfnWLRq14j3O6KIusq8Qt/Csrl?=
 =?us-ascii?Q?5qNtsCtHp7tHfmFPn/jYF0lf5zYjpToAbmn16ix1y1A/o29FAo7WkCAn1wBZ?=
 =?us-ascii?Q?ZFfeitJqZZgWAIEn8Jv7VU4Awg8S/tkUuoKakHF/dVrny915WDjbFu0+OhpO?=
 =?us-ascii?Q?lhlnsEf51TOxlysLNebWYenAnRI30QKn3NqD7tJz14jUuW4JmbSFLwMM/yt9?=
 =?us-ascii?Q?nAyaSZ54OG9husu+BcXQQ/j64uu9/s5IS+iKJwJWsuPAJWhdg7OqWROdLCji?=
 =?us-ascii?Q?NhbpC6bIRavtLxX5fFOHpuI5quvgTvD+G8R3Tee0E9xszwDf2tne0i4MyHiW?=
 =?us-ascii?Q?bvNFNGG9f63neXU77139lgWaK5LG9ehb01nlmNZOmSL06BEP3x26rY66Ko5Q?=
 =?us-ascii?Q?xToiTH6hfZRsXZjcta4n/RjibiNQ9scW0BlpZcxOtBOn/QKr0ZE7kaNprplA?=
 =?us-ascii?Q?jj1UR+Uo2Bb4fiOytkTYUIMfCll3IQw8MemtxIql0pkyACzK9vzvC7D7BfAP?=
 =?us-ascii?Q?GtCHev4rIfGMcAruroUiPbGRXWjrI/zv3/eiS86w/jisO1lOqXCqyZRO96fq?=
 =?us-ascii?Q?zvo0CQo1pYVrkZ+cQqmKqa4Esm28IPr9+cR57gZzSd0mIrcJzxyld+hSfkfx?=
 =?us-ascii?Q?PJbV38ZRlYzkJR77ri2x+8FvGOpXGlOW95KoTH8Ec/9CPyComV87VymPW0cQ?=
 =?us-ascii?Q?ZFi12/DmSdtAcjztFbUvNBabni4SOE8lOybqznZ1oRKy+lkgJOPDbIVw/BoE?=
 =?us-ascii?Q?yBvtXPJHF/xQwwggHbQXRMgtqy6lGVyUCgt6RUrIM8HKLTOb+McG4+AdaJKu?=
 =?us-ascii?Q?XE3hc9nhRad7Z9kYPITXzFQVuzBVToJX24UpirmgcnOic9KSsCOYVnl2MF8C?=
 =?us-ascii?Q?r6vfgGpi9ozE3zhZxdlOUMwH4VmLOO53XMH0fMG5V7pbJgmGI04dDxTvLwMx?=
 =?us-ascii?Q?zY7ChA/twNGApNXxWN+Rq0nJ0guQKtjszqm89LSmpAv/7Wcv5o6eFJOMZp81?=
 =?us-ascii?Q?+rBEbSSsFiAF5OyNwrv7iFnVwsD1ZuRX/B4bCtuueWLl692FrzaGuquYogOZ?=
 =?us-ascii?Q?0wGKrGnFoH4rlksCB4JZGpe9JR1pOInkUF5R+XbWM/l2NttN3iYSnCLljaGz?=
 =?us-ascii?Q?xCqWIaiCerCH6wD2e0e6dFWQCSvLNCurV1Os4cJBdg7HCZaP1fFb00CEnjEk?=
 =?us-ascii?Q?MjFMsD8KpjzlCUy9CfgzzU/SMPNThjhEyo+2EdePnDvUiaZkF7yWlD07Ky2j?=
 =?us-ascii?Q?5ucw6q/joJ2uUph8Mw9Bx/5oIcYq1JX9bq7lY926Ity2SQVGw9Ep7J30Klr5?=
 =?us-ascii?Q?38NS6i49WP53mDxWGFK6fAsAnc57BkPIvasXbdVHkhH02UQAhcwVwP0Wt/iW?=
 =?us-ascii?Q?59S4p1k/TyjbvmMyBb8RXcZuRyFzCN2/03Wbj9UU9YpwamYMIklwWG6gOorH?=
 =?us-ascii?Q?J1CaKqhzthiBUt2wD0FsRMl8b2BHw230GfoYQMeq0mpxRLGSe/YU0sLO+ZIH?=
 =?us-ascii?Q?Eyw4L/IaQAslUgA0OS8i+GjWvCW9autR6XR7dP19DI6Uay4c96KcvDF3+s4h?=
 =?us-ascii?Q?Bw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wNhnI/gzjrZH7desV5XjswISZx0HTwYy29BdgnS9AscKrbsGl/FLZnL5NhvfQugJUpVzbhP9q5M+CTMaQ2Ek8coen1HQ3FI9R0JSJsbB9uy/FVGslt3z7mMZawkMmoGMugCfqQcR4sJVIYI3i5jtGgtQQm4fQveWk7AFFJaZIf9Ywk/WCtH4paFDkX8k/HqcVo3W7BKd2/4fV9r8Tl9i4ONwegx8/u6fFFI7qt/Xel+kiTN8X9Tzg57b1g2t78a/xQjdr5Vl0VJeSx6aD88yLaRNj+iREedox//ibaONkOcsgSp26c4FCoqEMaUzlpZb76oFYqtTbPIi1V94PzQNdU6JtvazSMGkJ3KB7YyB3oNju+HFeparzSkDedpD8oCxZJvWAonb0LdvsiOisp5RyJMbqM6xf3E3/3mSzJyO7hJ0cm0LbTBc2JjWeS7ID5NroNWwRyuQz6y1zostfplOEMHlZpdZOa5vvv53npYCvdIW8EoeDYEjX0QYsbQ+1rRBvg6qWxmmSlmKVJuINO4VAsY7xp06DOJVu8p3SjbBgbDz10zQkmrJtj3mDYNTUN8Uxt9bXeSVIXYlkBUg2z0u5ImC8VGD/yWA47kL32ljmOuxh9FjPNqafuqfn1glL5en5CeHlVbyCn14aDuZAxuj6MgfM5ieB3Bu9Pozsaoayt4gxpm9sAr/DKCGGbcz4I2qeMO6Obiuxb/+3nbYer6OpDSGFHVMF+/ofPp30pBptwwo48bRIC32WT1nJBvyo92A0iddxybIdaqB/jjCri7pwClk2sc6gY+7B5PGm8yG4mL94LQVwAVi18aq1wC3lp4w9okPZJaQ3YC5nEFAh0Sj710cRpnVj8e8cEZvNGBUi/I=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45cf4a2e-e2f0-4e9c-8790-08dbe5e3603c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 14:01:33.8954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 26Jmw1vQLodTpLD5GmcigQVIDn7Y2AP8mzvJFSiAxiNJngmlzIlrSl6LF+WRtlZmQY9Rh+fYOSOPzlWu54tPZtFLR2IPhlMl5h34Cen/cjc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6009
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-15_13,2023-11-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 bulkscore=0
 phishscore=0 suspectscore=0 mlxlogscore=788 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311150108
X-Proofpoint-GUID: DEvaVzKHeRwXP3erq-fqfU16w98_GQLq
X-Proofpoint-ORIG-GUID: DEvaVzKHeRwXP3erq-fqfU16w98_GQLq
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 06:02:09 -0800 (PST)


Justin,

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering