Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
To:     Justin Stitt <justinstitt@google.com>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: csiostor: replace deprecated strncpy with strscpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq11qcr2jsx.fsf@ca-mkp.ca.oracle.com>
References: <20231023-strncpy-drivers-scsi-csiostor-csio_init-c-v1-1-5ea445b56864@google.com>
Date:   Wed, 15 Nov 2023 09:06:02 -0500
In-Reply-To: <20231023-strncpy-drivers-scsi-csiostor-csio_init-c-v1-1-5ea445b56864@google.com>
        (Justin Stitt's message of "Mon, 23 Oct 2023 20:26:13 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P1Tvjg0+qoD35mxXDbxZvbz0urRMwcVTdnGSazfy5sxMQyH1v14j8FEwg1Uz?=
 =?us-ascii?Q?Yh5lvVwKBGnnsJU8s9qjTud5GuU1tsHuuFK/+DtMx8DeNlKzt/WzHnEZYLgN?=
 =?us-ascii?Q?H6xp0asSympJ3WFBCutA6zkt5HdhEZdLUkSZAax4tUOL4gWUqUlfW47Ota9f?=
 =?us-ascii?Q?eeCZK1j2LqlsR8J6GGicsbJGBVVngt7OpNj2SjUAuN2CfugWVQUQYO4ITbgz?=
 =?us-ascii?Q?ihRsLAQRjMVcfmqjFpEtLa2koV0wl+sCOF7+duTPSvKLZIBHaDD3GHa1dI2T?=
 =?us-ascii?Q?sBhM69/xrnx4NzrH36Ogj2kEwjypCbnyg8z8VF9k0c9aiF0a+bW1FnUJKBRt?=
 =?us-ascii?Q?aN4q1vmUoBGSSY2MTo6YCgXftx0+7swiVodt50jsg5N2CTOo+meuInNwMgZN?=
 =?us-ascii?Q?0x1gbncNgd3qPkis4Oo5AKqrkCrmLutWj+oe3jvh3ZnzeuDiK/P8XycHaBLS?=
 =?us-ascii?Q?z1KOaSwa2B/ict48IY7N5lHUHqc/lStcLaQ0JH83/icvaOvOYUIiILdqQ65K?=
 =?us-ascii?Q?jFOEj+QhHqb1RMblCFDKPIk9uA2xX2WyL/Wq8lVLdb4+GQpDUcGG05Tij6AN?=
 =?us-ascii?Q?w+eZOOHuCiZcVpXmIZmASbvEGAOi5sm0/I0qVWJf/ZkEmMLh+AYUFVNnRPZv?=
 =?us-ascii?Q?jpEMG5XH//V9GUo6lAckd0qFQ2sRGbQ0Nrb7R59fQgw+8sv5OPpCU+9AjwW8?=
 =?us-ascii?Q?A6zlyEm4WD+qzBwQeTptVt1ZP9kNOJ1A+qLlSWWZUDnDzGrn8KMG33UcNf6L?=
 =?us-ascii?Q?lPAr+105R3VSrf3a5irD6xJwvN8sXHihy/rfmFS6Wwo456J+BGsvZxi5/D0l?=
 =?us-ascii?Q?HAxfIYahrAOOFhN0rFgOdGLluQYr2/kN/4Hi42NZQp1dNYYrUOdZGE2PrGJg?=
 =?us-ascii?Q?+L7J39V/gQSJibpBX74wynp0qcHyDxniJPZEvzgkKyJnLvp+celCLlKY0biZ?=
 =?us-ascii?Q?rd0dhJRhiRV8NmcI9Qf2eIWdwcyfKYbKc3iRmB9qj1jn3oumCz8RhWxHba7N?=
 =?us-ascii?Q?UKP9Q1g5uSUzN82hZvHQCuiq66ZIjuAhndSv8ofkXReM8vxwysAZK7LdHaTJ?=
 =?us-ascii?Q?roHM/eKZZuncfChome80rNMVqImTkQrOmOeKtlHxQK5phzr7TME1lA+UsFaP?=
 =?us-ascii?Q?CvkVZb6vFWNzQSi4lhtAOhthcy8rekFBI2bqRLiebqvKYy/kX/l6Ba9aUtyq?=
 =?us-ascii?Q?sTwny4hWs8STbAc+0C1jyLYQ0IJQhLbtiOzkq429DC1cTaejvJtxpNad43Fj?=
 =?us-ascii?Q?opA1EY8BRhvZOkH2RW4ydZwLjgqcuC/mFWoLcdATZgXyYKI1Ri7iYy4dAbDB?=
 =?us-ascii?Q?zuithhv0sDLzboeO0bES3hYq/5I8AZgfgPxGU6JxVI8S8sQncBQeuwbw1oln?=
 =?us-ascii?Q?qZz/Irip6UTe2fqh5k7hZG28xgJ6BiYhjW/wHXfxlXTTqQfheXoUyKPywqZ+?=
 =?us-ascii?Q?KYcXwJ8zQodNsdz7MZdYDCB+PfaT+5hBp7desGlOVRyTYMpIRUzjkOWTAH5r?=
 =?us-ascii?Q?8YsdblZ0rTwURjXtcWgvSVrLRDCbg1Mf/NWKi2vJkj9es1wZxx1IsDd+xXMP?=
 =?us-ascii?Q?7mYdAeZlT4qL7WC9u21J0uwYx6lXT+NUcwgHZd3ONiHpgQl1epkojkLLh9kD?=
 =?us-ascii?Q?nQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: twtit5xF6Zsxp9X6fn5Di5gOnGnidSfvIUKFnOPtI4H68uLBk/CRW2enMLd7WKLl7O6q7QX0Jf3SnMnCCX/jRJ9m5/OJVxl4iW5wGtl8DKXsbztydRrKFqVIC7Ti3qPBfw9rnK8rMDXA/8omz11arMphmzVuEviseZYDbiz6kTcKjkvJyVk280f+0j7+BvaVZf8xY3kggrxosOIghTz+DtfWYIPiD1OhEIrs6Y1K1hT1V3jfoavIlyQVWjpZCuohN53sWYVOCGaiTGM0vSiEtz/K1v1PtL6selg7BTVhm1aec1vz/uRA3LTUZPvEYKSQkyYT5ydrQjxJbjUpsjjzUU0kZ4fItz9TSeHt8kCF+FVKcnU7giI9irgyfCeDCUryL65cu4epl4PxwQNWaIePDLzbfIuUyA0DMk9H4jlqLqTeqOvtDaXlFezhLxrv7j/aWby+FDZOzmra38nqD0kgisJ9gC0BYDZTZokENuifoK61zLU05O4RA4ocbuVHDXBqgKjPaEcbF452NrBxOsU0we7CUv7qSMvK/9ZkvJ54NteNJgla9YxljhuhIbjnPS8QgQF6Q7jRlTUx/ZzXjP3vWlGHVmHk8S4tWZlqtfaC1Z3J+kFDqLag/EHOEVXGRxwMYPMvHhAGjsunq5SjzmyYDz4hyA31YzTROPB730ARAlAUZZCENDGlKyAWmjsFYR87w2JR2eYOJKQgXvxwKqWq+A646GHXjaCZC+0b7rwEDWzXL+Q7CebJfMA68r1D+oPgIeBY7SRpBusComKjYofmrYlCaKemedPKjFXNBXhYSJ439Gg6/l7KQZJ947n7YOAy/on7mEMyJ397Yv44oOQnig==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94221bf7-1bae-40d5-6473-08dbe5e40175
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 14:06:04.4152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pcjGQEZGd7L++2G0bx7U1Mfmf0r4Bfr/w+YELD4TeP62fcc2Q+vGL6wXB7H+xtdH2R699MTShmmpjsqfLLsxgb690Imc8TBZH3rv1YobGls=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5686
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-15_13,2023-11-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0
 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0
 mlxlogscore=819 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311150109
X-Proofpoint-GUID: nKjyd85Uh7VMQKtz22EramAHbCC3E2rY
X-Proofpoint-ORIG-GUID: nKjyd85Uh7VMQKtz22EramAHbCC3E2rY
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 15 Nov 2023 06:10:41 -0800 (PST)


Justin,

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering