Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2621075rdb; Wed, 15 Nov 2023 06:13:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlu8nxMw2epE1urQ6nObHH6valpJc9CZIw9E9iTUyHKirqD0mO752baG4j+5UT7+7gXF55 X-Received: by 2002:a17:902:f544:b0:1cc:43af:f568 with SMTP id h4-20020a170902f54400b001cc43aff568mr6681816plf.6.1700057597352; Wed, 15 Nov 2023 06:13:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700057597; cv=none; d=google.com; s=arc-20160816; b=GVn68VhCOKEoNlKHDUVDumyYkGgapffcrlJ9wyV9Jm91pJ61aZaeVjtVb8V6pN8yYs WWapExPKFN69fTRNYGGLfRRxV/mdTM7p5lZj7CDYimfLAswXX2rTOsfzFOs9gEe19SFw sGrfHhUlv27t8BrMK4GKL8xXTpH8+iW1Li8wuK1Cl1WLjWlR/Ef9ajGZUcgggT1ClhxB 15uWfLPmJBBWGN4Dbt6NkLAGHKN7cb6seNxilOLfdpvMNaSymqGRpwA/kms+EY9Sn4dq Ra7+Egv9UtFX8NS8OhvkxvpduXsqN/VW5TlA1YzjdZHCWKh6UbDvV/d+qYh8hqU7Arc0 6sRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=xLc1q6vrJcHClYyl9a3UjWTpX1GUb/pJJkLNG7JsImo=; fh=/w+QEyiXbxARZeQ1L3UkInVXTZTFhyRJsbjH2PrfVUo=; b=oaZrPSsHVPMVbzuMAX/UrxCrINIRQMm6OHldTBCCbe3i8AOWCGxnFHWM1mF+/AubjD PYmPwNGOM+tVD9UaTW0HwQb5NPAIAi+E21Rt1jxZuobgPD0AAGdesmMNFfnFdZzsMTGh ELUTKU9/M0+K1T6ty2tOFFVw3Ul4YCRZMy28xZ9pOw0Er1MgjfYc5xhaQ/3lI9nTFhuu o2D8NSskcVq8h2uog8603f5RIe4LIPdW4ptAzEuFEI1r1ghrYrU150PqJWv7KK4vGYgr doNT0lEGTHSX96OYeCCPK4ekXzaWaRqWhyJUR1rsZoRiMfn0WIj/6JtlPSPjOZ8rIGMp QMYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id l14-20020a170903120e00b001ca119ef46csi10456649plh.478.2023.11.15.06.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 06:13:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id B3E99802AFC2; Wed, 15 Nov 2023 06:13:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344133AbjKOONH convert rfc822-to-8bit (ORCPT + 99 others); Wed, 15 Nov 2023 09:13:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234172AbjKOONG (ORCPT ); Wed, 15 Nov 2023 09:13:06 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B1FDC5; Wed, 15 Nov 2023 06:13:00 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 725DF24DB83; Wed, 15 Nov 2023 22:12:51 +0800 (CST) Received: from EXMBX161.cuchost.com (172.16.6.71) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Nov 2023 22:12:51 +0800 Received: from [192.168.1.115] (180.164.60.184) by EXMBX161.cuchost.com (172.16.6.71) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 15 Nov 2023 22:12:50 +0800 Message-ID: Date: Wed, 15 Nov 2023 22:12:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] drm/fourcc: Add drm/vs tiled modifiers Content-Language: en-US To: Simon Ser CC: "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-media@vger.kernel.org" , "linaro-mm-sig@lists.linaro.org" , "Krzysztof Kozlowski" , Sumit Semwal , Emil Renner Berthing , "Shengyang Chen" , Conor Dooley , Albert Ou , Thomas Zimmermann , Maxime Ripard , Jagan Teki , "Rob Herring" , Chris Morgan , "Paul Walmsley" , Bjorn Andersson , Changhuang Liang , Jack Zhu , Palmer Dabbelt , Shawn Guo , "christian.koenig@amd.com" References: <20231025103957.3776-1-keith.zhao@starfivetech.com> <20231025103957.3776-4-keith.zhao@starfivetech.com> <2wq8ssA4KblYH5JfC8KxeWWoYPleN_BcH6wSZ92tkOixbiU5k2ZU_lS4lO0awCCeomkdjsEoVlUmAH7aaaR2n-bdLKu1AaSar_JW78Kw4Ik=@emersion.fr> From: Keith Zhao In-Reply-To: <2wq8ssA4KblYH5JfC8KxeWWoYPleN_BcH6wSZ92tkOixbiU5k2ZU_lS4lO0awCCeomkdjsEoVlUmAH7aaaR2n-bdLKu1AaSar_JW78Kw4Ik=@emersion.fr> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX161.cuchost.com (172.16.6.71) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 15 Nov 2023 06:13:14 -0800 (PST) ok， I will do this in my next patch Thanks your advice! On 2023/10/25 23:44, Simon Ser wrote: > it seems like you could start with just simple > enumerated modifiers like Intel does, and then only switch to more > complicated logic with macros and fields if there is an actual need in > the future.