Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
To:     Justin Stitt <justinstitt@google.com>
Cc:     James Smart <james.smart@broadcom.com>,
        Ram Vegesna <ram.vegesna@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] scsi: elx: libefc: replace deprecated strncpy with
 strscpy_pad/memcpy
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1ttpn13d7.fsf@ca-mkp.ca.oracle.com>
References: <20231026-strncpy-drivers-scsi-elx-libefc-efc_node-h-v2-1-5c083d0c13f4@google.com>
Date:   Wed, 15 Nov 2023 09:46:19 -0500
In-Reply-To: <20231026-strncpy-drivers-scsi-elx-libefc-efc_node-h-v2-1-5c083d0c13f4@google.com>
        (Justin Stitt's message of "Thu, 26 Oct 2023 01:53:13 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PyZXCHKZpvzV43NiUdXLsnScOWJMtXfeZt+vrWmqysOpz39poz3fCnsCusTZ?=
 =?us-ascii?Q?WcKycAR2TW4gaAyZIdgQ8dh8OH/Iofc2RR/Ut51wUoa1r2OhjqTSfxcPTHvP?=
 =?us-ascii?Q?y1MY9L/hnjVejQ7j2unEIJOX+y+TuPgQC+XPCSqTS0DAeVlO4rVP8R9Ey7ud?=
 =?us-ascii?Q?1sRRMb8N1j4F0EOKTNR4Jn3siEFAJ5hSX3A9YJ3iZO8l9j9HwEzsoCl5dJk9?=
 =?us-ascii?Q?sUyBEWMt0y/9G6DL9QT9C5gmNR8fJkWUadaDjhUvFmdN3u2ANxLO/NlAY5uM?=
 =?us-ascii?Q?Ysd8aYuU8ZaqNKqHsUIDBI13BGBAqAuTMp9MWOoDN+Y0ABLy+xkb/eT57MEi?=
 =?us-ascii?Q?eoXIKa8axzM3JddvVwZ8DXmuRJPHxhT7Pw66JkUOMih2VSE2RsNYsELvfVXK?=
 =?us-ascii?Q?0LYXQA0O6MV3wVsGCBagqnEGB3Owch7d5RN9SqCFvKMEq9nXwTWuvash+O9h?=
 =?us-ascii?Q?nCM/9f2ApbteSnTHOl66g0rxfBHwYoSB1KBRP4mTr/JPfTxslmztS+uNmuP/?=
 =?us-ascii?Q?nrrVoMnt0TQX2Z4y4wMeHoZOvklsjYcdLfZGeTZBrlq99hL9iDJFsFO4PVXq?=
 =?us-ascii?Q?5bGuNSMI0308SfGIM9KEaF3kF+tod0xfziotRc4GzM0mUgbKcXYo6ycO0iXf?=
 =?us-ascii?Q?vZln+L6NHuZjReuX2ljOKZ4Vy71/Vvmcz0uhF1aqm09jvNfbHI4XT3TrO23Y?=
 =?us-ascii?Q?YUyCtzw0TS7gWdwNKsS2FySqclcIWqtzRdjOFDDQORhsqqAuyzq/nxU9aOYV?=
 =?us-ascii?Q?KGlwOIIdEK88NzQmaZExkeCDc11REhNPcaILOAmf3L/hTwQGqDUFD/GcSvse?=
 =?us-ascii?Q?Ecs2LiLN08A3a4ojGgtt9yPxuEfGW/SOKNEsTqc3eBLc/omvB2bqKfyVhpky?=
 =?us-ascii?Q?zTIsgjtZV3/pMB5tKeZNfTQaQSmqVP3KsIOMuiX8h9j6iJ4a2EiOTJfCRcqj?=
 =?us-ascii?Q?COv913bWY12xYAudbG0AqD79jZg3tRioplSG/vtAIG+Y5+zBf4EYcEdYoUdY?=
 =?us-ascii?Q?YQeVZnXiU3jvSlx6RdBxH9DSHnniFbflOnZ8lDJ2XPHf8bVxjEkl+GJgphv7?=
 =?us-ascii?Q?mGAEIKmJNCHsGSbzTDe2UWfWitsQxwWAHhiZ963URrTGOdCRkjg5wAZvdGSw?=
 =?us-ascii?Q?ZjtEm5VQqdEcYQQGRUTQ5a9IduUaYybmvcmV+ZA3FLZj09YISs8gdEfYXXSg?=
 =?us-ascii?Q?cg9Z8GFs+L2jrjZGOrEcqimbSHbptuPmok/NZFyNjXD10R4J77Jr/epIuurH?=
 =?us-ascii?Q?g0oVvNDB7/ol1pMfITt3ws5aahEzBHIyjvc+g4HeJRdROMEcAUybDSwNZzDr?=
 =?us-ascii?Q?KrLHUWcV4FpFBuMWaqpw+xcbCUG+SO3vGWZJju0u35JMb3LvUuIfJEtZjqnU?=
 =?us-ascii?Q?9Yk6Nio8kDdtTmKm4zU91y9cafi1Gpl0VIKKv6Si6NS1UebRhlcGyrXasKWf?=
 =?us-ascii?Q?Wrxhq2v3osOgbKF3EdlVNNGodbCtqBOz63jXKJswRnCD7CnaFrFgIhKHiMf1?=
 =?us-ascii?Q?4DpCq60MLK3///gk+SyxnP67W//H9Qs1xDFzFdZxVBXPfg801oHWhFbgAcb7?=
 =?us-ascii?Q?v2VYZbRkIZ2wr9VXxazKhTjUPhFzb9N1WrwKWlYjIAoCoo7Yvm226XT+rB0B?=
 =?us-ascii?Q?jw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: FSYM483te65+8R1qUq3aN9jg7lcgXsqhqY9ks77tCk6xMX4QHeTT9sQ1E/o3Qi+TM5cAL4alePpidXtv8feSVW7DOPnKw/nKKmnqZJ/rmEhlICvuaYmLS5eyd05IadzOWy286Wxj3was/v7Twgg2t9AzLx50ZM2kejAaAF80SELOIH0T47BgX2muben2WzSRn/0PtqCf71VG2KqPrzmDv0My5+xT3n4os3J4d2b18s/JQtUKhYM+h6wgwaN/xtt6JaCXV93euaSuQG+MuZuHQ8dP21iBnlGKo1K1DoEtufy6febVQvlc2BZT3SrK51S/+3TUXgBVUC1YK6oqBpTs24ME+JQe1QrXwwa8wj3EVDdWAQPUbrBFdED/GVBcBhf1sUz7DoIq+RWOzhmorL5IQt6ykD1HxC1wOVus1tuxqo70tEUYMAYSug5O5skS4F8Kq8ASziA/3p8kS9G/StNpgTDclwa6lOa76HAcdS6/xDkrhR2pZJAb1M1mKSAMKY8Ror715+YivSGXpSZxMrAXoqt81bjJOx3cIaiE9fsgUwRrVSDvyqiE7R0WuqQACh12MnZXcPo79tW4+1FodLc+9jPxuu17op1UyAro4vrVBNFKmhRPud888GCM9jxVEUETuMZcVDLqwkRu+7HvYo+frTBWJuFl854a/rXIFvyozYl9e4mrAU+Rt4gc13M+0RDJR7EFnjZubZ/g81wpLnyu7vjxB0oA2uLOMTZT916MqBVZCGfRE8UQ+WAnFXYy2WG+te56AE8hwY6Mcrk40cEya4UEU35IkZxyWRVVwb+sbMzh/F19flITqqUylCt3WjEMqffSjd0sJ6Kr/5K4WeR5RqaXJu+uaJvK7hYKVP8Luoo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29b25f75-15f2-48dd-dbd8-08dbe5e9a238
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 14:46:21.6056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J+4n9uciMdiYltQ2WGpsjgG9i4MKN8KCmHBO78H8I4rvUkj+inZpjxRPH7jAGddrwhXtxUU8+siaulSUCjgIUvdAqlcC9VdxM8IsErw21DQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5044
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-15_13,2023-11-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 phishscore=0 mlxlogscore=828 adultscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311150113
X-Proofpoint-GUID: Vujte0PedN_CjP3mGwTkI8ZrlG5WDkga
X-Proofpoint-ORIG-GUID: Vujte0PedN_CjP3mGwTkI8ZrlG5WDkga
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 06:46:47 -0800 (PST)


Justin,

> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering