Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <409a4eaf-3d2b-4de6-a0f0-245cc1523bee@web.de>
Date:   Wed, 15 Nov 2023 16:02:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From:   Heiner Kallweit <heiner.kallweit@web.de>
Subject: Re: [PATCH net-next v11 10/13] net:ethernet:realtek:rtase: Implement
 ethtool function
To:     Justin Lai <justinlai0215@realtek.com>, kuba@kernel.org
Cc:     davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        andrew@lunn.ch, pkshih@realtek.com, larry.chiu@realtek.com
References: <20231115133414.1221480-1-justinlai0215@realtek.com>
 <20231115133414.1221480-11-justinlai0215@realtek.com>
Content-Language: en-US
In-Reply-To: <20231115133414.1221480-11-justinlai0215@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:9VpxuuT1nF4=;RKK+gL/I9ZYH5xWD1spAueBHQRp
 /pgJSXEucJAIYr2gJPWnaBSAkgcdpBbniPFOsuE4lN80yxaB346vs8jsKc+WXDj6uFrzA+9uQ
 GGYh2Wk8pX+h0yC30pX5eosArPXTu2UaKxbF9vDd/WOy09w+nNHm8Y1qjbTRmTXBNB/12Mtw8
 Fp0beu21cb5gTU5zf+eFWGW/YCB0DKy3sjXBpPs85dZwNoJARBUldkYUC9inDSUOQ43GYdiQm
 AAmbPfeX7uWRWOFARHhqzgla+eilyN6FNJNutFEp7tk0LpxiiYjdrpwxAV7u8GaOccL3LbJP6
 Vw7BVLH28IF7KHdkRExDNktKMDkYM5efA67RZbTK8+BrbYs21vV1Uj/XqZCWwuvomeNfdPxQa
 F86Dbon2wx0N5iDSPSJg1wDzlsfFC90mR2XLa5RK/3T2+DiqNIyTPlOiRO/inUKfge89VkYZ/
 /A/o9555bAOqlUQ3i31fttc6cER6cpeO0sDzmzNj0ZcTUio2PMcB5ALUE7wYButSlilS1NisL
 viEolowPdyCP/H918svxnxjLViWjIKGOf4WoEDaP6fBgBdkLCHAzeIAzaAZueskM1ey+1ELAT
 4u1Ki1vJQSVd7fn28QQeoDO3PcaJN54bp4MgA12OArnKT/oL0bwkqoIITl/jqr6nDnacKTvw0
 MyqLCyrXPDwXpl/gh7Y0SYpcYihgio5YTxzrX0dOYPOxok2NXUMf4JFqBC/zXjsbkUMRYogrd
 wAVPAZ/O7TG6W+BefGuYgVDTMKGEv3706jxep2uYoGnKBhm+UVxugiWKquvHiUQhBzH6nlbzv
 Wp
Precedence: bulk

On 15.11.2023 14:34, Justin Lai wrote:
> Implement the ethtool function to support users to obtain network card
> information, including obtaining various device settings, Report whether
> physical link is up, Report pause parameters, Set pause parameters,
> Return a set of strings that describe the requested objects, Get number
> of strings that @get_strings will write, Return extended statistics
> about the device.
>
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
>  .../net/ethernet/realtek/rtase/rtase_main.c   | 144 ++++++++++++++++++
>  1 file changed, 144 insertions(+)
>
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/n=
et/ethernet/realtek/rtase/rtase_main.c
> index b7679b74cc8a..5ea4d51fcc47 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -1900,9 +1900,153 @@ static void rtase_get_mac_address(struct net_dev=
ice *dev)
>  	ether_addr_copy(dev->perm_addr, dev->dev_addr);
>  }
>
> +static void rtase_get_drvinfo(struct net_device *dev,
> +			      struct ethtool_drvinfo *drvinfo)
> +{
> +	const struct rtase_private *tp =3D netdev_priv(dev);
> +
> +	strscpy(drvinfo->driver, KBUILD_MODNAME, 32);
> +	strscpy(drvinfo->bus_info, pci_name(tp->pdev), 32);
> +}
> +
> +static int rtase_get_settings(struct net_device *dev,
> +			      struct ethtool_link_ksettings *cmd)
> +{
> +	u32 supported =3D SUPPORTED_MII | SUPPORTED_Pause | SUPPORTED_Asym_Pau=
se;
> +
> +	ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
> +						supported);
> +	cmd->base.speed =3D SPEED_5000;
> +	cmd->base.duplex =3D DUPLEX_FULL;
> +	cmd->base.port =3D PORT_MII;
> +	cmd->base.autoneg =3D AUTONEG_DISABLE;
> +
What are you reporting here? Does this refer to the link between MAC and
switch CPU port? Because I would assume that the switch ports can do auton=
eg.

> +	return 0;
> +}
> +
> +static void rtase_get_pauseparam(struct net_device *dev,
> +				 struct ethtool_pauseparam *pause)
> +{
> +	const struct rtase_private *tp =3D netdev_priv(dev);
> +	u16 value =3D rtase_r16(tp, RTASE_CPLUS_CMD);
> +
> +	pause->autoneg =3D AUTONEG_DISABLE;
> +
> +	if ((value & (FORCE_TXFLOW_EN | FORCE_RXFLOW_EN)) =3D=3D
> +	    (FORCE_TXFLOW_EN | FORCE_RXFLOW_EN)) {
> +		pause->rx_pause =3D 1;
> +		pause->tx_pause =3D 1;
> +	} else if ((value & FORCE_TXFLOW_EN)) {
> +		pause->tx_pause =3D 1;
> +	} else if ((value & FORCE_RXFLOW_EN)) {
> +		pause->rx_pause =3D 1;
> +	}
> +}
> +
> +static int rtase_set_pauseparam(struct net_device *dev,
> +				struct ethtool_pauseparam *pause)
> +{
> +	const struct rtase_private *tp =3D netdev_priv(dev);
> +	u16 value =3D rtase_r16(tp, RTASE_CPLUS_CMD);
> +
> +	if (pause->autoneg)
> +		return -EOPNOTSUPP;
> +
> +	value &=3D ~(FORCE_TXFLOW_EN | FORCE_RXFLOW_EN);
> +
> +	if (pause->tx_pause)
> +		value |=3D FORCE_TXFLOW_EN;
> +
> +	if (pause->rx_pause)
> +		value |=3D FORCE_RXFLOW_EN;
> +
> +	rtase_w16(tp, RTASE_CPLUS_CMD, value);
> +	return 0;
> +}
> +
> +static const char rtase_gstrings[][ETH_GSTRING_LEN] =3D {
> +	"tx_packets",
> +	"rx_packets",
> +	"tx_errors",
> +	"rx_errors",
> +	"rx_missed",
> +	"align_errors",
> +	"tx_single_collisions",
> +	"tx_multi_collisions",
> +	"unicast",
> +	"broadcast",
> +	"multicast",
> +	"tx_aborted",
> +	"tx_underrun",
> +};
> +
> +static void rtase_get_strings(struct net_device *dev, u32 stringset, u8=
 *data)
> +{
> +	switch (stringset) {
> +	case ETH_SS_STATS:
> +		memcpy(data, *rtase_gstrings, sizeof(rtase_gstrings));
> +		break;
> +	}
> +}
> +
> +static int rtase_get_sset_count(struct net_device *dev, int sset)
> +{
> +	int ret =3D -EOPNOTSUPP;
> +
> +	switch (sset) {
> +	case ETH_SS_STATS:
> +		ret =3D ARRAY_SIZE(rtase_gstrings);
> +		break;
> +	}
> +
> +	return ret;
> +}
> +
> +static void rtase_get_ethtool_stats(struct net_device *dev,
> +				    struct ethtool_stats *stats, u64 *data)
> +{
> +	struct rtase_private *tp =3D netdev_priv(dev);
> +	const struct rtase_counters *counters;
> +
> +	ASSERT_RTNL();
> +
> +	counters =3D tp->tally_vaddr;
> +	if (!counters)
> +		return;
> +
> +	rtase_dump_tally_counter(tp);
> +
> +	data[0] =3D le64_to_cpu(counters->tx_packets);
> +	data[1] =3D le64_to_cpu(counters->rx_packets);
> +	data[2] =3D le64_to_cpu(counters->tx_errors);
> +	data[3] =3D le32_to_cpu(counters->rx_errors);
> +	data[4] =3D le16_to_cpu(counters->rx_missed);
> +	data[5] =3D le16_to_cpu(counters->align_errors);
> +	data[6] =3D le32_to_cpu(counters->tx_one_collision);
> +	data[7] =3D le32_to_cpu(counters->tx_multi_collision);
> +	data[8] =3D le64_to_cpu(counters->rx_unicast);
> +	data[9] =3D le64_to_cpu(counters->rx_broadcast);
> +	data[10] =3D le32_to_cpu(counters->rx_multicast);
> +	data[11] =3D le16_to_cpu(counters->tx_aborted);
> +	data[12] =3D le16_to_cpu(counters->tx_underun);
> +}
> +
> +static const struct ethtool_ops rtase_ethtool_ops =3D {
> +	.get_drvinfo =3D rtase_get_drvinfo,
> +	.get_link =3D ethtool_op_get_link,
> +	.get_link_ksettings =3D rtase_get_settings,
> +	.get_pauseparam =3D rtase_get_pauseparam,
> +	.set_pauseparam =3D rtase_set_pauseparam,
> +	.get_strings =3D rtase_get_strings,
> +	.get_sset_count =3D rtase_get_sset_count,
> +	.get_ethtool_stats =3D rtase_get_ethtool_stats,
> +	.get_ts_info =3D ethtool_op_get_ts_info,
> +};
> +
>  static void rtase_init_netdev_ops(struct net_device *dev)
>  {
>  	dev->netdev_ops =3D &rtase_netdev_ops;
> +	dev->ethtool_ops =3D &rtase_ethtool_ops;
>  }
>
>  static void rtase_reset_interrupt(struct pci_dev *pdev,