Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2667936rdb; Wed, 15 Nov 2023 07:23:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjAZhxx1GZS7lcZBOrdtC7//n14DFqCfhc+eHlysSBZA8S3h5uWwjTNXVbHnXZqUUJyn8L X-Received: by 2002:a05:6e02:1906:b0:359:64af:c6e1 with SMTP id w6-20020a056e02190600b0035964afc6e1mr18897524ilu.9.1700061791104; Wed, 15 Nov 2023 07:23:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700061791; cv=none; d=google.com; s=arc-20160816; b=K6zssDTpqq+Bhkj8K3ha75crb9y5IeIVw0IoUb6N+FWb2ITP6KgfPQxlyVLcDbAdPH YJzWLEO0JSPPLcvPN934bEzRDE9MOo8S4XeJIPHSJB2H1CnbBjLbDHkbD/U5UqrABl/Z CpWAP1YG//8+DTdQRqEGCIsjqwKcRPa10CraKoDTGatSWMPNzJCMA13Q2KDQQutqtBCo gEV14jv9P51y+n0vem7Mlm0n3M1olbNnMK5wHQ8IP/eTxS4CLTqoVpCC2NzV2pZiAENL dzersVQKKhFSUFahhM39rA4G14ES3cwfEkvFkBhyX7za6TAAp8MTj+y/i6LdwWItqs++ u2iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TBboNrrgtc1Ufhy56vcbQiFnV2zERUJkozPYTQzsRA4=; fh=4gpfRGcGnp+CfSXRmR6id0uiB/MqlRnmFc1qe8IoiFE=; b=HC5ZXr8+WDMxuv4PWwATCsivYPfS6MhjoKZlZ2Fy9golDLFqDTpZ9UFtkqjZreNPFE 8Wnpwu6qvXsK8Gd34qwvBo5Qc7IWBVCkC33U0c1EkeQwqImAmJySyZJUBtiuEVehAmN3 Olvcyzd557uXBNkKrCWFWRnb9tycSgtCn1LqP+IIsMU1pxQumGoKM82Fi8ZAXQMRktKV T99NA5ZCUNHjgqUwwlzddgxHYNcN56KrH+3/3o+swXadCIJ0AhQ2LMcwQGKQz3cO86MS NzWCzc+RnUwXkHSGyz5jM2aJDwq77gq/CD07PTIKRpDjfIZ6ldDnc4nPFxUji77Uzi/t 0DzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=e89ZOdLX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id h64-20020a638343000000b005c1cea5b024si1515057pge.96.2023.11.15.07.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 07:23:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=e89ZOdLX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B8AB080226A6; Wed, 15 Nov 2023 07:23:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344453AbjKOPW7 (ORCPT + 99 others); Wed, 15 Nov 2023 10:22:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344389AbjKOPW5 (ORCPT ); Wed, 15 Nov 2023 10:22:57 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90FA9C; Wed, 15 Nov 2023 07:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=TBboNrrgtc1Ufhy56vcbQiFnV2zERUJkozPYTQzsRA4=; b=e89ZOdLX1ofI6or6vMsGbgt49R fyk1CJPKrmYk9rG9ViSIpAybtGwRfW2JWcKkuEg/ob/2UpZCHRl8nIrDE1CBBy108EMylj5+e4Pk6 0D6rDqHzJ6FoHXxV+jhaGFdGuF6KLjgilmFbXynSC96oeW769b5RXSbcT3CWF14uogNU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r3Hj4-000FqQ-7Z; Wed, 15 Nov 2023 16:22:46 +0100 Date: Wed, 15 Nov 2023 16:22:46 +0100 From: Andrew Lunn To: Luo Jie Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, robert.marko@sartura.hr, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_srichara@quicinc.com Subject: Re: [PATCH 5/9] net: mdio: ipq4019: support MDIO clock frequency divider Message-ID: <3471f665-f935-4091-b870-a42cf2b1eb96@lunn.ch> References: <20231115032515.4249-1-quic_luoj@quicinc.com> <20231115032515.4249-6-quic_luoj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231115032515.4249-6-quic_luoj@quicinc.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 15 Nov 2023 07:23:07 -0800 (PST) > + /* MDIO default frequency is 6.25MHz */ > + priv->clk_div = 0xf; 802.3 says MDC should be 2.5Mhz. Its O.K. to support faster clocks, but it should be an optional DT property, clock-frequency as described in the binding. Andrew