Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2677642rdb; Wed, 15 Nov 2023 07:38:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4HQ2JaF89wSadXwhv9ZReeIwvTmqZmwsejitNhjKgyfcPhNXpoRlpEC38tarPvfcmJCZA X-Received: by 2002:a17:902:e543:b0:1cc:68c4:8c60 with SMTP id n3-20020a170902e54300b001cc68c48c60mr6856704plf.18.1700062690202; Wed, 15 Nov 2023 07:38:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700062690; cv=none; d=google.com; s=arc-20160816; b=zBZAMQouCJYNxDBSL5W7rUcaSp/tuKoyLW8uuxDAQLeTBK7DjPMR1R0r/Dj0fT7XSs zFRcPzj/7WIiGHgTEL7wkqqp+X2DOLns4qB5becdhHV7kf6Rl+1DoB/eR3g/g4re7CBI OA2STdyPbSmDN5xAVukeY07q2bnaax7MLcBS9FM59bcmfqqZyq5rFkvOt2gqSlTwLmYR VrJ3BLOg9jqwH9hS868eJ8PbbEK2CylNyEdyAxSdQZQLIjuAOZYNdnktG0mYBUTBebCR OD0+V4mkajkI4tXVwOK5ZWKmcvqxSWXfIHUShUxglrcQtzj/hcOkHHdkfooPpT5WPdxm 6A7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8ROXlSm1wU1yGBqDzDsCNJmT/UfRVLfyO8qv8goHtwQ=; fh=t0aglCmhrzjEKX4OFt+7oWilXMtklnnLYv0+hq0HyeU=; b=Qi/AdPzjpbVVjV3Y1YJK7hn+r1U4Mw74uWhPPVEKEH6xpKAhav9C4DafD6QMWO3icF VctygKFzdO1bxj3FHGTylqwQvVqi6GjrQE9efsg17dZGoe4cbJ4PjVETOsSOHFKIAL5F PCPivUV2sp+CCQbfxY7MaJpx/Fwgbg1AH/VETqlO/YzQcj2i8H9qCdypJ9ZqgbqKTlk0 62Zt7QMamrPWMxa/t6uT6INX7ISXIOaS0tGrYUQkRDfEaJYfGDUEYuUnrFsXEKbG0Cpj nk9xGFH/NsME/1zO4h6rh/jQ+VLZ1TDAmqYbOXoW19FNHeQLCh7v5Sc5/Gi2NNKJwgVO YnAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q2sgtua+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id y5-20020a17090322c500b001c9e75f87edsi10711341plg.152.2023.11.15.07.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 07:38:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q2sgtua+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 06109802318A; Wed, 15 Nov 2023 07:37:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbjKOPhq (ORCPT + 99 others); Wed, 15 Nov 2023 10:37:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbjKOPhp (ORCPT ); Wed, 15 Nov 2023 10:37:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A42C109 for ; Wed, 15 Nov 2023 07:37:42 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E639AC433C7; Wed, 15 Nov 2023 15:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700062661; bh=AiZnGVVWhHwGhN3Vdq+4LuWAKRDxyRiM/b2iR4+LgQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q2sgtua+jAxLQDlhigNd9qWhuSQcpDU43jP4CcDB1Xq71GjNQ391gHqlV7j3GScYt dilsn+4LNuLQI9oRCQNTjdELOSVjJEvRuZJ28YjPiYD/4NHQu9W9JOkvGWuiwIrG+a fARoieQBeBRx5/8jaxVNNPrrROlUd3ISEO4fF+zudf14d7n/EhajnTUDZyk+OfUGDH dfAPo+XpSpI77TUtfZRL2KPFQ61w7rI2gBJH0rdGBKuV72qhXkEUDRRG3GlmulR3VV lan9guIC+RXV8vacMWIbidYJUEtOMdiptsr2XYHdJWYvn66/5YG/9OvsdAw619Jwg6 9Mbw0XWrJwHcw== Date: Wed, 15 Nov 2023 23:25:18 +0800 From: Jisheng Zhang To: Drew Fustini Cc: Conor Dooley , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Fu Wei , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v6 5/7] riscv: dts: thead: Add TH1520 mmc controllers and sdhci clock Message-ID: References: <20231114-th1520-mmc-v6-0-3273c661a571@baylibre.com> <20231114-th1520-mmc-v6-5-3273c661a571@baylibre.com> <20231114-starring-swarm-0e1b641f888c@squawk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 15 Nov 2023 07:37:58 -0800 (PST) On Wed, Nov 15, 2023 at 11:22:03PM +0800, Jisheng Zhang wrote: > On Tue, Nov 14, 2023 at 05:30:26PM -0500, Drew Fustini wrote: > > On Tue, Nov 14, 2023 at 09:27:44PM +0000, Conor Dooley wrote: > > > On Tue, Nov 14, 2023 at 04:07:59PM -0500, Drew Fustini wrote: > > > > > > > + sdhci_clk: sdhci-clock { > > > > + compatible = "fixed-clock"; > > > > + clock-frequency = <198000000>; > > > > + clock-output-names = "sdhci_clk"; > > > > + #clock-cells = <0>; > > > > + }; > > > > > > If only you had a clock driver to provide these... > > > > > > Is someone working on a resubmission of the clock driver? > > > > Yangtao Li posted an initial revision back [1] in May but I don't think > > there has been any follow up. It is for sure something we need to have > > in mainline so I'll take a look at getting that effort going again. > > Hi Drew, > > Based on Yangtao's version, I cooked an updated version in last > development window but still can't complete it and met some issues > which need the clk/pll register document. > IIRC, the document was released a few days ago before soc tree frozen. > > It's nice if you can continue the effort! I'll read the sdhci driver > soon. PS: I can send my updated version to you for reference tomorrow. > > Thanks > > > > Drew > > > > [1] https://lore.kernel.org/linux-riscv/20230515054402.27633-1-frank.li@vivo.com/