Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <4e0c8bb796a67af5fb901f831c5f87fe.mripard@kernel.org>
Date:   Wed, 15 Nov 2023 15:51:52 +0000
From:   "Maxime Ripard" <mripard@kernel.org>
To:     "David Gow" <davidgow@google.com>
Subject: Re: [PATCH 1/3] kunit: Add a macro to wrap a deferred action
 function
In-Reply-To: <20231110200830.1832556-1-davidgow@google.com>
References: <20231110200830.1832556-1-davidgow@google.com>
Cc:     dlatypov@google.com, dri-devel@lists.freedesktop.org,
        kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        llvm@lists.linux.dev, "Arthur Grillo" <arthurgrillo@riseup.net>,
        "Benjamin Berg" <benjamin.berg@intel.com>,
        "Brendan Higgins" <brendan.higgins@linux.dev>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        "David Airlie" <airlied@gmail.com>,
        "Emma Anholt" <emma@anholt.net>,
        "Kees Cook" <keescook@chromium.org>,
        "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
        "Maxime Ripard" <mripard@kernel.org>,
        =?utf-8?b?TWHDrXJhIENhbmFs?= <mairacanal@riseup.net>,
        "Nathan Chancellor" <nathan@kernel.org>,
        "Rae Moar" <rmoar@google.com>,
        "Richard Fitzgerald" <rf@opensource.cirrus.com>,
        "Sami Tolvanen" <samitolvanen@google.com>,
        "Shuah Khan" <skhan@linuxfoundation.org>,
        "Thomas Zimmermann" <tzimmermann@suse.de>
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 11 Nov 2023 04:08:26 +0800, David Gow wrote:
> KUnit's deferred action API accepts a void(*)(void *) function pointer
> which is called when the test is exited. However, we very frequently
> want to use existing functions which accept a single pointer, but which
> may not be of type void*. While this is probably dodgy enough to be on
> the wrong side of the C standard, it's been often used for similar
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime