Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231114102321.1147951-1-sai.krishna.potthuri@amd.com>
In-Reply-To: <20231114102321.1147951-1-sai.krishna.potthuri@amd.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Wed, 15 Nov 2023 16:51:37 +0100
Message-ID: <CAPDyKFpVwKK=fj5c5xTCkVKk3WgpH89ZP1OSdUK72XEXGbkYuA@mail.gmail.com>
Subject: Re: [PATCH v2] dt-bindings: mmc: arasan,sdci: Add gate property for
 Xilinx platforms
To:     Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, git@amd.com, saikrishna12468@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 14 Nov 2023 at 11:23, Sai Krishna Potthuri
<sai.krishna.potthuri@amd.com> wrote:
>
> From: Swati Agarwal <swati.agarwal@amd.com>
>
> Add gate property in example node for Xilinx platforms which will be used
> to ungate the DLL clock. DLL clock is required for higher frequencies like
> 50MHz, 100MHz and 200MHz.
> DLL clock is automatically selected by the SD controller when the SD
> output clock frequency is more than 25 MHz.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@amd.com>
> Co-developed-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Note: This patch only updates the example nodes with the gate property for
> Xilinx platforms.
>
> Changes in v2:
> - Updated subject prefix to match with the subsystem.
>
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 3e99801f77d2..9075add020bf 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -226,8 +226,8 @@ examples:
>            interrupt-parent = <&gic>;
>            interrupts = <0 48 4>;
>            reg = <0xff160000 0x1000>;
> -          clocks = <&clk200>, <&clk200>;
> -          clock-names = "clk_xin", "clk_ahb";
> +          clocks = <&clk200>, <&clk200>, <&clk1200>;
> +          clock-names = "clk_xin", "clk_ahb", "gate";
>            clock-output-names = "clk_out_sd0", "clk_in_sd0";
>            #clock-cells = <1>;
>            clk-phase-sd-hs = <63>, <72>;
> @@ -239,8 +239,8 @@ examples:
>            interrupt-parent = <&gic>;
>            interrupts = <0 126 4>;
>            reg = <0xf1040000 0x10000>;
> -          clocks = <&clk200>, <&clk200>;
> -          clock-names = "clk_xin", "clk_ahb";
> +          clocks = <&clk200>, <&clk200>, <&clk1200>;
> +          clock-names = "clk_xin", "clk_ahb", "gate";
>            clock-output-names = "clk_out_sd0", "clk_in_sd0";
>            #clock-cells = <1>;
>            clk-phase-sd-hs = <132>, <60>;
> --
> 2.25.1
>