Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <b6a6409e-5f13-4f7e-835a-c9e3653a7ad5@intel.com>
Date:   Wed, 15 Nov 2023 08:09:13 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] x86/resctrl: mba_MBps: Fall back to total b/w if local
 b/w unavailable
To:     "Luck, Tony" <tony.luck@intel.com>
CC:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20231025235046.12940-1-tony.luck@intel.com>
 <20231026200214.16017-1-tony.luck@intel.com>
 <0cee68e9-e188-46e9-83a8-02259a9c081f@intel.com>
 <ZUqo+MsEQi2Xc/pO@agluck-desk3>
 <1a198614-d79e-44c0-b4d4-0e1e0d0c04de@intel.com>
 <SJ1PR11MB6083F3355446B7879177A1FBFCAFA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB6083F3355446B7879177A1FBFCAFA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dW43bmFsRFFTWWFzcitUa3owUXQxd2RzN1hzbDFzazZxU2NHZ1dtZy9EdWQw?=
 =?utf-8?B?b3QydUFWR21Oelk2MVlQSW5QZ2hnQ1YyelM1bTAzZ0xOU3pyMUxHbVF3bGoz?=
 =?utf-8?B?TjBOY3FSZ05wTGZ6akpvL0ZmdjhySk5vMXdnaTVSQ1Baemd5UEU1MnExL28y?=
 =?utf-8?B?bEZMeFRac2VqbmMwV01YM2NweFQvY2xNb1JVRVFxdUZiUno3WWpURUFVdkVQ?=
 =?utf-8?B?U21SdGdqcGxMSFpQTVhncjY0eGQ2REZlblltQmoxZGMxSlgrZ2dnUS9XSmti?=
 =?utf-8?B?QUxNaW1JdU81ampmR2N0Y1orSVF5Mmw4ZlFIeUErYjlna0FoeTVva1pCRExq?=
 =?utf-8?B?SmF5SGVpdTAxYVFOQnlLdkJPdklRWDYrR1MzZjl5d0RUWkZOY0Nya2ZoY0hz?=
 =?utf-8?B?Ym9hQ2tjdS9sMWREWVo3TGFOTG9jSXVaYmQ5ODZYZnBuOUhWeWNtbEpvOWlI?=
 =?utf-8?B?c1NYZkZWbGl6WUtKbW5waFJzVnhPa0FrM3g5Y3dINFovU0xUNVNqeE5tVHVy?=
 =?utf-8?B?emR3MDhNbmZCZklNNkFRNTZDZmFxbk9DQmdmYlFjcnZHUlZaRXpmNXdBUnhZ?=
 =?utf-8?B?Mk9veUk1bkhNc243Wlh6N1FDdzRReVoxQkJ6UWMxOFduNWhLdGV4NEJ0UkZu?=
 =?utf-8?B?RHdwdXk1bkNCcjFuZjI4ODNuV0pvaG5MblNReGlQNTZGWkkvS28zZGdmQ1VT?=
 =?utf-8?B?M2Nyc3Y0WUhEaDJqdjgxT0M4cGRUWElGYll2N3RrQmNWUXhwQXd5TTZJYmJj?=
 =?utf-8?B?bnM0ajlTV1BtN05kRitjbVVSNGZRYy95MXVJNlBqbkpJdXpXUVJ0UVFVa3J0?=
 =?utf-8?B?OGw0ekZoL2xVV1VMRU1KMG9sU2J5ZE1PYVFZNnJrcUozdUdla2FOaWwraE5p?=
 =?utf-8?B?WmNiK3VCcThMR0VOYU1KQlR4VjNMakJsUGxDWUp5NGxjbW0rZ0FvSERwQUc0?=
 =?utf-8?B?VTFIMzM3ZG1sM09zTnByLzJDSmtoREh4S0ZucU40U1VIYy9iQ0RESk5zUElU?=
 =?utf-8?B?azFOd3pydlRzKzBORHZPSk5zTUFUV2xNMXhDTjhXMHMyUnBacVBzb1VsbzRM?=
 =?utf-8?B?SWUxeU1aMDVMV1o0dDBvUEZCdVdlZjV5K2F3dWNVSkc3YW9Ba0hGajVmdndh?=
 =?utf-8?B?TzBpdjBndGQwNzRJSlRINnNZOGtpZllLRWNjcEoxbUFIZWdlSXJ5UWZWZzls?=
 =?utf-8?B?WFV0QlZpWThEVUordlJvVGo1c3RudjdaWEhwVWg4VWhaQit3WUN1VjQ1N0kz?=
 =?utf-8?B?VTFXNFBWVmsxNTNkQ2RNa1ROUXNIL3FWQXRHNlFIN1gwMHc5QktSK0RrMXNz?=
 =?utf-8?B?ZWxNVW03cWdWTldVQjYxM285TjYrVDdQQnFwNWY3TjlvTy9PSlkvbU9laG93?=
 =?utf-8?B?YzErb080TzBWS1BiQ3hrM1VnZDUzK0FVZFFWSUlYSStmRXNBNy8xSGFhUUNa?=
 =?utf-8?B?OHFXRk52Ymd6SUp2R1lzZksvd1Y2ZzZNYzdDbHdmaFhCb1FhTWJKYkRhdytS?=
 =?utf-8?B?ZFRlUXVJdDg5OGRNY1pKNkJFNmR6c2cybDVQMTJ0RHdXVVNrQ0dDT0t3bHp1?=
 =?utf-8?B?S2wrNEsybDhNWEl3dmFEMzBEYjNOaURIOFF1S1RLL1lXNWhobTZ1Y2IrOUVD?=
 =?utf-8?B?dHJMRWpsRDFJeVU3TndNalRpeXpMWkdnL3dLM2FqY3JDL0Z6Zk84T05yUkdG?=
 =?utf-8?B?Ym9sTmNXdFdmYllSRDMzZGZaV3YxYlZ6bVJQelExNk5za0p5WVV5UFRVUlFM?=
 =?utf-8?B?bis0M0pOS29TYmg3WTdad1pocjhjYk9uNXhjR1ZKc2lKS3ZTdXJJNWpUd0Np?=
 =?utf-8?B?a3E3Wkx3dUwxN3JxdzlpWVRKMmZlQXNIK2hQTlJ2MkhONnhBeGtoVWpQYjJw?=
 =?utf-8?B?aFVvVHVYZEtQdVd2R1N6VndmU2Q1M0xodmVXOVhpUkd3NXp4V3RCS1ZQZW9Q?=
 =?utf-8?B?ZzJmM0dnQUp5NkxIV3FOTEFxYm94c2c1Y0dYSGRzUXVuVmhTRXNLOG41YlND?=
 =?utf-8?B?dzQ4eDBhNDMzdWI4ZkJNVTBmY2xwKy9RWUg4c01YYUdtZnBJcGtHRmtLSjN2?=
 =?utf-8?B?MWhObktScUtmb0t6eG4yVlRRZHkyN0pGRTM0WGhReU91bmFoUmV4QThqaXpQ?=
 =?utf-8?B?aEJnaUJQZXk1dkp1TGVlM3VHZ0xVU3BjUXlFV1h1ZURXWE8wOW5tMjdDWEE4?=
 =?utf-8?B?ZkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f4049cc-e3c1-4b2e-48ed-08dbe5f5371e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 16:09:15.8926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uWj7aKoQm9G7c5xpQGC8rzR6Segm+whStzYhZ6+E5Duh3pcpctCFGxfH2bKYytvx20n9lzigSgJFN98zRQPLOCvRgEZe6myP9XfNQ7E6OCI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7136
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:09:44 -0800 (PST)

Hi Tony,

On 11/9/2023 1:27 PM, Luck, Tony wrote:
>>> Maybe additional an mount option "mba_MBps_total" so the user can pick
>>> total instead of local?
>>
>> Is this something for which a remount is required? Can it not perhaps be
>> changed at runtime?
> 
> In theory, yes. But I've been playing with a patch that adds a writable info/
> file to allow runtime switch:
> 
> # ls -l /sys/fs/resctrl/info/MB/mba_MBps_control
> -rw-r--r--. 1 root root 0 Nov  9 10:57 /sys/fs/resctrl/info/MB/mba_MBps_control
> ]# cat /sys/fs/resctrl/info/MB/mba_MBps_control
> total
> 
> and found that it's a bit tricky to switch out the MBM event from the
> state machine driving the feedback loop. I think the problem is in the
> code that tries to stop the control loop from switching between two
> throttling levels every second:
> 
>         if (cur_msr_val > r_mba->membw.min_bw && user_bw < cur_bw) {
>                 new_msr_val = cur_msr_val - r_mba->membw.bw_gran;
>         } else if (cur_msr_val < MAX_MBA_BW &&
>                    (user_bw > (cur_bw + delta_bw))) {
>                 new_msr_val = cur_msr_val + r_mba->membw.bw_gran;
>         } else {
>                 return;
>         }
> 
> The code drops down one percentage step if current bandwidth is above
> the desired target. But stepping back up checks to see if "cur_bw + delta_bw"
> is below the target.
> 
> Where does "delta_bw" come from? Code uses the Boolean flag "pmbm_data->delta_comp"
> to request the once-per-second polling compute the change in bandwidth on the
> next poll after adjusting throttling MSRs.
> 
> All of these values are in the "struct mbm_state" which is a per-event-id structure.
> 
> Picking an event at boot time works fine. Likely also fine at mount time. But
> switching at run-time seems to frequently end up with a very large value in
> "delta_bw" (as it compares current & previous for this event ... and it looks
> like things changed from zero).  Net effect is that throttling is increased when
> processes go over their target for the resctrl group, but throttling is never decreased.

This is not clear to me. Would the state not also start from zero at boot and mount
time? From what I understand the state is also reset to zero on monitor group creation.

> 
> The whole heuristic seems a bit fragile. It works well for test processes that have
> constant memory bandwidth. But I could see it failing in scenarios like this:
> 
> 1) Process is over MB limit
> 2) Linux increases throttling, and sets flag to compute delta_bw on next poll
> 3) Process blocks on some event and uses no bandwidth in next one second
> 4) Next poll. Linux computes delta_bw as abs(cur_bw - m->prev_bw). cur_bw is zero,
>     so delta_bw is set to full value of bandwidth that process used when over budget
> 5) Process resumes running
> 6) Linux sees process using less than target, but cur_bw + delta_bw is above target,
>    so Linux doesn't adjust throttling
> 
> I think the goal was to avoid relaxing throttling and letting a resctrl group go back over
> target bandwidth. But that doesn't work either for groups with highly variable bandwidth
> requirements.
> 
> 1) Group is over budget
> 2) Linux increases throttling, and sets flag to compute delta_bw on next poll
> 3) Group forks additional processes. New bandwidth from those offsets the reduction due to throttling
> 4) Next poll. Linux sees bandwidth is unchanged. Sets delta_bw = 0.
> 5) Next poll. Groups aggregate bandwidth is fractionally below target. Because delta_bw=0, Linux
>    reduces throttling.
> 6) Group goes over target.
> 

I'll defer to you for the history about this algorithm. I am not familiar with how
broadly this feature is used but I have not heard about issues with it. It does
seem as though there is some opportunity for investigation here.

Reinette