Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
To:     Muhammad Muzammil <m.muzzammilashraf@gmail.com>
Cc:     martin.petersen@oracle.com, bostroesser@gmail.com,
        michael.christie@oracle.com, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: target: Fixed multiple typos in multiple files
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq17cmj10bl.fsf@ca-mkp.ca.oracle.com>
References: <20231023105915.29482-1-m.muzzammilashraf@gmail.com>
Date:   Wed, 15 Nov 2023 11:12:53 -0500
In-Reply-To: <20231023105915.29482-1-m.muzzammilashraf@gmail.com> (Muhammad
        Muzammil's message of "Mon, 23 Oct 2023 15:59:15 +0500")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fiGVDOlILerFDnIhJPLBNdJUv2lJVBAtZVyKc9FhESrBH64efaHUsdv6OV9V?=
 =?us-ascii?Q?NoX24ZaFXgMXRnHNKJokxitnRZtTjpZ70xx3F+Uw9JVCCsBTIM4LEXVU0L4I?=
 =?us-ascii?Q?NdzJlf5C+jiKAdH78UOOdHVFdswookqDx3jrkQfHG2F8BORmEnLlvuzrtvqj?=
 =?us-ascii?Q?/66He0KnN5vKJBduNhC1KCTJIfV6wqwzT5iXxUs/RfFot0CIL1anIvraKANu?=
 =?us-ascii?Q?PrvPVD7LkbnHoYIbTmTrmmWz6EkKGQ68mSIrhFTTDNoBeqhSxOog0ftYTJar?=
 =?us-ascii?Q?NO7k/8DXHsrydtuhaRguTsQM+WaqqXGaLxAKw188XP2I81xNxlns/Mg/s42E?=
 =?us-ascii?Q?PlQFRIrC9GnCP9zkVG/NZ+nL7BS5kHmEQcu5q+tMMFQAJlTK7yzHYBL5eiqf?=
 =?us-ascii?Q?cBKzPRXmJvP4QBYSmroFOgx/xjdemy499rtf3PwFRVnSjBnILytqZNKmqp99?=
 =?us-ascii?Q?M/5LvWq6ovTkCghM6nr3ERNDy7AKtRv6D2U6wepQjSPM8+gZRrwfR4HMV73T?=
 =?us-ascii?Q?7U5Z2Dq8mWWdzBZKWdlBXSkl1YhXJ3NRx3Yroq3DGN7RjhdvZJnjCvPI0XpS?=
 =?us-ascii?Q?DyYk4dAlycVBlaWs3HhyeZOWb2kzpRF8QhdLUCSklLUStnAa3iV96LdUZ0/p?=
 =?us-ascii?Q?Xy73VW8QC2L74L7AvAYj59AS3+qSDWjCyxZk9a3vAyk5wLZhMhBC6rF+OBlP?=
 =?us-ascii?Q?L5BI2DEuPAr9/qGIO6Atgsfu/l+Kg+G0y1N4L4EwRniVRehZgF4UGEAvYeWM?=
 =?us-ascii?Q?E68ynFqPmzqoGL9WpKMaTHb6nx/9lrd0I9ei3ON4Lc9x6QvkBbTYMoBGcSAG?=
 =?us-ascii?Q?zBch08Msz30eVNJf8EjjFGDo8v3z+FLsLj4LlZpA014Ef6JZcYAjgwMp+4Dp?=
 =?us-ascii?Q?gz7zfBmEommqxJOVbL8lSRi09JelKr91sPNOqkdHcqao/Vo16K7fmJgPiKMJ?=
 =?us-ascii?Q?uhe2P03a7qSNv89BlLg8CvJ9R5ZObgADG1fXgxhzQTUxoOJoyZpUyE85BkKe?=
 =?us-ascii?Q?gOwr/exAndQLRtDk1uFBFXbxl5HxNAUkprWtE66DpSGNAF7iXyT7iZMZCu8V?=
 =?us-ascii?Q?N+AMQoVf6mKHvN2VQNdfL57JEwPw+Q/J0K8U0UyOoFjNHoeV/+CVaYWtFUDX?=
 =?us-ascii?Q?npmIcmPGRKAitxnTGEB0sz2163FIQUcNjieBB/3vs29gcdBTRJBQGnPX9gL6?=
 =?us-ascii?Q?2bwIw2GRfmST98HCChbyytH0Pd5Fp/CZ78HUwzuiEsUrvnILrS8r8oHJ/LfW?=
 =?us-ascii?Q?IrS9Yl0UgDzn+JdPr06USk02CY1SMtInpKjneU7oMlJZV9N2sTsc0iy+Hb5E?=
 =?us-ascii?Q?9ToDl0gCEJTM/d10mR/qSTxss/GeGhM/y+sToFpQOsY7nczDSPKorQZAaeDe?=
 =?us-ascii?Q?2IXEzgDN2NF1cdtizT22RbdHFN0FQQBA2RdEGUsPBXsGyUXxcvY2M+bIZsz6?=
 =?us-ascii?Q?BOhbXQd3/iPU3WGoXB0SJoYBb1nKKx34LaUfl4xthbQ64ywVtyFQ2fNCyLfz?=
 =?us-ascii?Q?qGJo0Y0Hnb3xk2bubZJEX4rIRPqtdHK/s/kP5cP4NGtR+UqcJnfaIA2hEjIQ?=
 =?us-ascii?Q?XAPtg6A/opS8Wb5UN3NjU4EgzP4ZU30L6sz+53k/FmtzkrF42fdEw7kpLqCA?=
 =?us-ascii?Q?0A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BK9ZBfZhs6NtrGtK9y+ZSDCI5eUks1MTXFEZpA2B9v+dUAsZXMnMPYE0Wao/MZztsAmy7KvpbeeF6VPeSuNm5sSHgAereNS0m4TdNrUJ5+OcfPpkcspYVhLfbfiDQ+KSphX7MrslZ+ELi6fwZe7O3lDs2XF6mJoA4A2YB9GAtYkZ+Ut2+poXffe0Xv1cTET6SC1mWT4aZzklWQ6q/yrZ/VICwOoOSSRm5mDxOFH/d6W4+MTayipPIGNCvPNI+NN0kmqkcnzzrrN+wCqDzt3+V0M08ylP884i9mVMhqnyqPJOJRY+BNwPW7sVYRKbliW61Dg1/Y2GMnboMnVzOTZLI8FEGAAC8RYEBZUiMDNkULmdfkYt+p1DcNyTWXyMavKHhLPEr3TWwTMD/r6jMgDgkX8zHLGhOAWJFkFOIkybKM2jc/MYydjhfR5jKuEwITYP4pxKCwToL3xS2Lfz44GXeVIIBCQ24jecVavJm7BYJG4sNePWEYdq8bCkh9cY4vBr44wkW5A9av8gQsEUwMlNp4x2Vj9EfIVIbTvZJiIq96UyxnoKC+3J5b5iNnDDgomF8Aa27HZKiuEfgrLrtXnNWneHWGbYjv7En08idlvrGfRILlZheXTGNcVpUug0OPW4kZx6UdSwN9o+iE4lbO4ixxaqNC+bWySvOD7UrxPkKAdoiN4srpZrfZuOj52iBgOBkSpt4pgPefTzuESl9I/6PFzX2EwENqxERaHf1QvESjxzXp6pwB8fVPpGlPpGgE40oHXtDc1jupFq5ZY60Wx+1OswDF852MYXz7FoltA2XMk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e62e0b2d-d9ef-49f9-63c9-08dbe5f5ba2b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 16:12:55.7335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: olpvtDb2DTuebEPRP6kzXJ+zJaWIAjndvrxJFH8sB94XuyF8VPdtOLtbb3l6kH9B3LrUdvcBxAtx539DweFNxHbae7TjNCNUXbJNgfCBPfc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7032
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-15_15,2023-11-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0
 mlxlogscore=971 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311150123
X-Proofpoint-GUID: DnyxKST1U-GjnwVSmApql0qoO1Pa5o4c
X-Proofpoint-ORIG-GUID: DnyxKST1U-GjnwVSmApql0qoO1Pa5o4c
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:13:22 -0800 (PST)


Hi Muhammad,

> -	 * CID we do connection reinstatement.  Currently we dont not
> +	 * CID we do connection reinstatement.  Currently we don't not

"Currently we don't not" does not parse. Fixing misspelled words in
isolation is not necessarily an improvement. The criteria should be
whether the entire sentence or comment becomes easier to read.

> -		 * status, with the sense key set to ILLEGAL REQUEST,and the additonal
> +		 * status, with the sense key set to ILLEGAL REQUEST,and the additional

There's a space missing after "ILLEGAL REQUEST,".

> - * Called thru fc_lport_iterate().
> + * Called through fc_lport_iterate().

"thru" is perfectly valid and the author's choice.

-- 
Martin K. Petersen	Oracle Linux Engineering