Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231115061811.10041-1-joshua.yeong@starfivetech.com>
 <CAK9=C2VXxNjKOq1XqQ9t6iVELdj2fFi85K77xNCOfdf3WRdy8w@mail.gmail.com> <f373645c-1e89-df76-e545-21bf0ba9ee8f@starfivetech.com>
In-Reply-To: <f373645c-1e89-df76-e545-21bf0ba9ee8f@starfivetech.com>
From:   Anup Patel <apatel@ventanamicro.com>
Date:   Wed, 15 Nov 2023 21:54:09 +0530
Message-ID: <CAK9=C2W3_LNjQkW0G5TypNW_=3sGOV8NMuYEwnq5Yj=RmgkE3A@mail.gmail.com>
Subject: Re: [PATCH 1/1] clocksource/timer-risc: Add riscv_clock_shutdown callback
To:     Joshua Yeong <joshua.yeong@starfivetech.com>
Cc:     daniel.lezcano@linaro.org, tglx@linutronix.de,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, leyfoon.tan@starfivetech.com,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 15, 2023 at 1:22=E2=80=AFPM Joshua Yeong
<joshua.yeong@starfivetech.com> wrote:
>
> Hi Anup,
>
> On 15-Nov-23 3:00 PM, Anup Patel wrote:
> > On Wed, Nov 15, 2023 at 11:49=E2=80=AFAM Joshua Yeong
> > <joshua.yeong@starfivetech.com> wrote:
> >> Add clocksource detach/shutdown callback to disable RISC-V timer inter=
rupt when
> >> switching out riscv timer as clock source
> >>
> >> Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com>
> >> ---
> >>   drivers/clocksource/timer-riscv.c | 7 +++++++
> >>   1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/t=
imer-riscv.c
> >> index da3071b387eb..588a05459b6a 100644
> >> --- a/drivers/clocksource/timer-riscv.c
> >> +++ b/drivers/clocksource/timer-riscv.c
> >> @@ -50,12 +50,19 @@ static int riscv_clock_next_event(unsigned long de=
lta,
> >>          return 0;
> >>   }
> >>
> >> +static int riscv_clock_shutdown(struct clock_event_device *evt)
> >> +{
> >> +       sbi_set_timer(-1);
> > Use riscv_clock_event_stop() here.
> You mean replacing riscv_clock_shutdown as riscv_clock_event_stop?

I meant replacing sbi_set_timer() with riscv_clock_event_stop().

> >
> >> +       return 0;
> >> +}
> >> +
> >>   static unsigned int riscv_clock_event_irq;
> >>   static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) =
=3D {
> >>          .name                   =3D "riscv_timer_clockevent",
> >>          .features               =3D CLOCK_EVT_FEAT_ONESHOT,
> >>          .rating                 =3D 100,
> >>          .set_next_event         =3D riscv_clock_next_event,
> >> +       .set_state_shutdown     =3D riscv_clock_shutdown,
> >>   };
> >>
> >>   /*
> >> --
> >> 2.25.1
> >>
> > Regards,
> > Anup

Regards,
Anup