Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2720457rdb; Wed, 15 Nov 2023 08:41:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEO2ISJyuF6VIvSTkyX+h9TKH303L1h/wGkVIOA4KNHSjf3pUSoySuAVV2JV2qpuK3QabwG X-Received: by 2002:a05:6a21:3984:b0:186:2caa:b712 with SMTP id ad4-20020a056a21398400b001862caab712mr11613505pzc.30.1700066488333; Wed, 15 Nov 2023 08:41:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700066488; cv=none; d=google.com; s=arc-20160816; b=O315/ZjkSYtKlFvTqG7VniXAVB+zF38lAPmKMb4FY9bjA/kYk3u94LXI6F5odzB/la WdcPdv13TqTY0DyJ0ynRMgt4d9dnLgF70iuD1T3m8wo2ncOAJLSOCEs38uaAnwXmAJcn wFrz6hgO2Zw5b36+MZ6DT53t2r7Rb0qH8Ad21WOMXXpuw7PfnDWlLzFKY+leSlPCDdjn BWetyJc5msRgTa3A4RP94UYAw2x7fA06nIZl5S9+J338jyYpAIfEufrFaOMWmdknEpFt ItZHJ9wZHlXhH5G9O1xdCtIR1HIt1KN+xcTCrueDsGgPM+NgENmPKakPOqz4XWRMd3DN Ye0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=HCpNMTIKyOeROsc7/RWOAvMZhqSI0z3duXfnje8m3KQ=; fh=K9dsPdiRvZatIG0ec48Frz8OuWIbVWesE+ye89B28zI=; b=OJASdREQblgKrGkmVQaeYPz4Y6qbxV+dnul1rZCEr2Q12qEvi8KTYsLEoOnBbZhI9w nO4jD/2w1NHAWsgON/OtFDUcl4kjiKLAoB9JC3rLWJ1NHUUOwSHIpPsbCPEwL/Rb4rCC 1WRuZZrDoB+W+0NOqDzNvRhVdcprgnaAztoilRgVxl1u1q6wZivXxCRYEWTYVzZzCKxd x32bqeMgXFuIljXQ+4w22Z9kBD5SSfMKlcqDcV9ct/20hSXLxYzLUvM3DorbRvF3yFHV 4H22inK1MpdY/HC/OQniB5abJTYrHGMpASym3idMV23rXKsYGuslMZsjy75NAKEjU5OR DPEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AO9vI+4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id q24-20020a656858000000b005b9658763f9si10575829pgt.541.2023.11.15.08.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 08:41:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AO9vI+4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E726F80B79D5; Wed, 15 Nov 2023 08:40:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232296AbjKOQku (ORCPT + 99 others); Wed, 15 Nov 2023 11:40:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232797AbjKOQkX (ORCPT ); Wed, 15 Nov 2023 11:40:23 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D7AD1FE5 for ; Wed, 15 Nov 2023 08:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700066395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HCpNMTIKyOeROsc7/RWOAvMZhqSI0z3duXfnje8m3KQ=; b=AO9vI+4fQpt3q9v8Oy1jtTZjOUeXANa6DFbj3uS80cYs/SPzv6KkVZfmGtJkQTQyuCEYje M0EZkI8gj7yWBVzAUB9kobQJaUTalRe99NKVbNQ8c9EmQci6NnZR3ufwwTdxpNNnrerFfC iPdsxc/efrV9s1Y/MdFpJTVtXLAUFkY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-UdDnholkMuG4DRRASuNUrQ-1; Wed, 15 Nov 2023 11:39:50 -0500 X-MC-Unique: UdDnholkMuG4DRRASuNUrQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6F20101B04B; Wed, 15 Nov 2023 16:39:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0B85492BE8; Wed, 15 Nov 2023 16:39:33 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20231115154946.3933808-1-dhowells@redhat.com> <20231115154946.3933808-6-dhowells@redhat.com> To: Linus Torvalds Cc: dhowells@redhat.com, Christian Brauner , Jens Axboe , Al Viro , Christoph Hellwig , David Laight , Matthew Wilcox , Brendan Higgins , David Gow , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Andrew Morton , Christian Brauner , David Hildenbrand , John Hubbard , Huacai Chen , WANG Xuerui , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , loongarch@lists.linux.dev, linux-s390@vger.kernel.org Subject: Re: [PATCH v3 05/10] iov_iter: Create a function to prepare userspace VM for UBUF/IOVEC tests MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3936725.1700066370.1@warthog.procyon.org.uk> Date: Wed, 15 Nov 2023 16:39:30 +0000 Message-ID: <3936726.1700066370@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 15 Nov 2023 08:41:00 -0800 (PST) Linus Torvalds wrote: > From a quick look, what you were doing was checking that the patterns > you set up in user space came through ok. Dammit, what's wrong with > just using read()/write() on a pipe, or splice, or whatever. It will > test exactly the same iov_iter thing. I was trying to make it possible to do these tests before starting userspace as there's a good chance that if the UBUF/IOVEC iterators don't work right then your system can't be booted. Anyway, if I drop patches 5, 6, 7 and 10 (ie. the ones doing stuff with UBUF and IOVEC-type iterators), would you be okay with the rest? David