Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755858AbXKZRxp (ORCPT ); Mon, 26 Nov 2007 12:53:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752429AbXKZRxi (ORCPT ); Mon, 26 Nov 2007 12:53:38 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:35302 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbXKZRxi (ORCPT ); Mon, 26 Nov 2007 12:53:38 -0500 Date: Mon, 26 Nov 2007 09:53:17 -0800 (PST) From: Linus Torvalds To: Bron Gondwana cc: Peter Zijlstra , Christian Kujau , Andrew Morton , Linux Kernel Mailing List , robm@fastmail.fm Subject: Re: [PATCH 1/1] mm: add dirty_highmem option In-Reply-To: <20071122034204.GA14079@brong.net> Message-ID: References: <20071115052538.GA21522@brong.net> <20071115115049.GA8297@brong.net> <1195155601.22457.25.camel@lappy> <1195159457.22457.35.camel@lappy> <20071122034204.GA14079@brong.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 24 On Thu, 22 Nov 2007, Bron Gondwana wrote: > > This patch includes some code cleanup from Linus and a toggle in > /proc/sys/vm/dirty_highmem which can be set to 1 to add the highmem > back to the total available memory count. Just to verify - can you confirm that this "just fixes it" for you? I think this is the right approach to take, and seems very safe (ie people who know that their loads are ok can just set the flag), but I do want to verify that there was nothing else going on, and that you now see the same performance as you did in 2.6.16? The other alternative, of course, would be to simply allow the dirty percentages to be > 100%, but that's just *odd* ;) Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/