Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <5356bcbd-0785-4156-993c-338fed67d39d@amd.com>
Date:   Wed, 15 Nov 2023 11:04:42 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 7/7] PCI: Exclude PCIe ports used for virtual links in
 pcie_bandwidth_available()
Content-Language: en-US
To:     "Lazar, Lijo" <lijo.lazar@amd.com>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Lukas Wunner <lukas@wunner.de>
Cc:     =?UTF-8?Q?Marek_Beh=C3=BAn?= <kabel@kernel.org>,
        "open list:RADEON and AMDGPU DRM DRIVERS" 
        <amd-gfx@lists.freedesktop.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        Xinhui Pan <Xinhui.Pan@amd.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <dri-devel@lists.freedesktop.org>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        Danilo Krummrich <dakr@redhat.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <nouveau@lists.freedesktop.org>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Maciej W . Rozycki" <macro@orcam.me.uk>
References: <20231114200755.14911-1-mario.limonciello@amd.com>
 <20231114200755.14911-8-mario.limonciello@amd.com>
 <e0e76948-a0a8-b6c2-163b-1d00afb6650c@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <e0e76948-a0a8-b6c2-163b-1d00afb6650c@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eU1DNG15aFYwYjdJTUhhSjNHQXBZM1pOZnVndkFFY1o1ZUxqMmFaUDJ5bjBD?=
 =?utf-8?B?UzBTWHpqSDlSVkFhYlpqQmxjbWR2SjdYclVKQmJSNUJmVk56eGdOeWRHWERz?=
 =?utf-8?B?Z2w2Ly9pMmtQeUhEUml4WnowdnQvdFBlbkhyT3lzOEt4citBb0MyKzJGUmpB?=
 =?utf-8?B?azVZOUtVREQ1dzRrRGNtTW5kTys5UUErcGEzS29NNkFXNytkbHk1MDA2dmJr?=
 =?utf-8?B?dmpCNU9ULzFzMDRaNk04cjJucWZpL3ZDQWNjYTNMOVRiTHdFYjNjZ3lnZytk?=
 =?utf-8?B?NjVxeGl5WE9GQ2pyaWdRbm8xVzFDWGJ3U0F1Q01ta2YrN3IyditSVHF1cmNk?=
 =?utf-8?B?aWFOcHk2dURWbHdjYklCK01CNHVocXZxbzEwK2dhZDU5eGFSdlV2NzA4b0V4?=
 =?utf-8?B?SG5PWnVhN2ZncUFaUk5XRVArdkpjaTRxSkEwdlBMZi9CMWZ3S3ptQmlmUWx3?=
 =?utf-8?B?Qk5HamtMRHBLRlkyT2cwYXFJUzdCNjg2ckpvZVFxaHJlSTYrOGFFSXNCU3Ns?=
 =?utf-8?B?Y01ZUk8yZ3ZwYVBkb0xGZzJHZGUvMno0VGE5ZWd2R0xUMDd4Y2k3d3BjaS84?=
 =?utf-8?B?cjFZcVNYbGlsS0kzdStLWklPMmNHUjhuWkJCV0w1am90TGw0OUNTOGRaSUcr?=
 =?utf-8?B?bFpPL1J5MEJvUTZsWFNERlNtMVBPSFFlalZJTmkwQmcxZXpwR21UZ0hZZHMw?=
 =?utf-8?B?WTczckkyUzUrRUxPdUdaa3RyTXJDQ2YvMTQyUHFjNlVOdmlsRndVRTR2ZE5M?=
 =?utf-8?B?VnNxSlBRT1JNL1BVdjJRQ2RhR1hjT0k0MWxtZUVkQ0xGWGVWbTNjUjNYeHIy?=
 =?utf-8?B?S2pQaEt6UFowM2RXK1BVSWtiNVpMQ1QwZit6YkUydTRRRlpGL3dmVVZVcG5W?=
 =?utf-8?B?MmhDUXc3OUgvbjN4eU1HWk9SUkxkYzByWmMyK0hoOFdleWVYSUVydlNBNEJL?=
 =?utf-8?B?Vi81NVA0OFdtZG9LZkEvakFKbkRYZ0dSN3VPdXR0WXpXaGlab0NDOXhhbWsy?=
 =?utf-8?B?d2dteHpjcmlQKzg4MEZ5cTVOejVjcDl2SDVUU0N2UEZKYXBUWWhpaTQxaldX?=
 =?utf-8?B?cUQ5bjI3a0JpRkE0U3FQbW5DYWNlMjlIc1hMWk0vcWV2QkRUWVlqSUJ6Q2xX?=
 =?utf-8?B?dnRxOGZnZE80SnBCSDVONFU0Mm1hMTF3RWRYbFhkNEc5RGNZV1pTOElvLys5?=
 =?utf-8?B?RU9VQUk3dzdpcHNXL2FlOEJPeHBKTUR1VEt3QlRGQ09BYVRtdjFWUEYxa3Vv?=
 =?utf-8?B?UGJsM1BEL1lvaUVDaFd6V1dMdnlpajZYR0ViLzN6ZWwyTVcvUFM1bzg1bXg1?=
 =?utf-8?B?TkMzV1VGQlJQZVladjZMZ0FCSGFZQ1huQ2hwY3VzTFpPUFFTY2hIKzhLYmxS?=
 =?utf-8?B?UWNVbk9xVFlzU1FnZUFYVW5BWEZld2ZkRm9Qam9mWWEzMHZMRk9SS1FYaHU2?=
 =?utf-8?B?cVhwdTg5WWwrQ1pHaE9Qb1Bzc28yd0cyNzJKNUV2cEE3UisxdVpFakJxUTlX?=
 =?utf-8?B?VFJ3dWRWOStaNXJSVkYrU0ZaSFVRVW5Ma3haLzN5WEF1QXgyNll1ZFRuazlZ?=
 =?utf-8?B?YzIrTzNZUFpFZGp1WTF6TmFnZWp3SHlocW5kZC91TWRid1l5SUYvSWVxa2pv?=
 =?utf-8?B?QmFLb0VMUGJMU2IvRis5SDRBZUo5RmpZQXBqMTVyWVNaMHlXeWtpdXJpMDQv?=
 =?utf-8?B?R3hodnRocjhnb0F3L3lwaWVCWldIYnlrV3ljd2dtZy9DTGNOY3RxSlRaeTlO?=
 =?utf-8?B?VnQvbDNtdXhFbVlzRkVleWVDRU5ocVdiSU43YkFBbXdqU0RXL3puS3ZOdFNR?=
 =?utf-8?B?QmJtRktLN2dxV0RHUjZoT29UNXAxZFJlU09wNUEvR0o0R1ZhanVGMklyc2Iy?=
 =?utf-8?B?MHZyZFRnZVU2eGkwSEVMRVR5MUdGZTh0ODhVaVpsZGdQMjJUSDc0MUV1TGRC?=
 =?utf-8?B?V0R2VnlKbCtyTUpMV09Sdi9ETlFIbmY0M09ML0NnQ0traDdnU2laby9EVEdL?=
 =?utf-8?B?cnJ5U0M5TlBkeG40TGlBQklPWjBPeUxhQjgrTVF0UGwvdVgxbVoyUFNSZXZQ?=
 =?utf-8?B?VlRZYlN4bVhYN0ROdVlEM1hwTkR3a1Y4ZTI1dDhDd0p5a1ZwQzZvUkpZVmlq?=
 =?utf-8?Q?DAEKmMZoY9fHpvkbFMPOIpAiI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 870119d7-96eb-4a4a-0d07-08dbe5fcf78b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 17:04:45.2397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SLgWPAeSotv6yt5PYUDAm8j0cc74oVYuMdKXdlSIt0V8P02x/kKL+Jn/yoNO12WUYceEnJvj2EPEWyJGOyB5YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5006
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 09:05:36 -0800 (PST)

On 11/14/2023 21:23, Lazar, Lijo wrote:
> 
> 
> On 11/15/2023 1:37 AM, Mario Limonciello wrote:
>> The USB4 spec specifies that PCIe ports that are used for tunneling
>> PCIe traffic over USB4 fabric will be hardcoded to advertise 2.5GT/s and
>> behave as a PCIe Gen1 device. The actual performance of these ports is
>> controlled by the fabric implementation.
>>
>> Callers for pcie_bandwidth_available() will always find the PCIe ports
>> used for tunneling as a limiting factor potentially leading to incorrect
>> performance decisions.
>>
>> To prevent such problems check explicitly for ports that are marked as
>> virtual links or as thunderbolt controllers and skip them when looking
>> for bandwidth limitations of the hierarchy. If the only device connected
>> is a port used for tunneling then report that device.
>>
>> Callers to pcie_bandwidth_available() could make this change on their
>> own as well but then they wouldn't be able to detect other potential
>> speed bottlenecks from the hierarchy without duplicating
>> pcie_bandwidth_available() logic.
>>
>> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2925#note_2145860
>> Link: https://www.usb.org/document-library/usb4r-specification-v20
>>        USB4 V2 with Errata and ECN through June 2023
>>        Section 11.2.1
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> v2->v3:
>>   * Split from previous patch version
>>   * Look for thunderbolt or virtual link
>> ---
>>   drivers/pci/pci.c | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>> index 0ff7883cc774..b1fb2258b211 100644
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -6269,11 +6269,20 @@ static u32 pcie_calc_bw_limits(struct pci_dev 
>> *dev, u32 bw,
>>    * limiting_dev, speed, and width pointers are supplied) information 
>> about
>>    * that point.  The bandwidth returned is in Mb/s, i.e., 
>> megabits/second of
>>    * raw bandwidth.
>> + *
>> + * This excludes the bandwidth calculation that has been returned from a
>> + * PCIe device that is used for transmitting tunneled PCIe traffic 
>> over a virtual
>> + * link part of larger hierarchy. Examples include Thunderbolt3 and 
>> USB4 links.
>> + * The calculation is excluded because the USB4 specification 
>> specifies that the
>> + * max speed returned from PCIe configuration registers for the 
>> tunneling link is
>> + * always PCI 1x 2.5 GT/s.  When only tunneled devices are present, 
>> the bandwidth
>> + * returned is the bandwidth available from the first tunneled device.
>>    */
>>   u32 pcie_bandwidth_available(struct pci_dev *dev, struct pci_dev 
>> **limiting_dev,
>>                    enum pci_bus_speed *speed,
>>                    enum pcie_link_width *width)
>>   {
>> +    struct pci_dev *vdev = NULL;
>>       u32 bw = 0;
>>       if (speed)
>> @@ -6282,10 +6291,20 @@ u32 pcie_bandwidth_available(struct pci_dev 
>> *dev, struct pci_dev **limiting_dev,
>>           *width = PCIE_LNK_WIDTH_UNKNOWN;
>>       while (dev) {
>> +        if (dev->is_virtual_link || dev->is_thunderbolt) {
>> +            if (!vdev)
>> +                vdev = dev;
>> +            goto skip;
>> +        }
> 
> One problem with this is it *silently* ignores the bandwidth limiting 
> device - the bandwidth may not be really available if there are virtual 
> links in between. That is a change in behavior from the messages shown 
> in __pcie_print_link_status.

That's a good point.  How about a matching behavioral change to 
__pcie_print_link_status() where it looks at the entire hierarchy for 
any links marked as virtual and prints a message along the lines of:

"This value may be further limited by virtual links".

> 
> Thanks,
> Lijo
> 
>>           bw = pcie_calc_bw_limits(dev, bw, limiting_dev, speed, width);
>> +skip:
>>           dev = pci_upstream_bridge(dev);
>>       }
>> +    /* If nothing "faster" found on hierarchy, limit to first virtual 
>> link */
>> +    if (vdev && !bw)
>> +        bw = pcie_calc_bw_limits(vdev, bw, limiting_dev, speed, width);
>> +
>>       return bw;
>>   }
>>   EXPORT_SYMBOL(pcie_bandwidth_available);