Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2751278rdb; Wed, 15 Nov 2023 09:26:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7cvLtE4uiG+1ciezOgg0T3xKHU/WPAb592D/UfgW065rgQ28hlA5wx6awvM+MkzppNh65 X-Received: by 2002:a17:902:e892:b0:1c6:21b4:30bb with SMTP id w18-20020a170902e89200b001c621b430bbmr7222200plg.15.1700069178584; Wed, 15 Nov 2023 09:26:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700069178; cv=none; d=google.com; s=arc-20160816; b=svBDB7vX7JuRUSsowbNob5dNz9loWEUKKLqpNEuN56YRPKseBjnqDkkng7tTeOKUNA GjwxKzUBacZq3dutLDnaljh6zyIgX+hyYqN3tf8UQLnojPAa/ZRoFu8w6uUpRKs3LQyd G6K7L/8+rTtF0UXUd6qqtHk4MxBhNKxmNdfVrqHT2x20WBNigBJCaefkycVZkSPzpZ52 vYwQgbI9xpkXylyO0uu41C4QNMjDGCKfheJTlaHiBcIhdVfGtmX9Y7+tL4rYmy57TEz8 r0EUrTtQa4hnmFHQSGFKh/RGXygN6CeRkAvxCS7g2k+Z46rcFHI+Ns+yudrCboys47BL kh0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=TxkFYGMJuy8RDq84rB92XeHb3mxQtE5maYApNhXE5PM=; fh=necIO8jytlN/P1ki+L/Ud1XhQQaFuYJjB0EjTi3qTEI=; b=YbjGWGiQuiIouQoH62oy5MObdmck/j000odVF9/f5NgaFOFPUsjiWTfISU1/X6VPW7 l8YW1P1YPQv03eBeH86nDZIh4h+7W18gNkWrr0aV7C6YJDN6+dyPEByVA01cWSJAA98N ShEkmH38z/caKA+n34o/O4H3lPxjwEgRegikSUfgj/Y5sh+BGxyWcuQ2zyzBAOpIbK0s Yb29hRXbR3T4K56RDJ8P/EHHkmt9Sset/aUmfvgvwu5HRsx/N7qfi308cuksa+aQw75m rBwow87avLllvUjQ9bzFWdX84GX/hhSzuwVZnfLxf+95Fab8A8mx3OjcI+kzTCeanTH4 YPFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eQvSIYdL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id d1-20020a170902cec100b001c89c86160bsi10806124plg.385.2023.11.15.09.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 09:26:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eQvSIYdL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id AC4D78114ECD; Wed, 15 Nov 2023 09:26:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbjKOR0I (ORCPT + 99 others); Wed, 15 Nov 2023 12:26:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjKOR0H (ORCPT ); Wed, 15 Nov 2023 12:26:07 -0500 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16E42127; Wed, 15 Nov 2023 09:26:03 -0800 (PST) Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-359343e399fso25449005ab.0; Wed, 15 Nov 2023 09:26:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700069162; x=1700673962; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TxkFYGMJuy8RDq84rB92XeHb3mxQtE5maYApNhXE5PM=; b=eQvSIYdLajIFnsBiVxxodSx07kzrQ6cyjnCIjCltjHdUjl+BUw2Vg+urQJIKbRRjFO Zc+n9fjtBwaAsr+8LISez3kcpKnsP3EVyolsCA+0tBeaxXAeyHWwBYgHMWaVjlZWB5Vw c+VGArZKWPMqgVzf8qTZUHDmvrLmBYglRy9c3MQkv6CYTGvevXDTk6teRzn2QAxslIkL PuZ6vquk0RqzkORaodNn3sF/2uNViuVySPkF65bMFicvVBt5jHJgOHl0DdxJtWmfoF7e q+bcDkA7kWaguBFrXSEWXr8zcYI1Vm4g+0XMfeXeYMswaUn729Yo1pwmFaSghDtR/F5h mN+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700069162; x=1700673962; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TxkFYGMJuy8RDq84rB92XeHb3mxQtE5maYApNhXE5PM=; b=lYKD9FOerK+yjGK8v09gZWWUS7ml/3kMq0AzS1IF8WWwi7q2ek2zXuKrsHr0KiXcsj lD7VDtDXSLWwiGBM8Y8/kjsXjnUH06JKZd64+I/crGPIuwuo8jslSewiSDfPuDoYSM+w GuV0Jl+RsmJgR9Ye1s6R43PSEpQFw3QXfIH9KMGBFrCQXcqZcC/TzYjmwvt/fpVjWFw+ /W1jopCwTw9V/KK8krByKSLzAzT8d489Tu4UUiU6tvVyHPjXTNVltGnhE3ynejjqR0YG ty7iGoOHoUe+kcIcyGhJSU4Q6MNZ0k4WzG2GN+GoWPcWGSxW+ULSUO4eTK2vgCRLxZ0c 6IDg== X-Gm-Message-State: AOJu0YypLhnnhy/eyYL4yflSYwtUGLxjUk2YsP3Kdjs/N6kIYfAqfVqn hfzXOh85YxML4qU3aPXtTCF05jwWjLfrU0g3pa6UC8Jk6Hk= X-Received: by 2002:a05:6e02:b2a:b0:359:4e76:fbf4 with SMTP id e10-20020a056e020b2a00b003594e76fbf4mr18185838ilu.13.1700069162224; Wed, 15 Nov 2023 09:26:02 -0800 (PST) MIME-Version: 1.0 References: <20231106231158.380730-1-nphamcs@gmail.com> <20231114145040.4b90d49d4ace1621c87f9c79@linux-foundation.org> In-Reply-To: <20231114145040.4b90d49d4ace1621c87f9c79@linux-foundation.org> From: Nhat Pham Date: Wed, 15 Nov 2023 12:25:50 -0500 Message-ID: Subject: Re: [PATCH v4] zswap: memcontrol: implement zswap writeback disabling To: Andrew Morton Cc: Chris Li , Dan Streetman , Domenico Cerasuolo , Hugh Dickins , Johannes Weiner , Konrad Rzeszutek Wilk , LKML , Seth Jennings , Shakeel Butt , Vitaly Wool , Yosry Ahmed , corbet@lwn.net, david@ixit.cz, kernel-team@meta.com, linux-doc@vger.kernel.org, linux-mm , lizefan.x@bytedance.com, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, rppt@kernel.org, senozhatsky@chromium.org, tj@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 09:26:15 -0800 (PST) On Tue, Nov 14, 2023 at 5:50=E2=80=AFPM Andrew Morton wrote: > > On Sat, 11 Nov 2023 16:06:58 -0800 Nhat Pham wrote: > > > It's a bit of a micro-optimization indeed. But if for some reason I nee= d > > to send v5 or a fixlet, I'll keep this in mind! > > I'm seeing a lot of rejects against current mainline, so yes please. I should have been clearer - this patch is to be applied on top of the shrinker series (which is still under review). I originally included a comm= ent in the patch log, but it must have been accidentally dropped when I reworke= d the patch according to Chris' and Johannes' suggestions. Nevertheless, I have rebased it on top of current mm-unstable (with the shrinker series on top), then sent out as v5 (with the second suggestion from Chris Li) just in case. Let me know if there are still issues! My apologies for the inconvenience and lack of clarity.