Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2786599rdb; Wed, 15 Nov 2023 10:22:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmK0DetCbhdnMFo27BoNGWNgH5CoZs0EsgPGrrfis8j35qgyE/vbI8Kgl7MioiB5xctKoE X-Received: by 2002:a05:6a21:33a8:b0:187:9ff3:98ac with SMTP id yy40-20020a056a2133a800b001879ff398acmr562664pzb.4.1700072557028; Wed, 15 Nov 2023 10:22:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700072557; cv=none; d=google.com; s=arc-20160816; b=HhPSzuf+meixLAR5jjW+DT50ZxE/qBeclRS9rUp1XIfHLLziWtARfA5YTSPvJjwqKB usNs7WjL2MFIDsql6DY3xfkwRCqiVpt5xEfHCj8JOZbO0MtweqyI/VWGtEjvP7D4sqiG wp9FB7wRRs57ACOBXv1EIcYaFaldLmyNHTeP+R8XBRnEaD1TEDXPLhOJWR0YI29MZZHf RfU90M+OFnW06PttRCipuVx9DkPHbBcO+szzuE7rejWLC37sDiEJs++PtVYks43zyM8R vEPZWew/IThzb9wr8O2gJvNlntfcRHeMLz0f11R87/2lp3HMvsXrYoq9MGKQYvcD9lC5 VFBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=asa7PA3ApN9uKyqznyP4okj+yLhWrazAhQHPOuL+PeQ=; fh=r5tnJ61Fi+7klI5mIpBtnH0VPqHJ0xbRyAaP05hNmSU=; b=whIhZncG+mmwocRxPcr7TmQtA1j2hhyHP/5fzm6XnJpnHEB6dDMtTQW/PYo1Q/i562 yk8AMF+n3iYKu/OVNDlaVQP6ZtiSb1RqkcRbWxeXB50aTpj4JiKN/5EWX2gdirUhaMKX 4dIx7KM8OYa/s8rS8PIsQey1Ptmq+uF4fdYiQsoR7rE7lhJDNOHYXY4LWUCog/56dA4O MSWqXw/4+OK89mC2/fqRXGHI+ynPIx50WK84DA1KzxwlY4jl4g5SQ9CnwCJxbJb4vsts ztuoXzrgBKrL5l3Tvesfa/j3Dh3A5+ryOYgOzOggkfKK2Gs+vs1pzGnJz6tdshjZgA5w z0pQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id b1-20020a056a00114100b006bd360e70edsi10822199pfm.103.2023.11.15.10.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 10:22:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B34EF8020C26; Wed, 15 Nov 2023 10:22:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232391AbjKOSWT (ORCPT + 99 others); Wed, 15 Nov 2023 13:22:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjKOSWS (ORCPT ); Wed, 15 Nov 2023 13:22:18 -0500 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C63C9C1; Wed, 15 Nov 2023 10:22:15 -0800 (PST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1cc3542e328so54182905ad.1; Wed, 15 Nov 2023 10:22:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700072535; x=1700677335; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=asa7PA3ApN9uKyqznyP4okj+yLhWrazAhQHPOuL+PeQ=; b=NyRVSUnMk4p6uWw3PszDvJNH0+pEBf3eRRDQVgNYCGiDm4EzsetnuyYk3L4iisWhvu UxXQHm4MQ2aOOzuScG7gY9ooGjbx1ft5wdn8i/ug/4wawhQKynE4RR8qcWURZ0XrcJVR tFZ+is6iJFgZi6keveOIkHsvCPO7wYoeB/e2BHSoWqqR+u8uYi9g/h0ygA2wexchrV2l 3Fpt+JOxomHb1tA6qY1QPCJaxRVosQfXQHG/l1bWskZkMXK/Ns2K55W589SbhsKN3RBn kt9mCGd5fqkRSSUqzStCQWa51c4gJOjQTXpQ9TLNp7b00sWnA4ToQyA6m64LATIpgyVO wZCQ== X-Gm-Message-State: AOJu0YypSPWuNSKnWAkv7YyAKDbtBxumlsX11AwTqTaBr6y9GC0f8Of5 K7fa/C9Xxe3S1Ifyo6j6+ML+SFKY1V0= X-Received: by 2002:a17:902:e892:b0:1c6:21b4:30bb with SMTP id w18-20020a170902e89200b001c621b430bbmr7417690plg.15.1700072535188; Wed, 15 Nov 2023 10:22:15 -0800 (PST) Received: from ?IPV6:2620:0:1000:8411:56f1:2160:3a2a:2645? ([2620:0:1000:8411:56f1:2160:3a2a:2645]) by smtp.gmail.com with ESMTPSA id a22-20020a170902b59600b001c9ab91d3d7sm7613787pls.37.2023.11.15.10.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Nov 2023 10:22:14 -0800 (PST) Message-ID: Date: Wed, 15 Nov 2023 10:22:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] scsi: ufs: core: fix racing issue during ufshcd_mcq_abort Content-Language: en-US To: hoyoung seo , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com, kwangwon.min@samsung.com, kwmad.kim@samsung.com, sh425.lee@samsung.com, sc.suh@samsung.com, quic_nguyenb@quicinc.com, cpgs@samsung.com, grant.jung@samsung.com, junwoo80.lee@samsung.com References: <20231114043704.52525-1-hy50.seo@samsung.com> <000001da1784$5c2520f0$146f62d0$@samsung.com> From: Bart Van Assche In-Reply-To: <000001da1784$5c2520f0$146f62d0$@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 10:22:29 -0800 (PST) On 11/14/23 21:27, hoyoung seo wrote: > The test_bit() function just check SCMD_STATE_COMPLETE bit state. > Do not set SCMD_STATE_COMPLETE field. > This function is also used in ufshcd_mcq_compl_pending_transfer() > to check the status of cmd. Right, I misread your patch. Can you please take a look at the following patch and verify whether it perhaps addresses the same issue that you want to address: https://lore.kernel.org/linux-scsi/20231115131024.15829-1-peter.wang@mediatek.com/ Thanks, Bart.