Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2862383rdb; Wed, 15 Nov 2023 12:49:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXG3SgEGXUWqJLHD7sW4ej56l/cPXI6yFjYVgtIksoiqWVZZU+M4l9263XXcgZa+J3S3b3 X-Received: by 2002:a05:6830:1042:b0:6ce:26e6:19fa with SMTP id b2-20020a056830104200b006ce26e619famr6386705otp.23.1700081372503; Wed, 15 Nov 2023 12:49:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700081372; cv=none; d=google.com; s=arc-20160816; b=wr55v2CfkspXDEQAbSwQZ0ziK/5nkwww8WoMBwANqFIZeNDLAM6n1HGctyR+LXCC1V aKlAEd4Cmo/WQM4ofXEJiF/iairiFT/+22FeyRpDZLi4XDJ0zGpVxnCWN/llWIXlGVA8 C3ygZwtgvNkcY4yynYzEBnOT784qS96mbteYOzbrTdwkgr/CGW/MdqSCJ0GyKGRJyJiS CdowdP3UXA9/H3NWKGi8s7d5kKrmkXDLJd0rMw9MRUz85GZ28sQY33SkHgT05uJlkgMz 6IMblneAUARJXwgOD7QrDX/zoOlucxpgouiQ7qFlCvVxmApNrJZoczvXd3O3Dji63PXj gO4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:ui-outboundreport:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=ypxpEu+E0kHcuilYibpyqAXw46fKdmZ7pidbQt42PLA=; fh=WC2FA1QC66nt4O0fBj9GvVacypqSKcLQ2EkP6LhemAY=; b=UvTthDZ8C33AO5U+Yv+Ut6po/nix0ZAw6QgEUG8TEjsRKdrBgCiNA/KVBFliUHBW00 mk4lV4x42QMW5lo+AuG6nCGj7+NGNgFUN2xW/RVO+A345k4Vbse+FTGehx4UJLSzDPcY Gt7hwEoFodZr3AFkT+zDCuD7x2e8PJNYFrk9cwrGCJIB/623YCh1Z/RxFD5fxtmAQ9Bj HIML4kYTJTBcqzJ+SSqACsqaWk+MgdCx/rlcNmefs0RNANHhN+U1IJlai+2I43PUbQ/m 7YAJP0b9G0XsKIxVPhfnlDpSnNDnR+KszNp5h+L7DZpHt0ILvy/9OBNQ5qcMa0us4U3f Gndw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=s31663417 header.b=GYTPwPsR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmx.net Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x3-20020a636303000000b005ac4854b202si10677428pgb.321.2023.11.15.12.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 12:49:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=s31663417 header.b=GYTPwPsR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmx.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 566618029240; Wed, 15 Nov 2023 12:49:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233816AbjKOUt1 (ORCPT + 99 others); Wed, 15 Nov 2023 15:49:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233836AbjKOUtZ (ORCPT ); Wed, 15 Nov 2023 15:49:25 -0500 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4BE9130; Wed, 15 Nov 2023 12:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1700081333; x=1700686133; i=wahrenst@gmx.net; bh=ypxpEu+E0kHcuilYibpyqAXw46fKdmZ7pidbQt42PLA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=GYTPwPsRzyIlkC2jwDNYvQU+r3re+zQNPL9Mr/6w5tM4cJpbh4wt5ruhnTe5gVXL jkIRXdEhD279b37EnSICbKoSa4ZLGtI0K59zyA7at+H/lfQuPff3Y5qJF3R1nhvti lklT+1K/yldj2aKGQqO4tixYxs+telr9jJYwULcPpW6CXhMotDCLsi7k2qVywwxF2 e8Kx6Pi1uIj7bi3ynZyqufKSmhP6tchkkox8D+CtZ2YUKb0y6DMuyubg3uAhOC4KX yEd52PA+KsP7ZFUSRZoakMQM+MBNp70TqWmZByyrg04dsTXIP4J594FStCobS2Wss 2GaGKMi4p7gh0i/YEQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.129] ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MryTF-1rfhpJ3j8f-00nxJm; Wed, 15 Nov 2023 21:48:52 +0100 Message-ID: <812a82ee-c6e0-428e-9d21-b57d0c9d4839@gmx.net> Date: Wed, 15 Nov 2023 21:48:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/15] staging: vc04_services: Add new vc-sm-cma driver Content-Language: en-US To: Laurent Pinchart Cc: Umang Jain , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Dave Stevenson , Kieran Bingham , "Ricardo B . Marliere" , Dan Carpenter References: <20231109210309.638594-1-umang.jain@ideasonboard.com> <20231109210309.638594-2-umang.jain@ideasonboard.com> <5263ecbd-23af-4889-a7e0-b21aaf8bcfe0@i2se.com> <20231115195634.GC29486@pendragon.ideasonboard.com> From: Stefan Wahren In-Reply-To: <20231115195634.GC29486@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:qfn2JqbcbXXz7QP2FBfkhvhE3sTXpDE0e1uocwB3Xdsy21qJILC R/WbX3sNZHy6jysJ1Ba1owiBwBSTJ8Uy+VbaR2PhMGnYV3MMMrBhH90wFGiQxIDWJkKvtiv I7D3upHna7OxYLVpk1Or/920FkgWqPiXcMKASebv5hNSFrZBcFsatqRXYTljuCSnRr2nTY4 vhfeGtI/SoSgPT1itQrcA== UI-OutboundReport: notjunk:1;M01:P0:Lw6HBv/MQnM=;6fP67iXH68jiNribR9eADNMm1g4 XXSsST18gbpE9Sr6OFFv/yBsH9zIby9U00WBOWCB5vO73ZD+HFZ29T9O2soAqy/PoXusiq7ZW d7vSNTxl/NEckM3oLE8o1+KGKUi7gLJE8fN+vr5CqI0QHJecYZlonUcifftPozBTrMohkMAwn 0GSqErJdomVHD7/OUEq+Z12eVHz/saVimLqz2/OF2yHX//vrtdHWSKzg2cnYtxmgq33xR6ELX Ysa5xnN03TWFDrSaszoGcXvwyTJFzLUNIKrlkY+abr5G0J/uUp5DjnB6oLDhTWt2DfIG8esSc i+7JoY8x1yoTKBXdQJEbaplN/suncgvpe9SZNzI00fhe9r/363xP9Lfib0HBKJUvRPtI0Fg2s Ly5LPMbkFKfz4Ie4lUADQR8nhjIcm7CdW2VEw1fQzP+KdXhqpEHf8NZiCNp9gL3Enme5hcLvy HnzE2JBPmnof56q3AQ/WDU8ahw/SwQMY0gd6or/XP0pcsknk3md2Kq+IyNzhuH2t4VDuArW/b wGd/r4vPOvia6Z0yJXoBfBuTuMeWp4qCDojjUjY2mu4HegeAcqlqSeWlspOR6/1YSVJo1rG67 Ntn0rwQSSB0ucQUxBU6YVy5qmwlM5owFMNF6O08hmb3h0lFzLE5EQ4kPyE6U8PZgyNZKrZTsC ysPGqdDXLpNgdApWXpz0V8YKZc3Rm9O+lfTbIJ9LtSW4PdZDuljGBynLTPF5dQUsSEDJDPMgj 3o6V0bdI+/2gxzAIBvDHzzURySSfyDMuCriKuWKk1r3Mp/nvLcpa48h4C4WO0YlJkAgmsIQRE RnefuDPDhYZId11MyHSI22jkTsBIhVRN+DqYFM8UgdpJ5RjrIsPvbS5JxRS0btmhMixrUHhMg nrgTEV+tnqi/MwoiFObpYk0Wy4JJBd4/MSX47JM3v7xBo9DCf+K87LLGTk0dPbkRTTAykNet0 1Pz4/KaxhTm0vN4K7Q+RN3EwJRA= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 12:49:31 -0800 (PST) > >>> +/* ---- Private Variables -------------------------------------------= ---- */ >>> + >>> +static struct sm_state_t *sm_state; >>> +static int sm_inited; >> >> In case the driver cannot be loaded again, a comment about this should >> be here. > > Better, could we remove global variables ? Yes > > [snip] >