Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2864583rdb; Wed, 15 Nov 2023 12:55:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhpnnCoqUKqRECrYedsKcY6lrfKH8wyPp1vtTswBaUgfTJXDTAJLjg2ki9+CeAf3jUJW2z X-Received: by 2002:a17:902:bcc9:b0:1cc:49e7:ee1b with SMTP id o9-20020a170902bcc900b001cc49e7ee1bmr7068707pls.58.1700081710988; Wed, 15 Nov 2023 12:55:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700081710; cv=none; d=google.com; s=arc-20160816; b=BTR3czFg5CVqIqAhstkcZ0ZPoOqyAlF3kOF1TtjRsXBvC3t1+xAs1R7xQqhKUS6+tB WXMJsI82lWOF53js10eFCk7Wvy6fJLmxrvJHbF4sLO6eZqJkX2F6Tm9o/jCMzYXXMJyO JOyhwcFLIwe2lSKTj9ZIWt5lUNS5JljBHXHWnbt5Hj3UN5D2zJy18LX3FdvzdzeRFSVn +pq20RiVPima65ZCDY5HWt3IVnt9ow2KbPesgGGzeDC+s4QWlMvrx0FRSdY33VBM6UQ/ fTkhxBCmxhKe4yePqdKiwImQQKgETPklySxnK3xUbLxR8Mz1WDs4Y+8wCFaxYNLjF+64 jxDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=lf3afFfr3pZyX+7ng+p3z/nuL2CxfqDG1NRhZ+cwXcE=; fh=1ApY23abzE3rJwL7HrJawLsYI88Hw4VmQiFv2S5lcA8=; b=bGeTHiRj/FHdDTmoxKVijebRfhMMCkkFBDwf9QPrN4JIOKFV0SIonDx+itpE+C5+en ROZzD5WERHLANfhch/k/u3cyPgLdrbyaIxiiD90dRkUAdblRyGqZmr0ftOoBEA6ogjuG aNSxXIEkkgWtNLb9UWETRKY1CWNLD0mp3BQdev3ZS2ykHlH4X5nzDaBK6qIy0YoBei86 JSdLv6TCvIoqH/5eu4CgFGdCypCK1io+cSeim8QT0BoOyT6syfltB3sfGgmpy2SKVvMH cYsYFAJgvutSKr0SMh3xwxKjGTuro4m4VtcNTTMhB8AtI9RAUYNFRvWPjugvNIrTljJ1 +4Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ep+bsKlp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id t1-20020a170902bc4100b001c3fa95ca03si10385597plz.9.2023.11.15.12.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 12:55:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Ep+bsKlp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 5D2EB80B31C7; Wed, 15 Nov 2023 12:49:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233766AbjKOUtQ (ORCPT + 99 others); Wed, 15 Nov 2023 15:49:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbjKOUtO (ORCPT ); Wed, 15 Nov 2023 15:49:14 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9B8A1 for ; Wed, 15 Nov 2023 12:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700081351; x=1731617351; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=AYcAGKAKHUgxmtinYq3mqAusIIDiI0x6Mq0zoXBAcJI=; b=Ep+bsKlpMhU8Jr35yW7nwZhbw4/gbAm5dXl5ad70WH7MEUM8+g8TlxW0 SNfJe4lVG2if/GqO0bMrKNhDutLF1R0Mc9BF5gWUO3mi5gKVfDYk3q80A UnvcyQi4NArs2Ahuxy+Hdlm/kaV1eFLuZDx45qMbfVB3HL7GW0xBJOSij sr8kTqVj1wVF78c9b1MR4ayi+W+0x7j5r8DHWnsdOmnJd0hq+6rUP9i+C gLJ+4teFb39SdZNF2mO+FlCzW/1Ni+0DmrFE81bXbzRY2dvPan/HeR0An iJb6coIjYwDPWH6NpuKnPo5jYEAp12MeXY/etCkz1B7ilibnVitnyo88P g==; X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="370302354" X-IronPort-AV: E=Sophos;i="6.03,306,1694761200"; d="scan'208";a="370302354" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 12:49:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10895"; a="1096554600" X-IronPort-AV: E=Sophos;i="6.03,306,1694761200"; d="scan'208";a="1096554600" Received: from ythomas-mobl.amr.corp.intel.com (HELO [10.212.206.200]) ([10.212.206.200]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 12:49:04 -0800 Message-ID: Date: Wed, 15 Nov 2023 12:48:58 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86: Ensure input to pfn_to_kaddr() is treated as a 64-bit type Content-Language: en-US To: Michael Roth , x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tom Lendacky , Joerg Roedel , linux-kernel@vger.kernel.org References: <20231115201431.820278-1-michael.roth@amd.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20231115201431.820278-1-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 15 Nov 2023 12:49:33 -0800 (PST) On 11/15/23 12:14, Michael Roth wrote: > While it might be argued that the issue is on the caller side, other > archs/macros have taken similar approaches to deal with instances like > this, such as commit e48866647b48 ("ARM: 8396/1: use phys_addr_t in > pfn_to_kaddr()"). Gah, I really hope nobody is arguing that for real, or is even thinking about this as a valid argument. The helper should, well, help the caller. It makes zero sense to me that every single call site would need to know if the argument's type was big enough to hold the _return_ value. This nonsense can only even happen with macros. Type promotion would just do the right thing for any sanely declared actual helper function.