Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2871340rdb; Wed, 15 Nov 2023 13:06:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJK9MRVv6kyEgf9XCEhlsJG9tkOVGIYTh4AlU1h3MygfHL7UPCtc8yr1DvW20gc7VN9osO X-Received: by 2002:a05:6a21:7182:b0:187:9f15:bfd1 with SMTP id wq2-20020a056a21718200b001879f15bfd1mr1185482pzb.38.1700082413137; Wed, 15 Nov 2023 13:06:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700082413; cv=none; d=google.com; s=arc-20160816; b=MWci9N3XJXiid7KFDPG4ukndvWx3WS9y7D7A3gjX3pJZ5oJXkpvZ/c1h6MaojeJOiW HSGdRcUB8/eXqIa2Tag2uwIUYUBj44Nd5i80TYuoFFypnZMghqyZjZC2jKgcbHgYX8Yi YpwoSripVTRuM2SggawNrJ58Kl8F6s/iatqrfMFbVBEx8yCuXAbVJWeR9HyiDRzhg8Oz 7mcgxyyN0h4GlBbJ/oerQzVmVxiHXA7srTA/iHq0K1RF8ecgoI6a2gKhKFpVBEkRofEH VY0TKzZodstiFE4Tj64WGrOFPy7mYxuYJ6EG273qtWAvcjlefZliGYKda8pu//8YQkxQ LxbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TILtTIeu3gXnUdrdAENWa1V+qtf2djaxseto/GpIGiU=; fh=hbopeTiG/AFpDYL0DqTnP5D2crtv3xbSEUvuPydpCdQ=; b=usUA9mAbnyJtcWZSEjEbGR4ZofTOoOiulrBIe3Pnde8FfZUDTNUuQRZYlHtMb7NKg8 E7mP3G6AbfqGOANDLhf67X64iYK93z4tXfG9Vn12mijNJ368x7Kh8O79kZ7Wro6UJydy 58ycZcL5Sg4MWGDmJTv53gs4SUTgyaB0h17zrSLRAtex0sQUV4hy3Chxh6HpW35G1CIO EsynRaibGKVsA3VlKy+n6GDQK1hVlkRBUSxMVZa7x1bgAAylJ5B84g/zCDbKHlgbVTT9 8UXjrO0ygga9oxR7x0e+oD6HmUuV7MCHNHvOyFSnbg4e5Xcl3SHt+f4NFcxx6ML25E97 nbKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LJzD51DF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id q18-20020a63e952000000b005b95f5f8976si10614298pgj.634.2023.11.15.13.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 13:06:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LJzD51DF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 108FA804C1B3; Wed, 15 Nov 2023 13:06:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345002AbjKOVF5 (ORCPT + 99 others); Wed, 15 Nov 2023 16:05:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235597AbjKOVFd (ORCPT ); Wed, 15 Nov 2023 16:05:33 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E5E91BFF for ; Wed, 15 Nov 2023 13:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700082323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TILtTIeu3gXnUdrdAENWa1V+qtf2djaxseto/GpIGiU=; b=LJzD51DFRJEUxMRRx0Ed/letfIyQuyDy/MFmupEIRIAlvbN7xX2K2SX+usOlq52yFa7LWw Hox4D0GFwc4uOT4if01DCuSbV5zv7hUMOLUSPT27IV/wYWMk17iahmNosWH2ysP9cVtIwR P9qdiF/1CPS2Rr/lUPAl+qJDAgCBpLQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-F0EMJrXzPk-lvIhyom_TEw-1; Wed, 15 Nov 2023 16:05:19 -0500 X-MC-Unique: F0EMJrXzPk-lvIhyom_TEw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0074382A62C; Wed, 15 Nov 2023 21:05:19 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.22.34.128]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 232ED3D6; Wed, 15 Nov 2023 21:05:18 +0000 (UTC) From: Valentin Schneider To: dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Ahern , Juri Lelli , Tomas Glozar , Sebastian Andrzej Siewior , Thomas Gleixner Subject: [PATCH v2 0/2] tcp/dcpp: tw_timer tweaks for nohz_full and PREEMPT_RT Date: Wed, 15 Nov 2023 16:05:07 -0500 Message-ID: <20231115210509.481514-1-vschneid@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 13:06:10 -0800 (PST) Hi, This is v2 of [1] where the tw_timer is un-pinned to get rid of interferences in isolated CPUs setups. Patch 1 is pretty much the same as v1, just got an extra comment in inet_twsk_deschedule_put() to highlight the race. Patch 2 was added as AFAICT the bh_disable is no longer needed after patch 1, and Sebastian mentioned during LPC the he had been looking at getting rid of it for removing softirq_ctrl.lock in PREEMPT_RT. Eric mentionned rsk_timer needs looking into, but I haven't had the time to do that. It doesn't show up in our testing, which might be due to its relatively low timeout (IIUC 3s). [1]: https://lore.kernel.org/all/20231016125934.1970789-1-vschneid@redhat.com/ Valentin Schneider (2): tcp/dcpp: Un-pin tw_timer tcp/dcpp: Don't disable bh around timewait_sock initialization net/dccp/minisocks.c | 14 ++++---------- net/ipv4/inet_timewait_sock.c | 20 +++++++++++++++----- net/ipv4/tcp_minisocks.c | 14 ++++---------- 3 files changed, 23 insertions(+), 25 deletions(-) -- 2.41.0