Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231114014313.67232-1-v-songbaohua@oppo.com> <d8fd421e-00f3-453e-9665-df3fdcc239eb@redhat.com>
 <CAGsJ_4wD9Ug=CLi6Cdw3Ve5q8-1u7MmipLtEGQTfWmU9BJFJOQ@mail.gmail.com>
In-Reply-To: <CAGsJ_4wD9Ug=CLi6Cdw3Ve5q8-1u7MmipLtEGQTfWmU9BJFJOQ@mail.gmail.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Wed, 15 Nov 2023 14:45:42 -0800
Message-ID: <CAHbLzkoNAFGikx-pRwTVr2Bf5mvv8Xb8c6oWV5t4JZ4m0KAurA@mail.gmail.com>
Subject: Re: [RFC V3 PATCH] arm64: mm: swap: save and restore mte tags for
 large folios
To:     Barry Song <21cnbao@gmail.com>
Cc:     David Hildenbrand <david@redhat.com>, steven.price@arm.com,
        akpm@linux-foundation.org, ryan.roberts@arm.com,
        catalin.marinas@arm.com, will@kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com,
        v-songbaohua@oppo.com, wangkefeng.wang@huawei.com,
        willy@infradead.org, xiang@kernel.org, ying.huang@intel.com,
        yuzhao@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 15, 2023 at 12:49=E2=80=AFPM Barry Song <21cnbao@gmail.com> wro=
te:
>
> On Wed, Nov 15, 2023 at 11:16=E2=80=AFPM David Hildenbrand <david@redhat.=
com> wrote:
> >
> > On 14.11.23 02:43, Barry Song wrote:
> > > This patch makes MTE tags saving and restoring support large folios,
> > > then we don't need to split them into base pages for swapping out
> > > on ARM64 SoCs with MTE.
> > >
> > > arch_prepare_to_swap() should take folio rather than page as paramete=
r
> > > because we support THP swap-out as a whole.
> > >
> > > Meanwhile, arch_swap_restore() should use page parameter rather than
> > > folio as swap-in always works at the granularity of base pages right
> > > now.
> >
> > ... but then we always have order-0 folios and can pass a folio, or wha=
t
> > am I missing?
>
> Hi David,
> you missed the discussion here:
>
> https://lore.kernel.org/lkml/CAGsJ_4yXjex8txgEGt7+WMKp4uDQTn-fR06ijv4Ac68=
MkhjMDw@mail.gmail.com/
> https://lore.kernel.org/lkml/CAGsJ_4xmBAcApyK8NgVQeX_Znp5e8D4fbbhGguOkNzm=
h1Veocg@mail.gmail.com/
>
> >
> > >
> > > arch_thp_swp_supported() is dropped since ARM64 MTE was the only one
> > > who needed it.
> >
> > Can we do that separately?
>
> i think it is ok.

IMHO keeping it in this patch makes more sense. IIRC removing
arch_thp_swp_supported() is just because this patch made swapping
large folio with MTE more efficiently.

>
> >
> > --
> > Cheers,
> >
> > David / dhildenb
> >
>
> Thanks
> Barry