Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp2947044rdb; Wed, 15 Nov 2023 15:58:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHM/9Prwc/ZH33Ss+eAio0oxghgIE2CJ6KM9lT5R8Jsq/Cwfp7pGgCTRubrU9nSxPxt7XOO X-Received: by 2002:a05:6a21:99a2:b0:186:6fb8:4067 with SMTP id ve34-20020a056a2199a200b001866fb84067mr14277518pzb.55.1700092684361; Wed, 15 Nov 2023 15:58:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700092684; cv=none; d=google.com; s=arc-20160816; b=kXOkp9u1WIGHDQrw6YuZGIQOiYbSzjmP8j7xJjNY7q2bT93hVqpBIzMHsBt+iGgsIz ao4H9MWpWOEr5PXqNtZ4W0fquh5vIARh4iD+LJ+T1LcXgTi+Joy4w9kR+22MVWxb/IFa 24hAdPbRMuNGbKkrDpiKIXYUD6IXF3NanzBIYORelYdBOUjHyZfBOtd19YwM6E87C7Dt NyR3z5FV3CBx72L2qeCHk2RaV2NyfsTnMpxlsNsoOURLjVk1ZYgnj6gVPD1ojlEzYDMH 75FQmb2fgXsR8oqfvB/2ky/RFYN5Ms3lqpXrjLaWxW1HlXMvBs9H2P0b6cPls9Rf4/2L m1dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DNz1LZLWLqztNC1mkWelul3LmT7uMEIxjhxqq8dOWJk=; fh=PenYQja8fSc0Xook5jSMHfMR8aOh66vqTE96y1EmhO4=; b=GdFKcdGDqfrYyf8C90Zk5qTgQcr1LSpjPdu3e3/X+IvnNtx1vDvblGA2wkQE16wCKS e/v/sPIAgJ989sLe5ySLXy3+/pGBDIIs1IbQEdthGs8RwsWK5aCKx67yHY1vrCgsdULZ oC+V1uEt0gFnhV73uHk7bZo+pCz4BHptLRzZjZRthafGSufddQAw0b+UR29GuIHIXvNS erIN6ArvGhfZrVKur7cQ2YhlW8Vf7WryHEoB/KlzdEUxReLEk71OGyELYpQVOcKJvnVD mnmV9JFzw+JboME017FjAHPs9yPnEE20jneL33OgmRAq1qKck+iblhhWJIIfGHcxiFCC 92vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20230601.gappssmtp.com header.s=20230601 header.b=E3Am9kHr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id q12-20020a17090a2dcc00b002568a675b65si741611pjm.141.2023.11.15.15.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 15:58:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20230601.gappssmtp.com header.s=20230601 header.b=E3Am9kHr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=networkplumber.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 74754802E83F; Wed, 15 Nov 2023 15:58:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbjKOXxF (ORCPT + 99 others); Wed, 15 Nov 2023 18:53:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbjKOXxE (ORCPT ); Wed, 15 Nov 2023 18:53:04 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252A8E6 for ; Wed, 15 Nov 2023 15:53:01 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1cc921a4632so2383815ad.1 for ; Wed, 15 Nov 2023 15:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1700092380; x=1700697180; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DNz1LZLWLqztNC1mkWelul3LmT7uMEIxjhxqq8dOWJk=; b=E3Am9kHrzGiKvuQ7Wd3p1RtKWgvVBsR+Hwym+gYpCIu1YzMG6e2EEDY7D97fEWMe09 xieMnX9zRJuZ5cfKNmtKGSjJRQjVeDwjntPuBLtHAsxeucEELoD57FBXzD5QXgq02q+5 FxdQ99Ik8qW7DtUz3WqOsHOOS0kOka5F+vBXD392JG+jYsC+FLMfZZylaH99OLbw4Odu L4TcFcqH/JF/GXMfaapgLL8e4+1C2y9dnXvc1G8+ydcIP6b2UXT5qfOYS48fy3RwUdRR 8ue7LgHqswrHw+e9Kj8VPLFhxrWIOtj/tP6qFh+7jNFBKGHUN2p0wHUIHaN7oHqsj21H 0hHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700092380; x=1700697180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DNz1LZLWLqztNC1mkWelul3LmT7uMEIxjhxqq8dOWJk=; b=Gz/3xxJ1zA7PaRbHRh7NqxO1SeVvQhqFr1bJcM+D41IjfX4MoBy+CVDogCRgLyc1kP 5qMx8exkREl5fIuJZFOj0A8QrVrAvC+nxHfzxQ9TSzACwpJk9cLgsKPzaoUiwRHbIrH7 B7kYOvf5tiy/07eKFc3HLAuKSoK0gOdmIX8sHx+ePpFua44IxcQDwwvhz8Q2bxXu+lnx NIU12gSBwYVL1S/jG15HrlOT3orzDXqtrCdQxpXR1Go8/Usf1NY75Zgof/ql3wwoll/z w5LbWubeTX4uPG8vE2wKgefpontDGL/18omY73BYX5RxlxkMPZ0Gb18U18VV3/NakHl3 jVOw== X-Gm-Message-State: AOJu0Yy3Pe/oJ89J0tDmAE0kOLZx/1lslRxUzWdmUoMeusCU4MdlnSoD 7DBfIUsa5I7Oa2bS6jGKSZclyg== X-Received: by 2002:a17:903:2341:b0:1c7:5f03:8562 with SMTP id c1-20020a170903234100b001c75f038562mr9891201plh.30.1700092380545; Wed, 15 Nov 2023 15:53:00 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y12-20020a170902ed4c00b001c9ba6c7287sm7923702plb.143.2023.11.15.15.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 15:53:00 -0800 (PST) Date: Wed, 15 Nov 2023 15:52:58 -0800 From: Stephen Hemminger To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, kys@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, linux-kernel@vger.kernel.org, Long Li , stable@vger.kernel.org Subject: Re: [PATCH net,v4, 3/3] hv_netvsc: Mark VF as slave before exposing it to user-mode Message-ID: <20231115155258.5b3f360b@hermes.local> In-Reply-To: <1699627140-28003-4-git-send-email-haiyangz@microsoft.com> References: <1699627140-28003-1-git-send-email-haiyangz@microsoft.com> <1699627140-28003-4-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 15:58:01 -0800 (PST) On Fri, 10 Nov 2023 06:39:00 -0800 Haiyang Zhang wrote: > +static int netvsc_prepare_slave(struct net_device *vf_netdev) It would be good to not introduce another instance of non-inclusive naming in network code. Please think of a better term. Can't change IFF_SLAVE but the rest could change.