Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   "hoyoung seo" <hy50.seo@samsung.com>
To:     "'Bart Van Assche'" <bvanassche@acm.org>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <beanhuo@micron.com>, <kwangwon.min@samsung.com>,
        <kwmad.kim@samsung.com>, <sh425.lee@samsung.com>,
        <sc.suh@samsung.com>, <quic_nguyenb@quicinc.com>,
        <cpgs@samsung.com>, <grant.jung@samsung.com>,
        <junwoo80.lee@samsung.com>
In-Reply-To: <e9745815-afc0-46c6-828b-c969a2d352eb@acm.org>
Subject: RE: [PATCH v2] scsi: ufs: core: fix racing issue during
 ufshcd_mcq_abort
Date:   Thu, 16 Nov 2023 10:56:18 +0900
Message-ID: <00a901da1830$16ff2e10$44fd8a30$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLYbO3h/Z18bVSq8KBPFnY/ewa5qgDl2w4PAbQq5PoB4bZfOgGN9AJOrk8xZ4A=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20231114043431epcas2p4a8d452e18fff192c03fb6066e81514ea@epcas2p4.samsung.com>
        <20231114043704.52525-1-hy50.seo@samsung.com>
        <dca06fd3-d4ad-4e41-a0a3-61d52c85ef9c@acm.org>
        <000001da1784$5c2520f0$146f62d0$@samsung.com>
        <e9745815-afc0-46c6-828b-c969a2d352eb@acm.org>
Precedence: bulk

> -----Original Message-----
> From: Bart Van Assche <bvanassche=40acm.org>
> Sent: Thursday, November 16, 2023 3:22 AM
> To: hoyoung seo <hy50.seo=40samsung.com>; linux-scsi=40vger.kernel.org; l=
inux-
> kernel=40vger.kernel.org; alim.akhtar=40samsung.com; avri.altman=40wdc.co=
m;
> jejb=40linux.ibm.com; martin.petersen=40oracle.com; beanhuo=40micron.com;
> kwangwon.min=40samsung.com; kwmad.kim=40samsung.com; sh425.lee=40samsung.=
com;
> sc.suh=40samsung.com; quic_nguyenb=40quicinc.com; cpgs=40samsung.com;
> grant.jung=40samsung.com; junwoo80.lee=40samsung.com
> Subject: Re: =5BPATCH v2=5D scsi: ufs: core: fix racing issue during
> ufshcd_mcq_abort
>=20
> On 11/14/23 21:27, hoyoung seo wrote:
> > The test_bit() function just check SCMD_STATE_COMPLETE bit state.
> > Do not set SCMD_STATE_COMPLETE field.
> > This function is also used in ufshcd_mcq_compl_pending_transfer()
> > to check the status of cmd.
>=20
> Right, I misread your patch. Can you please take a look at the following
> patch and verify whether it perhaps addresses the same issue that you wan=
t
> to address: https://lore.kernel.org/linux-scsi/20231115131024.15829-1-
> peter.wang=40mediatek.com/
>=20
> Thanks,
>=20
> Bart.

Hi, Bart.

It seem that not same issue.
That problem is that the try_to_abort_task() function has already been=20
processed.
So clear_cmd() has been processed.

However, this issue was already completed IO request before executing clear=
_cmd().
So can't get utag to clean up sq.
This patch to prevent access to utag for cmd that has already been complete=
d.

Thanks
Seo.