Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/4] iommu/vt-d: Introduce dev_to_iommu()
Thread-Topic: [PATCH 1/4] iommu/vt-d: Introduce dev_to_iommu()
Thread-Index: AQHaGC/xpSvEePKn7k6kCnwzLYTTGrB8RhyQ
Date:   Thu, 16 Nov 2023 03:19:13 +0000
Message-ID: <BN9PR11MB5276CF0833BF362C1BE5F2268CB0A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231116015048.29675-1-baolu.lu@linux.intel.com>
 <20231116015048.29675-2-baolu.lu@linux.intel.com>
In-Reply-To: <20231116015048.29675-2-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nK3nG/8quXUHF2gVUTUYX0TItC71KnuAACn8jYhg17i/f21eQJOSrQfy2FM/?=
 =?us-ascii?Q?cdN3m34lpEZSThYTiGhFxgd1PRdnh1tDvDwpO4UcOTLh6tYDcafNRiKtxzbt?=
 =?us-ascii?Q?Yej84UoCt9/w+xVJSCcGnT3iNaOj/cZTFuUqVaf8ANlcjx76sZE2xKlkouDe?=
 =?us-ascii?Q?k1LhgorFxjfA++dmq2NNia33rcowu86klCBKeuZapTt5NkjNo7+QbXwtUkSq?=
 =?us-ascii?Q?WL9eKGmUwP6EIvmk6ILVyq3AJTOOQMpzH/HJCbZM3GxzV9la2MVSSS+am5VO?=
 =?us-ascii?Q?sZ/t1e8PupQssfrwJsrvcPPQ1C7kR7+45ewac0hgmdRRCjr4JFK5pPmLx46p?=
 =?us-ascii?Q?UUzmbJrJEJk31CPpgDjEjeKYPVwm+tqyFK/Ru7TZRFAezAXg6aX2cw6NYbtk?=
 =?us-ascii?Q?w5sTPBTq06YhLmTQ74NqAUaXcrJBaV+65+XYrc3JTPs6zELBe5hIP2nKhcEP?=
 =?us-ascii?Q?BzgnAaa4BXGbP5Z6BwYFzEzT7qNCB8Ony6fPLSfVh818mUQc7+uB/WOoWCWh?=
 =?us-ascii?Q?pbIw1gs6p8sUDzYPTerNshji7vhr9VU1YDJ8LN9F004T9jeMlQ0dcVCos/D0?=
 =?us-ascii?Q?ML6af743Xm+lpwBhw8OBPta6dWbauMQ6baBqJ4ISpLyAqQ2VcqIUs5VurJcX?=
 =?us-ascii?Q?5oJk+zYSdbI3ib4yyNP3xUktiByulk4xEWgFoskZlKqTvk3JWy2U8+2hgVpT?=
 =?us-ascii?Q?NNhoOewlsHXhmDTowY6sbtgq1orxhQpGpt9VAkKgq6tlrHxwa/2jcHerD8NO?=
 =?us-ascii?Q?bnbUUJn33mHFvBVBfJRyu1rmY4O6ZgTDMLrUNCURhvEq7e2e6qiv3IV/0YjB?=
 =?us-ascii?Q?DRUQD2Qtn2IrY3Azo3bqMwIQwsztTJf3okTmqmctlqaTc1em+uxPTNOVIX17?=
 =?us-ascii?Q?7Ob6ROtRYv3RNYVzMCbkf20f9k8jSs++6XMwN/pq6C68hJ9CriPtldCs8VMQ?=
 =?us-ascii?Q?5+FDqOFy0UbzfP9ibeBMqPBR1PK0yDQfeJNtK2PDN/kyAvt4dg7q8zdMpokn?=
 =?us-ascii?Q?Oh6FCZnzHWM5snxunM8ksD459kS1+FA3tTypvmzd23eWq6LZ+EzhJokUyGZu?=
 =?us-ascii?Q?faZ9vk6S+hWDB7muEyglonxLUPwuUELacp3dgxgk0/+c3X2p1ERSkmVOnroA?=
 =?us-ascii?Q?6D7EkBTt8ydi8B8G1Cd8ha89wO9BfsGlQ823i6qe7VrlCZ+nWry71+IGKUY1?=
 =?us-ascii?Q?Gvg359sqAZrO0c+pFUorqfxbZ2IZESP6hlKFm8DO8CNBJh2POr258WJmO+xZ?=
 =?us-ascii?Q?FE6g6eKa/IfAYF11dezDjYhpUbyqE4kgJl/v1REBzr6L55Uvk9+H6pGqTiqa?=
 =?us-ascii?Q?RNha+Pdv2lzTMebi00o1/T1ZgJVO0zUqSX0s6y7I3Ps56ThGfEr1MAZ/FNv1?=
 =?us-ascii?Q?M62xMXP+TxWej5I0ZO73JYQS+gdWNBVm8OthIabKDgLFRViXX4T3FrgtfLDg?=
 =?us-ascii?Q?3+ibiczU5FD2pb7j70CS4uYEHe33226k17GRD7OwCNF9T4nDuNz9PtalwD8X?=
 =?us-ascii?Q?kqcspLwxg0dMxUGazkjFASv7m6KUyij4aP4CY1hvWDoFOFnCGbRbKkNuf15A?=
 =?us-ascii?Q?unN0WMufi2Rsi9aRHfstjgLLQ+PshL5IrGYRqvtF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a92df774-b5e6-4311-ce04-08dbe652cee8
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 03:19:13.5561
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: u/v2S12r+zZ92FwZS8FoNLGqfbZD3fw7508SL5NUk4n6wePEOjlr3zfrL4gdLiuoVaEfFJA7dp3QaK0l5QJDhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7193
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 15 Nov 2023 19:19:33 -0800 (PST)

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Thursday, November 16, 2023 9:51 AM
>=20
> +static inline struct intel_iommu *dev_to_iommu(struct device *dev)
> +{
> +	/*
> +	 * Assume that valid per-device iommu structure must be installed
> +	 * if iommu_probe_device() has succeeded. This helper could only
> +	 * be used after device is probed.
> +	 */
> +	return ((struct device_domain_info *)dev_iommu_priv_get(dev))-
> >iommu;
> +}

Not sure whether this helper is useful. This is only used by 2 out of 5
post-probe users. Probably just open-coding in all 5 places is clearer.