Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] iommu/vt-d: Remove unused vcmd interfaces
Thread-Topic: [PATCH 3/4] iommu/vt-d: Remove unused vcmd interfaces
Thread-Index: AQHaGC/1kmvq40BVaUe2vwsfc5oS4LB8RxFQ
Date:   Thu, 16 Nov 2023 03:21:21 +0000
Message-ID: <BN9PR11MB52762063ED9337AD624E62148CB0A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231116015048.29675-1-baolu.lu@linux.intel.com>
 <20231116015048.29675-4-baolu.lu@linux.intel.com>
In-Reply-To: <20231116015048.29675-4-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eqX3bDxweVgpoQmMCsmvNyNFOUz4cduQZOjfksX1xyQT7H8Z6+3ZUG2tGHtc?=
 =?us-ascii?Q?NM635NX25NAsdxypZo1v4zUiXHoJ7DdjfdzqK4UnJaRgO8F9c6OhhnbFoqIC?=
 =?us-ascii?Q?E4K94LlfHbAW3DVPa+TO2r2aPeY0s38gDHW+Xx5pt4Umdc2s9cUkKpUSJHs7?=
 =?us-ascii?Q?pIcSpxmuH0jUgzPwoDz0jyFLB1X+MhIqxY57s1GtqruT1JpwfLE/X++wcQ5U?=
 =?us-ascii?Q?5oSoZVZxPr2ztqxYzc4AR4KdXrRGOYk6SYd8pETm8ND0UNjigSOQkhBnRBGQ?=
 =?us-ascii?Q?lBN8wXlNCMFj82IprfvafZC3bt0k1HUJp8/ierpKui66bXToul9UAPUl5IZn?=
 =?us-ascii?Q?wr0vjnVGZq4VaI9AMKdVj6QM3wgYQqEjvoTxPQ8DaUrWA+4ck+sSUGnIjq0N?=
 =?us-ascii?Q?DtFDSytOGGrZSs9yldLjJslkCM/zujcBnZQflJpHSo6OWwOGvziW85MTtCSF?=
 =?us-ascii?Q?VHcwYmPrufE62CuBzzN9dsrnwluuobjlL7BFdTTAZJUhvGyAMVKhL9HqZXl7?=
 =?us-ascii?Q?I9t2dQpf3G7D+Vp7Mcoe9+DPiP9PVhrDohC+g4ZQKeftuPuA8UFkMPUsFylx?=
 =?us-ascii?Q?D7ymcWQPHCW6xSx73mFZ9mUvkQhvid3CHshjE0wD9x63LOWZbcqqM0EWVHlF?=
 =?us-ascii?Q?2r+Tn1bznlovGitkw5Bnr7lSRkHN5tmveZrHb1qd8tvf4WRoZDtjb2n9zfPu?=
 =?us-ascii?Q?RjflkRxuKySd4LRexHaNwJXx/jGuoV6Lq/xKfKYKPMhtOplMdXOU7Xq5PDYL?=
 =?us-ascii?Q?QlayyFylMHJP+a8OFv5U86aMxPTQSyT5BzNwYYocDW1MplRBFr6voqpI74ud?=
 =?us-ascii?Q?vGFUGj2qmUOjRZ43tsHikNJFMVOnvE+apBRF3/reuBggCXxUqP5FFlbRrl2t?=
 =?us-ascii?Q?pln9nwHHVVx3n4bJfyjJq4qgvm3FO8QdSioqdXoUw0WwR615RZaryxyGvLIA?=
 =?us-ascii?Q?4wIVFAElrXO1hwoHF4wt8bOfOJGvwHErcBcyzzclI8gq3ZCwVuOTt9UrPPxQ?=
 =?us-ascii?Q?+B5lXbl+B+sAbwpzi8ji3Djbh3si4gH9S8yP+6VEfpMiJf1uqnXjjbVphm9S?=
 =?us-ascii?Q?E2yCIxaSoVpHTGSfTIZ4QyWYbNnbBGw/5nD1olp3++8ZCWP+4RA32yXw5Lmo?=
 =?us-ascii?Q?pCobCOhJAvwGt/USmddvyyqH8pI0ZVB3R3b4HHMB53GPlKPR8d0nxG1FkrU6?=
 =?us-ascii?Q?nd9IrSBGC/yc1GQjr7G4sH37REcmkIRxfwFjRrVq6jtchv5eOI4mnk2RXi25?=
 =?us-ascii?Q?9MhKXnmGC79meYAmpMcvThjxgV5HLqorZAPdEyNhQ8cfjUPdXut3sPwrosgA?=
 =?us-ascii?Q?3gz7EeAbx91AZGvuP6YPDp/PDLB8yd6tOX8B27Eg0Ovwdc3LltbaW7/EDrik?=
 =?us-ascii?Q?qubyp3bVWbPEcXnfD8IMynR6BUUEzsYRueW/gA5Y5ZosYi5QTy1YvmXtwM57?=
 =?us-ascii?Q?E/oLJTcRj4gxu52fuECKlgclVUSgvDgMclNiWMFEpBJhM/xwTjlZ3T7BfzWh?=
 =?us-ascii?Q?PoDjE/wFDHYytY9lyZOsvvF0PJ3yWejQp5dxjDeHSi7uBQEdIEQSSe7gNrOZ?=
 =?us-ascii?Q?5Y1RMUaN2zX0PoSJ5ZvHY1TNcGwOwEhnBMWSCnh9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b6b82d9-e0c3-410f-ac52-08dbe6531b2b
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 03:21:21.5490
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: px/o3tSUz44ulVtEvpKGQo7Qx4+JJLtuk0p7cy93v5gCSbtua0d9gt2jRsrzE0YoCFwn356xKTUyc8KdeRmd7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7193
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 15 Nov 2023 19:21:39 -0800 (PST)

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Thursday, November 16, 2023 9:51 AM
>=20
> Commit 99b5726b4423 ("iommu: Remove ioasid infrastructure") has
> removed
> ioasid allocation interfaces from the iommu subsystem. As a result, these
> vcmd interfaces have become obsolete. Remove them to avoid dead code.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

it's a surprise to see some remaining vcmd bits not removed.=20

with a grep actually there are more (mostly in the header files):

drivers/iommu/intel/debugfs.c:  IOMMU_REGSET_ENTRY(VCMD),
drivers/iommu/intel/pasid.h:#define VCMD_CMD_ALLOC                      0x1
drivers/iommu/intel/pasid.h:#define VCMD_CMD_FREE                       0x2
drivers/iommu/intel/pasid.h:#define VCMD_VRSP_IP                        0x1
drivers/iommu/intel/pasid.h:#define VCMD_VRSP_SC(e)                     (((=
e) & 0xff) >> 1)
drivers/iommu/intel/pasid.h:#define VCMD_VRSP_SC_SUCCESS                0
drivers/iommu/intel/pasid.h:#define VCMD_VRSP_SC_NO_PASID_AVAIL 16
drivers/iommu/intel/pasid.h:#define VCMD_VRSP_SC_INVALID_PASID  16
drivers/iommu/intel/pasid.h:#define VCMD_VRSP_RESULT_PASID(e)   (((e) >> 16=
) & 0xfffff)
drivers/iommu/intel/pasid.h:#define VCMD_CMD_OPERAND(e)         ((e) << 16)
drivers/iommu/intel/iommu.h:#define DMAR_VCMD_REG               0xe00 /* Vi=
rtual command register */