Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <823317c7-7076-7f54-bb23-9e05c4a3ba87@quicinc.com>
Date:   Thu, 16 Nov 2023 08:53:09 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
From:   Jishnu Prakash <quic_jprakash@quicinc.com>
Subject: Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename
 for QCOM PMICs
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <agross@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linus.walleij@linaro.org>,
        <Jonathan.Cameron@huawei.com>, <sboyd@kernel.org>,
        <dmitry.baryshkov@linaro.org>, <quic_subbaram@quicinc.com>,
        <quic_collinsd@quicinc.com>, <quic_kamalw@quicinc.com>,
        <marijn.suijten@somainline.org>,
        <andriy.shevchenko@linux.intel.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <cros-qcom-dts-watchers@chromium.org>,
        <linux-arm-msm@vger.kernel.org>
CC:     <linux-iio@vger.kernel.org>, <linux-arm-msm-owner@vger.kernel.org>
References: <20230708072835.3035398-1-quic_jprakash@quicinc.com>
 <20230708072835.3035398-4-quic_jprakash@quicinc.com>
 <839cfac2-8f74-3386-5854-e3fb2ba4e07f@linaro.org>
 <27b5806f-ef15-7a90-5adc-5ee12690f2ca@quicinc.com>
 <7af782f3-fe6c-415b-a993-55962845a102@linaro.org>
 <7ccaf08e-0add-33e5-fbea-ce737e53fa28@quicinc.com>
 <8114d2f9-43d8-4761-adfa-aad9ae249cbc@linaro.org>
Content-Language: en-US
In-Reply-To: <8114d2f9-43d8-4761-adfa-aad9ae249cbc@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Krzysztof,

On 11/10/2023 4:29 PM, Krzysztof Kozlowski wrote:
> On 09/11/2023 09:22, Jishnu Prakash wrote:
>> Hi Krzysztof,
>>
>> On 10/23/2023 12:02 PM, Krzysztof Kozlowski wrote:
>>
>> Since you do not want us to modify the existing bindings, is it fine if
>> I just add a new compatible for ADC5 Gen2 and comments to indicate the
>> ADC7 compatible should be considered deprecated?
> No, because adc7 compatible is valid and there is no reason to replace
> it. Just because you changed naming does not matter for compatibles.
> It's just unique string, that's it. Don't touch it.
>
>
>> If you are not convinced, we can drop the Gen2 name related changes from
>> the patch series.
> Feel free to add comments or descriptions, if you want to map some
> marketing name to real hardware or to compatibles.

Yes, I'll just add a line in the documentation to mention ADC7 goes 
between ADC5 and ADC5 Gen3.

Thanks,

Jishnu


> Best regards,
> Krzysztof
>