Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 16 Nov 2023 12:03:20 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Brenda Streiff <brenda.streiff@ni.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v4] tty: serial: Add RS422 flag to struct serial_rs485
Message-ID: <ZVWUiMykxXsuuxMd@moxa-ThinkCentre-M90t>
References: <20231113094136.52003-1-crescentcy.hsieh@moxa.com>
 <c6ea912f-d5ab-4761-813d-3b6b6be141cb@ni.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c6ea912f-d5ab-4761-813d-3b6b6be141cb@ni.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tkifJFF2GWkWiNvr7H+68ClD0yVMKUKA0p7qnotMqYuLPHvln5lDVlMbGiT6?=
 =?us-ascii?Q?+Uokr50snKJN/Yu9Xm5IDegdg1RKvPPthFhCpUKFHT/N+kfz5vwp88efMcYF?=
 =?us-ascii?Q?77GoW/8OJpZlWvowDKkVYNwLKJw8ywoXtF9xF2ZnAMyda8wIZuWycNcSFLGs?=
 =?us-ascii?Q?A5NEQuKcvlBXSOxBX+uu8Sbt4wAWTrpNb1fN+kiK15DXMZavpXMSZcmWIfWG?=
 =?us-ascii?Q?JzbZBzyYO886riAyOrC/O4cO8xtppZ2NTqmM22V4z5AeDQ5PCnyl1LrgU+Nw?=
 =?us-ascii?Q?eIJ7etckEHfHSCvMgfTLJ8sP70YOhnvJ1NxVrIDeRFVgH1PPK2qg5OimnmIb?=
 =?us-ascii?Q?+qcdE4rdHwZWsyeaFdeKK2PkNKSefEZlpdbw2HEsAlV47R9vlV3C2kkndhbC?=
 =?us-ascii?Q?Cxdum9RCIm4R8HKA8nsi/hvfYAgU1UPs81YV9ySHFkQ8wG5Fc0NvKre7PBHw?=
 =?us-ascii?Q?iEasRQDhN+cVT2xy0I/3oK4WCNOmQqxHSEhPmSMmSN5zyq0fXrYGSe0a1g89?=
 =?us-ascii?Q?1gZzp1WrTk3I9qsKVZTNrLHY2fxHb8b6fIjLr/+iq3qB856wvAFOYfyeZrPa?=
 =?us-ascii?Q?L1fFJhouyTLwYb2Izr6BPnjchc3fIaHjwlB0QCremqNYuxj+MGXbaXYdsLNI?=
 =?us-ascii?Q?LEpx25o/8TAiXKBkuyItgfvXHTvGoiY9YkE2r0qGZBJ/rZS7TtusUC3J4s56?=
 =?us-ascii?Q?hrNEj9WgFSRs2hFt1/rRTlUWsCIUUtuS9EzSTO4UByZ58DtREziU5Drud/1F?=
 =?us-ascii?Q?4i+v91rd5EPuev8neeF/kCdT7uT0TxVXpl16hSi601Qf8ZwqmO6rNj2LhJ/N?=
 =?us-ascii?Q?dglMeMFCU8ysAFWK+tFiB4WfW8QOTaGeoYf5nMU7fO9jdXv3YCmWHmJ7he1Q?=
 =?us-ascii?Q?gNg7/Mz+4JcpzqG6G/Nf601b3tIb8FIKCrlUsjY/VATQ7pCW4h+WxnpmY2Oy?=
 =?us-ascii?Q?k6C48QuYYBhRiOPGjpDnDvNodt4JzKtvbFjicJxADjNO9IvnoQ+re1XF/t1F?=
 =?us-ascii?Q?TrAbXDnWF3A8WK5HdNFJonVHJi9nQWvObLBKuvp9tDaxUzhGN5OMiJDz6q18?=
 =?us-ascii?Q?SIhMMPHodgGi8oWZ84QX3DyOg9LyxR0Z0oiWxoMBYx7JFUfuTFMI4mZLNE0v?=
 =?us-ascii?Q?eQSYRNeo6th85CklVdkYThnBlwaXvmWIwk2+X8EPmEwU3FjtQAkQMn4YvLdB?=
 =?us-ascii?Q?WZAojop818AAYcrYUNpiFQ0UnxQh710uOA8r+YMUuB3Ab3vu8ZxPmiOd7LVp?=
 =?us-ascii?Q?BP335yKH9OgixdrcbaCpJWb7onC31LpRPZm0ZFbDzOBefA89J+iUs8KyKP/H?=
 =?us-ascii?Q?VPho4FyiFkXqmOAizL1yr7d3HZsCYs146PSRxbnV+P+zjAS4emiKvlEdz7yh?=
 =?us-ascii?Q?3A0ZJpast7gIBAFE1rDqj29jzbco8ET/iGo7354trgLW0fYXAYMv2KmoqJNI?=
 =?us-ascii?Q?QJZq+hnKfKKRmMTkLC7eF3NIlt07YyrxRElZhmkGHedxS3qcxcRXNeMndQtT?=
 =?us-ascii?Q?sRxdlpi2gwgWOeXoClS0rimdZs6zD/B9BYFtVed82dosjGOuTfuhsZuQN038?=
 =?us-ascii?Q?MTPYyFlhmbyVDy/Bt+jrOX00fHLaqGLxHbe9E9NUFtXqrvxwV29nxd/H/czX?=
 =?us-ascii?Q?+w=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 711f2663-0144-416e-dcc7-08dbe658faef
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 04:03:24.6532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kC0JPGC9+3Zen3LcfV4CE4AwuJDq99OFukMo35Om9KlteJ1eL2tM0vjkQtOM5U1eu3bM7m1nK6yCHQx8q9HtYQk+j9d2GagrhRXZLfPlDOs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR01MB6199
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 15 Nov 2023 20:03:44 -0800 (PST)

On Tue, Nov 14, 2023 at 08:50:42PM -0600, Brenda Streiff wrote:
> If I compare this to your original patch set [1] for your hardware, then
> your proposed flag would be used in the following ways, correct?
> 
> RS-232:                       rs485->flags = 0
> RS-422:                       rs485->flags = SER_RS485_ENABLED|SER_RS485_MODE_RS422
> RS-485 (2-wire half-duplex):  rs485->flags = SER_RS485_ENABLED
> RS-485 (4-wire full-duplex):  rs485->flags = SER_RS485_ENABLED|SER_RS485_RX_DURING_TX
> 
> In iot2040_rs485_config in 8250_exar.c [2] we already seem to have:
> RS-232:                       rs485->flags = 0
> RS-422:                       rs485->flags = SER_RS485_ENABLED|SER_RS485_RX_DURING_TX
> RS-485 (2-wire half-duplex?): rs485->flags = SER_RS485_ENABLED
> 
> This would seem to create an inconsistency in this API.

I've checked the patch series of iot2040_rs485_config() about RS422 [1],
it seems to be reasonable back then so no one dicussed about that.

> I've also been trying to get a driver for NI's serial hardware upstream [3]; we
> have "RS-485" products that can do both RS-422/RS-485, and also have use of
> functionality to toggle between the two modes, so-- whichever way this flag
> goes-- I'd like to be consistent with how other drivers do it.
> 
> [1] https://lore.kernel.org/linux-serial/20231018091739.10125-7-crescentcy.hsieh@moxa.com/
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/8250/8250_exar.c?h=v6.6#n459
> [3] https://lore.kernel.org/linux-serial/20231023210458.447779-3-brenda.streiff@ni.com/

Originally, I was trying to add a new flag "SER_RS422_ENABLED" to
represent RS422, but Jiri replied "Hopefully not" [2].

So I used an unused flag to represent RS422 as a workaround solution,
then Jiri realized what was I trying to do and recommeded to add RS422
flag [3].

Then, when I was adding a new flag for RS422, Lino suggested to see
RS422 as a mode of RS485 [4].

Anyway, IMO, it's more reasonable to add a flag for representing RS422,
as for the naming, structure or future extention, it would require more
discussion.

[1] https://lore.kernel.org/all/?q=IOT2040_UART_MODE_RS422
[2] https://lore.kernel.org/linux-serial/92aed0d9-791f-4708-8a73-4c78457a710e@kernel.org/
[3] https://lore.kernel.org/linux-serial/3332a86c-1a1d-4b78-bbfa-8ac3e2e642a1@kernel.org/
[4] https://lore.kernel.org/all/3fc18b13-fef0-439e-abf0-1fe4e46b224a@gmx.de/

---
Sincerely,
Crescent CY Hsieh