Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 16 Nov 2023 12:59:50 +0800
From:   kernel test robot <yujie.liu@intel.com>
To:     Yicong Yang <yangyicong@huawei.com>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <sudeep.holla@arm.com>,
        <linux-arm-kernel@lists.infradead.org>
CC:     <oe-kbuild-all@lists.linux.dev>, <dietmar.eggemann@arm.com>,
        <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
        <jonathan.cameron@huawei.com>, <prime.zeng@hisilicon.com>,
        <linuxarm@huawei.com>, <yangyicong@hisilicon.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: Kconfig: Enable HOTPLUG_SMT
Message-ID: <202311151900.K9xc6Xqz-lkp@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231114040110.54590-5-yangyicong@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F+H5dzDmaEaL4XzRooZljKKp+ROCxTsx7FV8/my8w2fw4zbquJ+8ECUqh893?=
 =?us-ascii?Q?qTLXxb9mrhE3fU2JtQHfP76x6dvoSfCJGI2YhjP3AYyU5WlT/gLfo2PDDFRQ?=
 =?us-ascii?Q?zrVTDQ5uqVdNkvMUMnLWA508awp9hcYKpXc/CVBekzjuBCrx2TJDFYtVI8X9?=
 =?us-ascii?Q?kcG3Xeifr5mY9d4dNMxW8NtDtD6T6t20krurSwg8l2AMziJtMQI4yUA04XB3?=
 =?us-ascii?Q?pjcJNEqLtzDbLczE9Pg5yJzCi5x0ptMlchIulGkldpqdEBoWS97FGJZ/AJRG?=
 =?us-ascii?Q?kurqcomi/oS3ehqjAZxZp4MGAiyHctf2ks5JAqLI2G+NFo/hGFOyyajRkoK3?=
 =?us-ascii?Q?f58HDXPvtbWH07n2MaBZAQbIqXy34kHklEtPmD7HEjz913wG9cmaoFylU19E?=
 =?us-ascii?Q?RTZzjWNw2p/gMtN5BGPQUW3tqEBkNrSuCO50Yn+Y/GwuURxop1YxwRjCq2O3?=
 =?us-ascii?Q?H2mi615mk41jR9YR0147b7ngxbEK8wu7xocqB9uZRFZaAMYnB11Lc7EH/FbJ?=
 =?us-ascii?Q?JBrSn2y6p3hvuv3eVAPF65m5P5TWY3474fyESLeYJySpZYcQtKMAAXaHha9e?=
 =?us-ascii?Q?OmEPZWE+rAdZnH8LPs3GyHR8nLO8pjckYLlpgeGrdaEjlE9huPtlvBPfhkCY?=
 =?us-ascii?Q?gx7NkpM5r9YmCdDm1LBkcWpZepALS2jH6xb23T4xXVBAEzXtH00iO8MaoipQ?=
 =?us-ascii?Q?khjs0eQ31XCauiyVoA6mGmbKYbKxZfn+0/bYoHP54z/Y+FagtHQ96TlBx3i1?=
 =?us-ascii?Q?08WuQJ69usaXzcVDTZ0iA4eS7g+iXFtvb/9GWN5Vq/wD2KX87TwzBQ0j2BTf?=
 =?us-ascii?Q?JCBeWO7pKYsvNpqTgz9RzW0yRQOvZ6cMCFdZQQ06f/aPQabFYlYJOmXI7JjP?=
 =?us-ascii?Q?v7QEBLV5T2F77jVHAhHqa1r5EcknO2tnPb0BUM8EkvBvWo3ZUJWwU7QJNtHI?=
 =?us-ascii?Q?Vlaiig3ZJ3SCB77XpQ7OTxiGWxzKNAYd/3hFDYmAM8nDI0QhSIr1njLZOr2b?=
 =?us-ascii?Q?yQi0/W2bOsgDacv600l/llIYfxUYmahn79jvqX8SLADevfzpXZQtR1JR6j5V?=
 =?us-ascii?Q?9L20PGYFamZ8P4I4I02WrQG+3QmLX8Z4ryLMKzadFzxB1++IXFr1eyh7/bp+?=
 =?us-ascii?Q?9HNCWJ98dMp31WyaICKAWJcGOKnEzfyyYO+eWIL2slGdZ14Go8DFsn9MVOJQ?=
 =?us-ascii?Q?TxLaE1cSWqgja9yzPalDrL1JKcuaiuUiLmtomBRRxqxOkXslPKu4k80Bh1Sz?=
 =?us-ascii?Q?nBKhlz3GsSp64bAwR+bQ9Au3q4EYTLfeIQHeHnr69Ls7IphCUUfpeJmNNUxz?=
 =?us-ascii?Q?f9NgyjlnthPXtjySuV5I3GV9c37aKbvvV95mxqWum9bEDmmwh57InB34d1y/?=
 =?us-ascii?Q?4nTmzTH2et05HsWjC9hUw18O5NXiGlvpNEUrAIDyhx6GPYd5Rq6l+vxNiiWH?=
 =?us-ascii?Q?mLsWnmm4vj10SzqSvdVbvfGcOKP1oW9sWW+7zUoS1cVwI+WN1uCtFgWCfwoL?=
 =?us-ascii?Q?mklrNHQupmWcifnKJAZgd9DEiYbnSw1T89LN8z8XEnmxuma+rPWCv4VfI8cL?=
 =?us-ascii?Q?ioV9yM6t9ZXKBZPIVWjJUF85LSQ3m9Ue4w8Yq9ie?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d417bc37-3647-40c6-8810-08dbe66185af
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 05:04:33.6595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YJeOvTuhACLWPh8ljHBciPBE7KqPJ99qG9IKWNzPbef1UZJtTSQlYC2303+YiFfo6g14YkNVfdnU7stHHtMEbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7730
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 15 Nov 2023 21:05:30 -0800 (PST)

Hi Yicong,

kernel test robot noticed the following build errors:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus arm/for-next kvmarm/next soc/for-next linus/master arm/fixes v6.7-rc1 next-20231115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yicong-Yang/arch_topology-Support-basic-SMT-control-for-the-driver/20231114-120544
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link:    https://lore.kernel.org/r/20231114040110.54590-5-yangyicong%40huawei.com
patch subject: [PATCH v3 4/4] arm64: Kconfig: Enable HOTPLUG_SMT
config: arm64-randconfig-002-20231115 (https://download.01.org/0day-ci/archive/20231115/202311151900.K9xc6Xqz-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231115/202311151900.K9xc6Xqz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@intel.com>
| Closes: https://lore.kernel.org/r/202311151900.K9xc6Xqz-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/cpu.c: In function 'cpuhp_smt_disable':
>> kernel/cpu.c:2687:23: error: implicit declaration of function 'cpu_down_maps_locked' [-Werror=implicit-function-declaration]
    2687 |                 ret = cpu_down_maps_locked(cpu, CPUHP_OFFLINE);
         |                       ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/cpu_down_maps_locked +2687 kernel/cpu.c

dc8d37ed304eee Arnd Bergmann    2019-12-10  2672  
dc8d37ed304eee Arnd Bergmann    2019-12-10  2673  int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval)
dc8d37ed304eee Arnd Bergmann    2019-12-10  2674  {
dc8d37ed304eee Arnd Bergmann    2019-12-10  2675  	int cpu, ret = 0;
dc8d37ed304eee Arnd Bergmann    2019-12-10  2676  
dc8d37ed304eee Arnd Bergmann    2019-12-10  2677  	cpu_maps_update_begin();
dc8d37ed304eee Arnd Bergmann    2019-12-10  2678  	for_each_online_cpu(cpu) {
dc8d37ed304eee Arnd Bergmann    2019-12-10  2679  		if (topology_is_primary_thread(cpu))
dc8d37ed304eee Arnd Bergmann    2019-12-10  2680  			continue;
38253464bc821d Michael Ellerman 2023-07-05  2681  		/*
38253464bc821d Michael Ellerman 2023-07-05  2682  		 * Disable can be called with CPU_SMT_ENABLED when changing
38253464bc821d Michael Ellerman 2023-07-05  2683  		 * from a higher to lower number of SMT threads per core.
38253464bc821d Michael Ellerman 2023-07-05  2684  		 */
38253464bc821d Michael Ellerman 2023-07-05  2685  		if (ctrlval == CPU_SMT_ENABLED && cpu_smt_thread_allowed(cpu))
38253464bc821d Michael Ellerman 2023-07-05  2686  			continue;
dc8d37ed304eee Arnd Bergmann    2019-12-10 @2687  		ret = cpu_down_maps_locked(cpu, CPUHP_OFFLINE);
dc8d37ed304eee Arnd Bergmann    2019-12-10  2688  		if (ret)
dc8d37ed304eee Arnd Bergmann    2019-12-10  2689  			break;
dc8d37ed304eee Arnd Bergmann    2019-12-10  2690  		/*
dc8d37ed304eee Arnd Bergmann    2019-12-10  2691  		 * As this needs to hold the cpu maps lock it's impossible
dc8d37ed304eee Arnd Bergmann    2019-12-10  2692  		 * to call device_offline() because that ends up calling
dc8d37ed304eee Arnd Bergmann    2019-12-10  2693  		 * cpu_down() which takes cpu maps lock. cpu maps lock
dc8d37ed304eee Arnd Bergmann    2019-12-10  2694  		 * needs to be held as this might race against in kernel
dc8d37ed304eee Arnd Bergmann    2019-12-10  2695  		 * abusers of the hotplug machinery (thermal management).
dc8d37ed304eee Arnd Bergmann    2019-12-10  2696  		 *
dc8d37ed304eee Arnd Bergmann    2019-12-10  2697  		 * So nothing would update device:offline state. That would
dc8d37ed304eee Arnd Bergmann    2019-12-10  2698  		 * leave the sysfs entry stale and prevent onlining after
dc8d37ed304eee Arnd Bergmann    2019-12-10  2699  		 * smt control has been changed to 'off' again. This is
dc8d37ed304eee Arnd Bergmann    2019-12-10  2700  		 * called under the sysfs hotplug lock, so it is properly
dc8d37ed304eee Arnd Bergmann    2019-12-10  2701  		 * serialized against the regular offline usage.
dc8d37ed304eee Arnd Bergmann    2019-12-10  2702  		 */
dc8d37ed304eee Arnd Bergmann    2019-12-10  2703  		cpuhp_offline_cpu_device(cpu);
dc8d37ed304eee Arnd Bergmann    2019-12-10  2704  	}
dc8d37ed304eee Arnd Bergmann    2019-12-10  2705  	if (!ret)
dc8d37ed304eee Arnd Bergmann    2019-12-10  2706  		cpu_smt_control = ctrlval;
dc8d37ed304eee Arnd Bergmann    2019-12-10  2707  	cpu_maps_update_done();
dc8d37ed304eee Arnd Bergmann    2019-12-10  2708  	return ret;
dc8d37ed304eee Arnd Bergmann    2019-12-10  2709  }
dc8d37ed304eee Arnd Bergmann    2019-12-10  2710  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki