Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231116032530.753192-1-quic_jprakash@quicinc.com>
In-Reply-To: <20231116032530.753192-1-quic_jprakash@quicinc.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Thu, 16 Nov 2023 07:22:38 +0200
Message-ID: <CAA8EJprJuiFq5UXc9weNr1hy2vW_10TaQweN_ZW5XW=3LKrgtA@mail.gmail.com>
Subject: Re: [PATCH V2 0/3] iio: adc: Add support for QCOM SPMI PMIC5 Gen3 ADC
To:     Jishnu Prakash <quic_jprakash@quicinc.com>
Cc:     jic23@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        daniel.lezcano@linaro.org, linus.walleij@linaro.org,
        linux-arm-msm@vger.kernel.org, andriy.shevchenko@linux.intel.com,
        quic_subbaram@quicinc.com, quic_collinsd@quicinc.com,
        quic_amelende@quicinc.com, quic_kamalw@quicinc.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        marijn.suijten@somainline.org, lars@metafoo.de, luca@z3ntu.xyz,
        linux-iio@vger.kernel.org, lee@kernel.org, rafael@kernel.org,
        rui.zhang@intel.com, lukasz.luba@arm.com,
        cros-qcom-dts-watchers@chromium.org, sboyd@kernel.org,
        linux-pm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org,
        kernel@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 16 Nov 2023 at 05:26, Jishnu Prakash <quic_jprakash@quicinc.com> wrote:
>
> PMIC5 Gen3 has a similar ADC architecture to that on PMIC5 Gen2,
> with all SW communication to ADC going through PMK8550 which
> communicates with other PMICs through PBS. The major difference is
> that the register interface used here is that of an SDAM present on
> PMK8550, rather than a dedicated ADC peripheral. There may be more than one
> SDAM used for ADC5 Gen3. Each ADC SDAM has eight channels, each of which may
> be used for either immediate reads (same functionality as previous PMIC5 and
> PMIC5 Gen2 ADC peripherals) or recurring measurements (same as PMIC5 and PMIC5
> Gen2 ADC_TM functionality). In this case, we have VADC and ADC_TM functionality
> combined into the same driver.
>
> Patches 1 adds bindings for ADC5 Gen3 peripheral.
>
> Patches 2 adds driver support for ADC5 Gen3.

For some reason I don't see this patch in my inbox. Maybe it will
arrive later. Immediate response: please add
devm_thermal_add_hwmon_sysfs().

>
> Patch 3 is a cleanup, to move the QCOM ADC dt-bindings files from
> dt-bindings/iio to dt-bindings/iio/adc folder, as they are
> specifically for ADC devices. It also fixes all compilation errors
> with this change in driver and devicetree files and similar errors
> in documentation for dtbinding check.

NAK. The kernel is expected to build and work after each commit.
Otherwise git-bisecting the kernel becomes impossible.
So, please rework your series in a way that there are no compilation
errors after any of the patches. The easiest way would be to rearrange
your patches in 3-1-2 order.


>
> Changes since v1:
> - Dropped patches 1-5 for changing 'ADC7' peripheral name to 'ADC5 Gen2'.
> - Addressed reviewer comments for binding and driver patches for ADC5 Gen3.
> - Combined patches 8-11 into a single patch as requested by reviewers to make
>   the change clearer and made all fixes required in same patch.
>
> Jishnu Prakash (3):
>   dt-bindings: iio: adc: Add QCOM PMIC5 Gen3 ADC bindings
>   iio: adc: Add support for QCOM PMIC5 Gen3 ADC
>   dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder
>
>  .../bindings/iio/adc/qcom,spmi-vadc.yaml      |  185 ++-
>  .../bindings/mfd/qcom,spmi-pmic.yaml          |    2 +-
>  .../bindings/thermal/qcom-spmi-adc-tm-hc.yaml |    2 +-
>  .../bindings/thermal/qcom-spmi-adc-tm5.yaml   |    6 +-
>  arch/arm64/boot/dts/qcom/pm2250.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm6125.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm6150.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm6150l.dtsi         |    2 +-
>  arch/arm64/boot/dts/qcom/pm660.dtsi           |    2 +-
>  arch/arm64/boot/dts/qcom/pm660l.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm7250b.dtsi         |    2 +-
>  arch/arm64/boot/dts/qcom/pm8150.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm8150b.dtsi         |    2 +-
>  arch/arm64/boot/dts/qcom/pm8150l.dtsi         |    2 +-
>  arch/arm64/boot/dts/qcom/pm8916.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm8950.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm8953.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm8994.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pm8998.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pmi632.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/pmi8950.dtsi         |    2 +-
>  arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi     |    2 +-
>  arch/arm64/boot/dts/qcom/pmp8074.dtsi         |    2 +-
>  arch/arm64/boot/dts/qcom/pms405.dtsi          |    2 +-
>  arch/arm64/boot/dts/qcom/sc7280-idp.dts       |    2 +-
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |    2 +-
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi    |    4 +-
>  arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi   |    2 +-
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    |    6 +-
>  .../boot/dts/qcom/sm7225-fairphone-fp4.dts    |    2 +-
>  arch/arm64/boot/dts/qcom/sm8450-hdk.dts       |    8 +-
>  drivers/iio/adc/Kconfig                       |   25 +
>  drivers/iio/adc/Makefile                      |    1 +
>  drivers/iio/adc/qcom-spmi-adc5-gen3.c         | 1189 +++++++++++++++++
>  drivers/iio/adc/qcom-spmi-adc5.c              |    2 +-
>  drivers/iio/adc/qcom-spmi-vadc.c              |    2 +-
>  .../iio/adc/qcom,spmi-adc5-gen3-pm8550.h      |   50 +
>  .../iio/adc/qcom,spmi-adc5-gen3-pm8550b.h     |   89 ++
>  .../iio/adc/qcom,spmi-adc5-gen3-pm8550vx.h    |   22 +
>  .../iio/adc/qcom,spmi-adc5-gen3-pmk8550.h     |   56 +
>  .../iio/{ => adc}/qcom,spmi-adc7-pm8350.h     |    2 +-
>  .../iio/{ => adc}/qcom,spmi-adc7-pm8350b.h    |    2 +-
>  .../iio/{ => adc}/qcom,spmi-adc7-pmk8350.h    |    2 +-
>  .../iio/{ => adc}/qcom,spmi-adc7-pmr735a.h    |    2 +-
>  .../iio/{ => adc}/qcom,spmi-adc7-pmr735b.h    |    0
>  .../iio/{ => adc}/qcom,spmi-vadc.h            |   81 ++
>  46 files changed, 1725 insertions(+), 61 deletions(-)
>  create mode 100644 drivers/iio/adc/qcom-spmi-adc5-gen3.c
>  create mode 100644 include/dt-bindings/iio/adc/qcom,spmi-adc5-gen3-pm8550.h
>  create mode 100644 include/dt-bindings/iio/adc/qcom,spmi-adc5-gen3-pm8550b.h
>  create mode 100644 include/dt-bindings/iio/adc/qcom,spmi-adc5-gen3-pm8550vx.h
>  create mode 100644 include/dt-bindings/iio/adc/qcom,spmi-adc5-gen3-pmk8550.h
>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm8350.h (98%)
>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pm8350b.h (99%)
>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmk8350.h (97%)
>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmr735a.h (95%)
>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-adc7-pmr735b.h (100%)
>  rename include/dt-bindings/iio/{ => adc}/qcom,spmi-vadc.h (77%)
>
> --
> 2.25.1
>


--
With best wishes
Dmitry