Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <39222f73-35f8-4d05-8772-c6df4c8298ca@intel.com>
Date:   Thu, 16 Nov 2023 13:35:33 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 7/7] vfio: Add vfio_register_pasid_iommu_dev()
Content-Language: en-US
To:     Yi Liu <yi.l.liu@intel.com>, <joro@8bytes.org>,
        <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>
CC:     <cohuck@redhat.com>, <eric.auger@redhat.com>,
        <nicolinc@nvidia.com>, <kvm@vger.kernel.org>,
        <mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
        <yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
        <jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
        <lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
        <joao.m.martins@oracle.com>,
        "Chittim, Madhu" <madhu.chittim@intel.com>,
        <jacob.e.keller@intel.com>
References: <20231009085123.463179-1-yi.l.liu@intel.com>
 <20231009085123.463179-8-yi.l.liu@intel.com>
From:   "Cao, Yahui" <yahui.cao@intel.com>
In-Reply-To: <20231009085123.463179-8-yi.l.liu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVFUaWMxK2lCYXh5SWduMkZZTGZFT1ZMNEZQY3FNVTIzNEtJL3NUY3Z2bWZZ?=
 =?utf-8?B?NkZNTitzRVVTUjYwR0FxUElMZjVSMlJUazdIby9SbFJsbkorUllObXlnVkNv?=
 =?utf-8?B?MnJYUE9nMUh3bnBCZjd2RTRSZHN5Y2pqeDBlb3JzRnBWZ2hoTEtMTU1RWEk1?=
 =?utf-8?B?Y3pGNnJNRy95RlpQRitHVEJraFY4ZU1sbndxcTBFVVRXa2ZCWHRueTNHajVV?=
 =?utf-8?B?K0lsQ2hvTnRpeGIxQzFPTDZxekl0cEdJeUJMdndFYlpvT2c1QTJ0RlpKU1ow?=
 =?utf-8?B?ajR3bWFSS2VaTXBrWGR2NFl4eTMza2J2NXdza3BzQllxcnV6WlNBNUtld3Ur?=
 =?utf-8?B?MzkxYmliWTl4UzZRWEp1UGNhMEFkUFRrOUNqaEdkLzZ3a0NqbmI5TWNWZXh1?=
 =?utf-8?B?OHdsN24yNnp1L095bVUrWXVCejBncENUN0JCRGJkVjErMW4wYlNqNVNMa3Vs?=
 =?utf-8?B?bkU3dUs0bkk1eHBibWNUSVphV3dCc1J6Y3VjMHRCMGdVTWtVbllpTW91SHpH?=
 =?utf-8?B?SkdWemszUWxmMXJ1M2VGNDhPZEwvWm8rbkFYQW5QSUR1NjBpVkJMRnN6MEIx?=
 =?utf-8?B?Z1RHSVVyV0xOanV1dXQxYmYvaFlsK2lpc1ViaUJPK1A2Tlp0TVFwYTZVczhz?=
 =?utf-8?B?WC9zUytIZWRUQkVHRUp4cG5GOUhPMlBNZXRUZDlld1JFMHV5SE5lbUlPNVht?=
 =?utf-8?B?T2xhQTNaRERoMk5KWVRudTZvcS91Z3VlRjkzMG4wUTgwVVZ1UVl2OUEzUEFw?=
 =?utf-8?B?WGtkdFpmNU43US9EMVVyWUJHR1BOZnIyQ3V6YzN5cFlKYW5NRjAyQ0tQUHBG?=
 =?utf-8?B?RVhGR2tRcENGVFpvUzdPMElCTXdSYW00SDZGN3oyZVZFRnRuT2djUHZCMWdT?=
 =?utf-8?B?Si81QVNzbExXQ3psQXhJdUQxOGJMbDE1VHRlaCtzV01EWmdhTU41Wlgvd3li?=
 =?utf-8?B?aC94dFBsOHNkTGkwOVZmQUpEb0tkdXJydkJaYk5QVDVRK1NkMVVhdUVNZGpj?=
 =?utf-8?B?YlhPNi9sejZ6RVpuRUVsVTJNK0xXb2ZUV0VJUVhJYTgvU1FDb0tZUWN6ZkZp?=
 =?utf-8?B?NDB5UFlGNm5ja05MaVlQWTlzem9hR29WeXRpRVoyRUtLTHpPZ0dFdWhDS01P?=
 =?utf-8?B?YVNGNzFucmRNMEpjVmJkcktWdy94b3J0TWVwWUlKYm5Gck1kSEJ3MnNVV3R0?=
 =?utf-8?B?N0Q1QWxrSnlxbFlsQXRKb012UGE2aDEreXdxT3JFWDdMemtRWHd3K1l2dXFx?=
 =?utf-8?B?Qlk1NmxVNFhvNktuRld4NGhkL1ZWc1F5K2JkVVdsV1pGTllqb3l4QjViT3Bi?=
 =?utf-8?B?dmFVVitWY3RuODhzUGRSNmZtQWxwN0Vab1BBQld5WmhJRUxKL0Zwc0I3NlN5?=
 =?utf-8?B?b3BCWW1Sc2xrb1hUSkpNZlNFbEtGMlBXUEFSdTdnM0R1NDdsNUlJdFNKbXZt?=
 =?utf-8?B?SnU0dlpjWnExaHdRVHBVRlhFR1BZZWI5WnpuNkpZcnN6bEU1NzVoWFU3Z2FL?=
 =?utf-8?B?ODZ4a2VDU3BuY0ZROWVsdWUvZS8yWWNYUFRSdDN0YjdQSFp0OTF2R0xWQWU3?=
 =?utf-8?B?N1RYNDA3aUVBT1JNeHltaDM2NXptWlZjQ0luTmc2QU8yNDZHd2pUamMrTDEw?=
 =?utf-8?B?czRFLzluSFJTZU9RNU1BdSs0WFlLcHIycEttWTI1SURpSHUycUtBN0t4SEhs?=
 =?utf-8?B?MXB1VU9YVVZmbTFVM204bFJMd1J0a255Q1EwSHVTM1E2UnZDcUszVDAvVVZu?=
 =?utf-8?B?MEs5cUUvS20wYjdHcnBSWklmVTJZNjFMRVBaR1VlbWRwOU1GSnlFVUxiS1RK?=
 =?utf-8?B?NnM2VzhHYnV1ZGJrQ1J2R0FtZUhmWVVkbEtxaFhrM2x6eVIraEtxZGpmSHRn?=
 =?utf-8?B?YVFLcU0yVGp0UktxUWVBMlBPQmJrZE9zeE5GdEdsWTNDTEVxTWhRQzgrSkdm?=
 =?utf-8?B?QmhXWGpZZWgwS3ZrUXpjN3NIMW1YNjgzOFVnWUdRTy9YZnhEUFp1UTdOL0lE?=
 =?utf-8?B?QUcxSGs0RlFVUlo2b1Y4MkpXRTREU0htYUp4SUp1bEkyNC9qQVBFRVY0Zngx?=
 =?utf-8?B?NjRjdXRNVWZ5ZHp6VmJKQ3d5S3IrL0tINnpyY0Q0ZmFXbXlaeHRDQkhCMXVQ?=
 =?utf-8?Q?81LhZKRYP48+8OGHoF3h3pCsH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cc990f9e-6667-4ca7-9cf7-08dbe665e32b
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7838.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 05:35:48.8449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kQaN17WCZkwBIXqe4xscr+eWmotJGUWGxPyJhn6+xhgHt1CJacrTSURe7n98RgkfgahxGptQ4MYgXCrNm6PNgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6015
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 15 Nov 2023 21:36:24 -0800 (PST)


On 10/9/2023 4:51 PM, Yi Liu wrote:
> From: Kevin Tian <kevin.tian@intel.com>
>
> This adds vfio_register_pasid_iommu_dev() for device driver to register
> virtual devices which are isolated per PASID in physical IOMMU. The major
> usage is for the SIOV devices which allows device driver to tag the DMAs
> out of virtual devices within it with different PASIDs.
>
> For a given vfio device, VFIO core creates both group user interface and
> device user interface (device cdev) if configured. However, for the virtual
> devices backed by PASID of the device, VFIO core shall only create device
> user interface as there is no plan to support such devices in the legacy
> vfio_iommu drivers which is a must if creating group user interface for
> such virtual devices. This introduces a VFIO_PASID_IOMMU group type for
> the device driver to register PASID virtual devices, and provides a wrapper
> API for it. In particular no iommu group (neither fake group or real group)
> exists per PASID, hence no group interface for this type.
>
> Signed-off-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>
>   
> +/*
> + * Register a virtual device with IOMMU pasid protection. The user of
> + * this device can trigger DMA as long as all of its outgoing DMAs are
> + * always tagged with a pasid.
> + */
> +int vfio_register_pasid_iommu_dev(struct vfio_device *device)
> +{
> +	return __vfio_register_dev(device, VFIO_PASID_IOMMU);
> +}
> +

If CONFIG_VFIO_GROUP kconfig is selected, then there will be access to 
vdev->group shown as below
->__vfio_register_dev()
        ->vfio_device_add()
             ->vfio_device_is_noiommu() { return 
IS_ENABLED(CONFIG_VFIO_NOIOMMU) && vdev->group->type == VFIO_NO_IOMMU}

For SIOV virtual devices, vfio group is not created and vfio cdev is 
used. Thus vdev->group is NULL and there is NULL pointer access here.

Thanks.
Yahui.