Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <f2df3ba6-76d2-4e2e-9c7e-54f6a84464b7@axis.com>
Date:   Thu, 16 Nov 2023 08:43:00 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 3/3] Input: cap11xx - remove unnecessary IRQ parsing
To:     Rob Herring <robh+dt@kernel.org>
Cc:     krzysztof.kozlowski+dt@linaro.org, dmitry.torokhov@gmail.com,
        devicetree@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de
References: <20231108155647.1812835-1-jiriv@axis.com>
 <20231108155647.1812835-4-jiriv@axis.com>
 <CAL_JsqL3veRuuDqWnZ+eUTP5Mvz5WffYktrBh6HqyARRThzmYQ@mail.gmail.com>
Content-Language: en-US
From:   Jiri Valek - 2N <jiriv@axis.com>
In-Reply-To: <CAL_JsqL3veRuuDqWnZ+eUTP5Mvz5WffYktrBh6HqyARRThzmYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHhiTVRCT1FFbkVUTk9EeS9YSDJPTUxLbm93TG0xT3dHYjlIaU9LSnNwNzFa?=
 =?utf-8?B?ekpTZXZCNlFoS0hNSGdaWHM4d2cwbWhhMTlWMkE3M0dIdkszNERGRk9jMUN3?=
 =?utf-8?B?cllaWUZsWW0rV0tKRXo5T3c3L2U0ZGJ0SFVGdVNNSTV1NkU3RUxEcTZJNDlL?=
 =?utf-8?B?Y1o5VkFOYThQdmJMZWlaR09nL0k1TnhwdXVaWC9rSHZGUTVUdDd5eVgrQkVS?=
 =?utf-8?B?bm1PTi9CSnZkZFlJWUw0NDlCUlU1ckVQZFh3ZTN0bm9SZnFWWGFzRXJIV0Fo?=
 =?utf-8?B?UnR6M2hGNSszYThCTFZFdy9rZ01pdTcxV1p3WDc5aTlwcndDcWEyUTZyWnp4?=
 =?utf-8?B?Rm56alVXSXd1TkUxbjNOcllldkZNKzVRK3dsR2p2bWd0VGNnVGhrYm15VW5T?=
 =?utf-8?B?UzdwNG05UUZRYmtBRUx3bXd3ZWt3MFh4VHJVVWV2UlRxc05kQmdRR2dHaGVj?=
 =?utf-8?B?ai85OGNpQXUyTTArTU1jZkdxTXM5SEM1c1lCUnlYOEVzMXJJWGlhNWlPWGpk?=
 =?utf-8?B?QUNEeVVaOXpEUzBoN2IxL09LQkR4YmdFd0Q1R3VQcEM3Z3YwbTRzUDV5N0FM?=
 =?utf-8?B?QzFldVQ4eGY5QllSdjczcTRPcW5vY2RUTXFleFo0UDRjR2dYbVhqaHdqcm15?=
 =?utf-8?B?M3hua04rakxzVFdiT01IR2RzdnhSeWFIWk5zYVNXVnpLbC8zK29GYzBUQ2FR?=
 =?utf-8?B?anpLV2VnaFVyNDJTa0tiTHlrbUx2NHhVd0wwWVIrdWc3ckJsbHNYWno4Vytj?=
 =?utf-8?B?N0s4UE40eEJ0bmtEWUUzVDFUZ1JGTzhoOVNPdTY0TmZlQmJRcmpCZCtPUkJV?=
 =?utf-8?B?UzR3YmpXNlR4S05kS3ZBbjJYOVZhSGxVakpmcjlxZUZweGdOSnM2V2hNb0Uy?=
 =?utf-8?B?VkZ6MmZqL3E0KzBiU0ZXUkFBSldUV3JCRHhBZ0lTcmtGRjJQUDNFa1BCT0xP?=
 =?utf-8?B?U0xjcXpoN2toRkxmQ1I2WWtrKzhCaXNKRzlYMEpOWVh6SXFlbk1vSUp2dWt3?=
 =?utf-8?B?U09ZYnY1ejN1YWhnVFpyZ1NtVm9IODdKTXMwM2tFUFRyQ2FuenQrcERhREVW?=
 =?utf-8?B?aFZZalRsY3kxWHlVanJyZ0VkZnJaQmJ4VG85NWZweVFrNnhIRkpnazhqcVpz?=
 =?utf-8?B?eksvemtzd3luNXduTVNCVVRKeVJ1Y0NrQ0FNbjFsb3h4NDJWMlZhSkdiVURG?=
 =?utf-8?B?UnB2QmU4R3J3clhwZ1B5dTd2dTUwa05uc0VwQTVKQmtnR3ptOGFjOE02QU85?=
 =?utf-8?B?RlAxakRsRExQalVMS2Evc0V5ekxUSEZIc3NSTnNDWVJpSm1pR2FCQ2xpRk0x?=
 =?utf-8?B?enRIOHo3WjF5U3grbHp5bnpYMnZ2ckM1YWlmQk52RTZMVW1DN04zd2Yyd1hz?=
 =?utf-8?B?WWV0NnNLQ0dQWTRIbnNublpuOFUzMVBlYnVKWUNybGE2V0dtc0h4TFhnVEt4?=
 =?utf-8?B?aDVKRTRCZnBCOVlIMS90QmUxK2xqSnYzK2pUQVhnaTcrN1M4NEp4VTlNTTRF?=
 =?utf-8?B?dU93ZGRESGdOQk5GYlBRZS9VTTkrR3pBc0VmaW1INWUwT0hMYU14MFdqRTBl?=
 =?utf-8?B?V3BRLzN5eG96T1lHdGJacVAxYVZBZFdmNjVVNzVsRTV5c09uVHNObDM4d0ls?=
 =?utf-8?B?dFZLaXgxZURVdmFwWXgzSkJweWdBbWhxcE5ZTyt3WndobUZuR0wwbzJEdStZ?=
 =?utf-8?B?Rmp2V2hpL3Z3aFVmeGE0ZGVuSmNTRm1uRHVwVy94a0hXV1N6UnlOV0t1SDRR?=
 =?utf-8?B?cVpzRXdaZDAwVkQ3L0F5aHgzUG8waXVFcFVwS1Q5aTFmTDVZWmIzczhaandt?=
 =?utf-8?B?cjdITnBjMUpiMmNjT3QvQnlSRWJlZDRmSkF0RDVzNHNvQmo5Qk45UlVxUjVN?=
 =?utf-8?B?YS8vNWhLSHYveE5ucmw3T2l0WUU0MWl4Y3dDdkw2NkxrRnFBV0JYYmFzRFE3?=
 =?utf-8?B?WktsaWhLZHlZWVZGelBCZnJOcVk1QnVmWjNaQjlVQVhnZks0bXpYZ3JORXdk?=
 =?utf-8?B?Rmo4VU11UWZKTHpXSExaV204K1NKeWlIWGxzYlpwNU5RdFF1K25rVS9GVU5h?=
 =?utf-8?B?bjVqbjNQVWkxVUJ1OWF0WUdvYVdZdU9NWUhhakhqOUhtdkVvNzZVaCtXVkVx?=
 =?utf-8?Q?vxGmLHprGHdieyyY3aKSsDlII?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 631b0f76-ce83-4609-3da7-08dbe677aa10
X-MS-Exchange-CrossTenant-AuthSource: PAXPR02MB7263.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 07:43:03.3677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LDbhyx2v6tveHmxKk/iomthmsuThl0TDwIvDJCz0Pa/CNJiJncvS/EPk+41xlvqQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB9412
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 15 Nov 2023 23:43:18 -0800 (PST)

On 11/8/23 20:53, Rob Herring wrote:
> On Wed, Nov 8, 2023 at 9:57 AM Jiri Valek - 2N <jiriv@axis.com> wrote:
>>
>> Separate IRQ parsing is not necessary, I2C core do the job.
>>
>> Signed-off-by: Jiri Valek - 2N <jiriv@axis.com>
>> ---
>>  drivers/input/keyboard/cap11xx.c | 10 ++--------
>>  1 file changed, 2 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/input/keyboard/cap11xx.c b/drivers/input/keyboard/cap11xx.c
>> index 4711ea985627..ccca9936ef25 100644
>> --- a/drivers/input/keyboard/cap11xx.c
>> +++ b/drivers/input/keyboard/cap11xx.c
>> @@ -518,7 +518,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>         struct device *dev = &i2c_client->dev;
>>         struct cap11xx_priv *priv;
>>         const struct cap11xx_hw_model *cap;
>> -       int i, error, irq;
>> +       int i, error;
>>         unsigned int val, rev;
>>
>>         if (id->driver_data >= ARRAY_SIZE(cap11xx_devices)) {
>> @@ -624,13 +624,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>         if (error)
>>                 return error;
>>
>> -       irq = irq_of_parse_and_map(dev->of_node, 0);
> 
> Probably can drop the include of of_irq.h as well.
Ack. Thanks for notice!