Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231116022213.28795-1-duminjie@vivo.com>
In-Reply-To: <20231116022213.28795-1-duminjie@vivo.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 16 Nov 2023 09:44:03 +0100
Message-ID: <CANn89i+B2gNO7-Mnai59Tpn44tomfLN1m9NnSEMq-qkt7AyyRw@mail.gmail.com>
Subject: Re: [PATCH v2] net/tcp: use kfree_sensitive() instend of kfree() in
 two functions
To:     Minjie Du <duminjie@vivo.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:NETWORKING [TCP]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 16, 2023 at 3:22=E2=80=AFAM Minjie Du <duminjie@vivo.com> wrote=
:
>
> key might contain private information, so use kfree_sensitive to free it.
> In tcp_time_wait_init() and tcp_md5_twsk_free_rcu() use kfree_sensitive()=
.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>

You have not addressed my prior feedback.

3) You forgot tcp_time_wait_init(), tcp_md5_do_del(), tcp_md5_key_copy(),
    tcp_md5_do_add(), tcp_clear_md5_list().