Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp3155414rdb; Thu, 16 Nov 2023 01:30:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLc+mU6ApdIYQRSYXRommA5mA1035vFxfeFDkINAeejWAQ+SZsl/sWdCzANCMvGwPJWHEp X-Received: by 2002:a05:6871:709:b0:1e9:bda0:775 with SMTP id f9-20020a056871070900b001e9bda00775mr15592439oap.42.1700127019753; Thu, 16 Nov 2023 01:30:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700127019; cv=none; d=google.com; s=arc-20160816; b=rEodaFkhWsYlrzPL0Iyd+VPKoWMYMaQdBMWUBmnSnMIqLnRtQrB+/63gnHG2gNrjlt tSI5nTPOBNwYtkCZq7wCuoi20m2ls8qP9WNFAWgru/5MDmiq1ii9RS+GdzdB3TS9DTjU XJ905R9kz3w1553nrkw6nVa7EmGtYujm/DdqgPs4IGe9EwqRuxcZ3DQv0WwKmFQ9eggj hrJB2Rc4zmoztWkXir3xRKGHvThTbzn1BJ2GIybbp6pdlSqEze1BfixRl3pu1Tel51QO e7VOxxno6SW6Mkqibnpba5hvR7kX6NMwgSem2LFWAXxklZKh4KrlticjdQPOgJkQ9hoh 8LqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=qQM2FnTXeGFHjIXM8bHi3GTM4JALf37Zt+qMG2bajKQ=; fh=w0aJU6XbGpBbN0uLVlOAbZ3nLEuvEdHT7HjgAfe1ELc=; b=qvp1Kw1yZesO6+XURVked1ZzsFLVx2XNyw2tdSWKUz5Ky8t8GS9x2k8mO//KUD2DPC 6q1Wh3IATBc1gCCuS3I+5OiuIfXbBaEp6ZgA9V5/zl4GuMFbv45+Vf6lHFPAzpcdTpK3 JtEGi5glsxWa2kOW9FjAfc3r6NRxsFugumzWIgqBJzpCyBJvcAOl53XU6WVknZQREHIz r65MD284eo/f24obPUSqoMjFtKhF9KmogCGVDfTxF9/ltW89uQr+oBgI2/f0kJWhaL8Z SpZe1TQ9Nz/7WliIPWpHWHf55oEjpTFkTbLNKq12XB7HytqKTYhUYqaH89PFMGDY1e5o ysPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ElZ2WzzG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id k69-20020a638448000000b005b91518ab92si11292445pgd.671.2023.11.16.01.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 01:30:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ElZ2WzzG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 57AEB805741A; Thu, 16 Nov 2023 01:30:16 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230307AbjKPJaB (ORCPT + 99 others); Thu, 16 Nov 2023 04:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjKPJaA (ORCPT ); Thu, 16 Nov 2023 04:30:00 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36E549C; Thu, 16 Nov 2023 01:29:57 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AG8iKDA007049; Thu, 16 Nov 2023 09:29:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=qQM2FnTXeGFHjIXM8bHi3GTM4JALf37Zt+qMG2bajKQ=; b=ElZ2WzzGClHcUaaUQy7T73WBRhk3UB9K/35Qnix3OtvxZeMcXJJHPXuNB9z0HKcLFA6L iESBxRPQtMwtt+QOilsD3mlczjEBzFwedQpl86qIALSR85Cdwu7+t9ZnjvGLBwZYQZ4g pKLQXWVmYOQhkCp77cuj006X3m5IJM6nWihktwZMDS3Fhl6b4DG3Ppy1v5vJZ7hsG7tc DtPTfhAL7C72GKDk8YKfVjnwD89LTd0ZQXId4SXm/6VHiHpgmCGRoyeobW2LBwr3hPEj IRPoZYMX/LcC0ShgyZMj4JccbZNJBrL0eH/GzJv8SsWtU3QgVlYnkZuAVauOWvTdI9Fw rg== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ucrb2k8de-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 09:29:52 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AG9Tpwd016546 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 09:29:51 GMT Received: from [10.218.19.46] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 16 Nov 2023 01:29:47 -0800 Message-ID: <0c1d1ccd-fff8-fb4f-12c0-8b60f3e5c3e2@quicinc.com> Date: Thu, 16 Nov 2023 14:59:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 2/4] clk: qcom: videocc-sm8150: Update the videocc resets Content-Language: en-US To: Bryan O'Donoghue , Konrad Dybcio , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: Bjorn Andersson , , , , References: <20231110065029.2117212-1-quic_skakitap@quicinc.com> <20231110065029.2117212-3-quic_skakitap@quicinc.com> <31dac823-cc46-401e-85f8-d04544bd38c3@linaro.org> <2c5dae0f-5bd4-4fed-ba47-1175eba07207@linaro.org> From: "Satya Priya Kakitapalli (Temp)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: MUZYZkBjfoc71qjXBwiJoN5Ej71gxJOc X-Proofpoint-ORIG-GUID: MUZYZkBjfoc71qjXBwiJoN5Ej71gxJOc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_07,2023-11-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 clxscore=1011 impostorscore=0 spamscore=0 adultscore=0 mlxlogscore=578 phishscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311160076 X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 16 Nov 2023 01:30:16 -0800 (PST) On 11/15/2023 10:39 PM, Bryan O'Donoghue wrote: > On 15/11/2023 16:48, Konrad Dybcio wrote: >>> +    [VIDEO_CC_INTERFACE_BCR] = { 0x9ac }, >>> +    [VIDEO_CC_MVS0_BCR] = { 0x870 }, >>> +    [VIDEO_CC_MVS1_BCR] = { 0x8b0 }, >>> +    [VIDEO_CC_MVSC_BCR] = { 0x810 }, >> FWIW this seems to be a copypaste from >> >> https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blame/92b31370d31d22e910120f6a875bf0919b3f1773/drivers/clk/qcom/videocc-sm8150.c >> >> >> so if it's an issue, it should probably be fixed downstream too > > More of a question than a gotcha - 0x9ac is valid for sm8250 so > curious to me that its a different address on sm8150. I have re-checked the offset values, as per the HW plan for SM8150 below values are correct: +    [VIDEO_CC_INTERFACE_BCR] = { 0x8f0 }, +    [VIDEO_CC_MVS0_BCR] = { 0x870 }, +    [VIDEO_CC_MVS1_BCR] = { 0x8b0 }, +    [VIDEO_CC_MVSC_BCR] = { 0x810 }, > --- > bod