Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756358AbXKZVnq (ORCPT ); Mon, 26 Nov 2007 16:43:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754731AbXKZVnj (ORCPT ); Mon, 26 Nov 2007 16:43:39 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:57338 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbXKZVni (ORCPT ); Mon, 26 Nov 2007 16:43:38 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Oleg Nesterov Cc: Andrew Morton , Pavel Emelyanov , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] teach set_special_pids() to use struct pid References: <20071126142555.GA16528@tv-sign.ru> <20071126201757.GB84@tv-sign.ru> Date: Mon, 26 Nov 2007 14:42:33 -0700 In-Reply-To: <20071126201757.GB84@tv-sign.ru> (Oleg Nesterov's message of "Mon, 26 Nov 2007 23:17:57 +0300") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 36 Oleg Nesterov writes: > On 11/26, Eric W. Biederman wrote: >> >> Oleg Nesterov writes: >> >> > - set_special_pids(1, 1); >> > + if (current->nsproxy != &init_nsproxy) { >> > + get_nsproxy(&init_nsproxy); >> > + switch_task_namespaces(current, &init_nsproxy); >> > + } >> >> Is there a reason for moving this hunk of code? >> >> I don't see one as set_special_pids does everything with either >> struct pid or global pid values. And attach_pid and detach_pid >> don't care. > > No particular reason, except "keep related code together". > > There was another minor reason. Without the next patch we are doing find_pid(1). > This is correct, we scan the global namespace, but still it looks a bit tidier > to switch namespace first, so we could use find_vpid() in unlikely case we need > it. True. I just pointed it out because it seemed an unnecessary chunk. Regardless it is harmless either way. Acked-by: "Eric W. Biederman" Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/