Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp3212332rdb; Thu, 16 Nov 2023 03:38:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeUpnUb6t1bU+A7cDC+ZWXirk4eFurzaOXX2lcnBzSHaRfQuGtkYNF8YgHUpH6QvXYOmqA X-Received: by 2002:a9d:738c:0:b0:6c4:9ca1:f13a with SMTP id j12-20020a9d738c000000b006c49ca1f13amr8410060otk.35.1700134686171; Thu, 16 Nov 2023 03:38:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700134686; cv=none; d=google.com; s=arc-20160816; b=d1vuyB1jq7kyzfzKLr2I6A5jzZgiGCdDIxu58jX0bM5UlSxcFzUBE6/aKnjrrBxVPV f5tdm/bbOJDV6dofQIiune8b0/AEBKFuR0fwfGuYFl3D/Gx3SX5qkQN/TBjzFqmYaZQI BfnnZmy9DG0nzRaYlXlF6Xe7O4eRkALe6EBrXDQgu8cvWH4HZdQyCYM0SwLxGjWWbUHM p34yZYaQ9yorI6lvl86VQbMjEXYxI3OMv8Fza4guMDSMAZQ/K7Yj0euR+KkqYCdBzAPF +tlZEZnTFUBoDQfpeGfvYPtOE77R4MWZLx6uWSh/lU56gMtWZhgXLrdUFsQUQ4iyWNHI oGUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=QKz33fRXGncP/6ISpiMtpAHGGFNNUHHfOEZzGuOATSM=; fh=imEUYFMWNAswUReKvRjfxMdxClbyPvDv/CgRMaWcaO8=; b=GjW+gc/wW1gx079EkMeFTF3jek+6XY/Blr3IwZHV1dbIhqnZJL+dpRU6DhwyB5d7+P GkhAftfZxQZoPqIdtUrpYMh54Kkfq6OoGKidRutbPb4kTJ9o+0hbRewqlBZVcvCxJOP6 lWfnLkUc8RgOAdSEdUvFGCjgKn1G06ntpMWaesWEfa4qV+vhKVljesWoFDzGsMVVbOJa c/82iNqFrekQOmqna477u6sln7G/ZFj4wScipgd2D3DIwwapJvZGmhX1uDLIKgsavQOO zQ4MCX39ZbCo1hyFr1HF3sWzZPeBiXO4kumuHM9p4mZkYVaQqObrrEwgrzW45vXeIO23 ADGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OofVp+nU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id k186-20020a6384c3000000b00578b37ad24bsi11578731pgd.619.2023.11.16.03.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 03:38:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OofVp+nU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 981C7807832C; Thu, 16 Nov 2023 03:38:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344966AbjKPLhz (ORCPT + 99 others); Thu, 16 Nov 2023 06:37:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230340AbjKPLhy (ORCPT ); Thu, 16 Nov 2023 06:37:54 -0500 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CA66181 for ; Thu, 16 Nov 2023 03:37:51 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7788fb06997so40494385a.0 for ; Thu, 16 Nov 2023 03:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700134670; x=1700739470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QKz33fRXGncP/6ISpiMtpAHGGFNNUHHfOEZzGuOATSM=; b=OofVp+nUp+XQ97eREPQOFhHLrynRMYl9KF4R3s7b5+B0eVwr0QgQ6CY+OQtERYLTij GK0VPlIyUq0rjt060lSQXqOW/OjJw6sE+rqTNrjc+3Rqmzdz6mJnskRAkD0H9J3cXXF+ bvbqlknt1WtMkfS3PwR8sELKgCUPtSgvQhpwBVLQv3NEpCfLZfWjyUbD63OStcjCd7P0 CAbwOyTHx8tFM2QOtBdFQA4X4daPnLo2vWpMhxEUQBtIN1/2aEm+uReaR2Lgi8LFVlxz RGxXGmNYJNie5JdW1BzT7FgnlSQIabT4JHnvCcfAFblGPwF7S3JFrKpPTGs/ONEsciSX epyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700134670; x=1700739470; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QKz33fRXGncP/6ISpiMtpAHGGFNNUHHfOEZzGuOATSM=; b=ZswG40/WB5AXTgYFbWeuGUZqHY7rBpKhn0vsHjdETVsl3M4kTiGEAjvAm3yhpB0B12 BDh81seuYD0IkwAk3GpTAzV/QJvRMKz7/1TIt5jKiEimsaqRu03OpCdEdFOdfsb/+DtH ndhrei81fzsYCraPUWEWlpH5Ze3N2kPHaI9sNL4UUqNVxutrRt3qWjei+o0UkCnvkASj kKMZ3K4HLgsfolzoX73ZaNZiWCnstJC511RUvLCkHHBNkPdKrmSrzXTgpeYTrsnyeIqt mT5GaI1OQjSBSjQt5JWWgOTCd/vbsD2E7JpmRyODURwC02o+YKzdt4kRN3RDpxRFHWna VECQ== X-Gm-Message-State: AOJu0Yy0OSpu6al4K4D35Ba0bbAX1GSUiyQmXaFj2eQKy9XdfJOBV3M2 31Jmi+5g8auE2eeDXaazBSBC7A== X-Received: by 2002:a05:620a:201b:b0:778:8b39:166e with SMTP id c27-20020a05620a201b00b007788b39166emr8783145qka.20.1700134670357; Thu, 16 Nov 2023 03:37:50 -0800 (PST) Received: from [192.168.212.13] ([12.191.197.195]) by smtp.gmail.com with ESMTPSA id u8-20020a05620a022800b00767da9b6ae9sm3697236qkm.11.2023.11.16.03.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 03:37:50 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 12:37:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: add bus-reset-gpios property Content-Language: en-US To: Chris Packham , "wsa@kernel.org" , "andi.shyti@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "gregory.clement@bootlin.com" Cc: "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20231115035753.925534-1-chris.packham@alliedtelesis.co.nz> <20231115035753.925534-2-chris.packham@alliedtelesis.co.nz> <5a52b0c9-8858-4f55-8dd7-9269c29c10a7@alliedtelesis.co.nz> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <5a52b0c9-8858-4f55-8dd7-9269c29c10a7@alliedtelesis.co.nz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 16 Nov 2023 03:38:03 -0800 (PST) On 15/11/2023 22:53, Chris Packham wrote: > Hi Krystof, > > On 16/11/23 10:29, Krzysztof Kozlowski wrote: >> On 15/11/2023 04:57, Chris Packham wrote: >>> Add bus-reset-gpios and bus-reset-duration-us properties to the binding >>> description for i2c busses. These can be used to describe hardware where >>> a common reset GPIO is connected to all downstream devices on and I2C >>> bus. This reset will be asserted then released before the downstream >>> devices on the bus are probed. >>> >>> Signed-off-by: Chris Packham >>> --- >>> >> ... >> >>> Documentation/devicetree/bindings/i2c/i2c.txt | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt >>> index fc3dd7ec0445..3f95d71b9985 100644 >>> --- a/Documentation/devicetree/bindings/i2c/i2c.txt >>> +++ b/Documentation/devicetree/bindings/i2c/i2c.txt >>> @@ -99,6 +99,14 @@ wants to support one of the below features, it should adapt these bindings. >>> indicates that the system is accessible via this bus as an endpoint for >>> MCTP over I2C transport. >>> >>> +- bus-reset-gpios: >>> + GPIO pin providing a common reset for all downstream devices. This GPIO >>> + will be asserted then released before the downstream devices are probed. >> I initially reviewed it, but did not think enough about it. After more >> consideration, I believe this is not a property of the I2C bus >> controller. This is a property of each device, even if the GPIO is the same. >> >> Linux kernel already supports shared GPIO, so you only need >> enable-ref-counting on it. > > That's the kind of breadcrumb I need. Although I can't see > enable-ref-counting as any kind of DT property. Do you mean > GPIOD_FLAGS_BIT_NONEXCLUSIVE? It's not a feature or property of Devicetree, but missing feature of OS. Best regards, Krzysztof