Received: by 2002:a05:7412:b101:b0:e2:908c:2ebd with SMTP id az1csp3251827rdb; Thu, 16 Nov 2023 04:52:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEww3HKP3YugmnIFBrB62/QMr5oDbEKToxDpYBaCVjB7x74OCHe9rMSeQJ+DxxQ5xVeEN3y X-Received: by 2002:a17:90b:4d8a:b0:280:699:c5c with SMTP id oj10-20020a17090b4d8a00b0028006990c5cmr15191160pjb.21.1700139163314; Thu, 16 Nov 2023 04:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700139163; cv=none; d=google.com; s=arc-20160816; b=PoxkHLyfouDC8M1Ut33/BxprvYeJk5zB21+uUSEcmnpJz1uEmtmyhlirgzoXCtIuTb 1BukzSNmja/S989Ppc3jDB3n21i6l1w8cxrYaMjfLlmQrEUepqlfl+rfo5qEH6Tu7S3R /KhV+mDfgzSgrIRgROwC2KGbUtD393TTlveL9uIbuoBss1ktAePc5Xxcv8qQlf+02Rt5 74EUfEQPq5uUDbYLCEajRR90lCaW0fLRoAIBLWqwIo8qzvVqJeRJa9kvtonqbGKt5ATN HVyOiP4TqQ0vG2/QkM5ZftNI36VdYKlaXVsObJKsSzF2rILIYB0yW/31DgLt4LyJxUNI NhHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZVDDhjRstd/kU/0OqghBmhN2HaoOfhbkDnF6K+OWoms=; fh=1W+Sp2dxc4gX1nQXk3pYH9AWNhCM2KAiHN4+Y7wQrA8=; b=xwv4Mof0NmVtrs4nL4ZIBq+3lS6qtsqoSpz0i+8aR32/hikam06mvkJFq8DB5Cn7/k U0Hy77rUDAPiEr95mM7fZKskx648sM6AnGh8xBM/kCBUQEYPGr7Oxv2A8eEGK1wua5qa UAuQnllHrzWSSaHlvk4qYAfHNfc/VAD994kKUu/6gpGIkXA6B6bKOUpYJWGDHv6tyZv6 zbVgj+eR+DRoboZeBYHqp/N+mpQr8PIBiWl/AU/mwkZC4y7xpuqueSyPmQvmu3PbO2mn eynMNP62pbepQWYBrkQoAw5g2Y4fx6rOrdnNsQEtaCdd+0nzNNt43p0yd//IoC1u1bjp z9ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=CJrsqk56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id nh18-20020a17090b365200b00280298a68c4si1865353pjb.186.2023.11.16.04.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 04:52:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=CJrsqk56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id AD4B581C509C; Thu, 16 Nov 2023 04:52:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345145AbjKPMwd (ORCPT + 99 others); Thu, 16 Nov 2023 07:52:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344966AbjKPMwc (ORCPT ); Thu, 16 Nov 2023 07:52:32 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86216193 for ; Thu, 16 Nov 2023 04:52:28 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4249D22917; Thu, 16 Nov 2023 12:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1700139147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZVDDhjRstd/kU/0OqghBmhN2HaoOfhbkDnF6K+OWoms=; b=CJrsqk56sxOYEro5aDypNUHOVOSoMMi1i5G9GzGkaKu5HexSd3PoU8yUA/+l3+aVcRQs7X +Q2wWwWK5tVt2kpxGhXhzYd3Ih9PGrdBzwgLmczAWQhu6BJixLUqi9R73BKECsJhQp5LQ5 i2HOCJeMm0MQyhW6aL5bONn4GYzomjk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AC161377E; Thu, 16 Nov 2023 12:52:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nkJKAIsQVmW7egAAMHmgww (envelope-from ); Thu, 16 Nov 2023 12:52:27 +0000 Date: Thu, 16 Nov 2023 13:52:26 +0100 From: Michal Hocko To: Mel Gorman Cc: Charan Teja Kalla , akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, hannes@cmpxchg.org, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/3] mm: page_alloc: correct high atomic reserve calculations Message-ID: References: <905d99651423ee85aeb7a71982b95ee9bb05ee99.1699104759.git.quic_charante@quicinc.com> <20231116095901.72oqtjoiqzt3tfhj@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116095901.72oqtjoiqzt3tfhj@techsingularity.net> Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -7.76 X-Spamd-Result: default: False [-7.76 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[9]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.96)[99.82%] X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 16 Nov 2023 04:52:40 -0800 (PST) On Thu 16-11-23 09:59:01, Mel Gorman wrote: [...] > This patch in isolation seems fine with the caveat that such a small > system may find the atomic reserves to be borderline useless. Yes, exactly what I had in mind. Would it make sense to reserve the the pageblock only if it really is less than 1% of available memory? -- Michal Hocko SUSE Labs